Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <0de4ce43-bba5-4a6a-929a-7dc9bfea79cd@arm.com>
Date:   Thu, 19 Oct 2023 15:28:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 00/25] timer: Move from a push remote at enqueue to a
 pull at expiry model
To:     Anna-Maria Behnsen <anna-maria@linutronix.de>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org, John Stultz <jstultz@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Eric Dumazet <edumazet@google.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Arjan van de Ven <arjan@infradead.org>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Frederic Weisbecker <frederic@kernel.org>,
        Rik van Riel <riel@surriel.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sebastian Siewior <bigeasy@linutronix.de>,
        Giovanni Gherdovich <ggherdovich@suse.cz>,
        "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
        Srinivas Pandruvada <srinivas.pandruvada@intel.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>
References: <20231004123454.15691-1-anna-maria@linutronix.de>
 <1891aa6c-037f-46a1-9584-17aaa63e4e74@arm.com> <87fs26909o.fsf@somnus>
Content-Language: en-US
From:   Lukasz Luba <lukasz.luba@arm.com>
In-Reply-To: <87fs26909o.fsf@somnus>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/19/23 15:04, Anna-Maria Behnsen wrote:
> Hi Lukasz,
> 
> Lukasz Luba <lukasz.luba@arm.com> writes:
> 
> [...]
> 
>>
>> I have tested this on my 2 Arm boards with mainline kernel
>> and almost-mainline. On both platforms it looks stable.
>> The results w/ your patchset looks better.
>>
> 
> Thanks for testing!

You're welcome


> 
> [...]
> 
>> The performance looks good. Only one test 'Speedometer'
>> has some interesting lower score.
> 
> Is it required to look into this more detailed or is the regression in a
> acceptable range for you?

That's something which we can ignore. I have tested with a different
cpu idle governor and it goes away. So, I suspect that the governor
heuristic just probably was confused. I will spend some time on
different idle governor tuning.

Feel free to go forward with this patch set.

> 
>>
>> Fill free to add:
>>
>> Tested-by: Lukasz Luba <lukasz.luba@arm.com>
> 
> Thanks,
> 
> 	Anna-Maria
>