Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp391278rdb; Thu, 19 Oct 2023 07:29:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGz4zXO+J871/L42GY/E5jTZBPbKsXkIJYAeeaaiqhXIKctZFYH9ueHlNSWE/H2jexXQSrf X-Received: by 2002:a17:90b:48c4:b0:274:8951:b5ed with SMTP id li4-20020a17090b48c400b002748951b5edmr2955162pjb.20.1697725751908; Thu, 19 Oct 2023 07:29:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697725751; cv=none; d=google.com; s=arc-20160816; b=pa3ZymSZTpLkbn2NkBbSKzaZdRmvT1Tan2Zf9Vp1b3snH5/3I3NHeNkf8QW2WMbKxq OHSdSuqThWz0d5L1H0gqqQa7ZNAo/ZO5PTw+uba/V5EEboxlZTu30EJwsPggiHDQaXXi Bce0a2v2RLDuRtYJo4q9cYLfGcmwj/NvFM66bFDUWoye6B4Cu2YOwaMHiHVmkIcgk9BP fPrtk+HW3i3jspeCSnSvH0BsFzS3WZz9z6Ezy5OC686bH4ndf9mN94pCi85zBUJKBJwc 2vDyMpy3KuBmW/VbzN32e/yKo9W1MQ7OHQ/H4JtwbVajOsesK5IZJd/1CQWRoP7l99TX hReA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aj2Bx1/SaJRmF5jRSnR4D+OQWnw2uMhft3hr1ZuM+II=; fh=wuZ648MubKHeikXb5CnlBL6OoSBwXUDRLRQZVFa8UH4=; b=rNqPZeZv6uu2fZl7AhS73v63zUGiVHtSHXYIax8Ng8S76IbUIXFp6KEsjwKUXc7njn CuJphDyrwQaJT9cbJqcb6YghRVHclKzlYtYUqGFOabSNR9EWZ8ASAM2wt0YbDC0ut1wG LyxChirXQ6hITnO/f9Ygr1gLwCa8dbo1LjwhRuo0lPNPJqJ3mV+SPfN187vfM6WfdgJ/ JHo7SgIUGJ/3G95zmzkR+QMBtVDXtEBzRv24K6WVBdEmPfAhfF/+KWBPIzz8sxYW9uEX rH06hAmdhOLRI+J27yiEKp2To/POamohv86MVw6ZkXySAbmwluGUBuQsyzWs+OKAipon yqAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jSoIP1Bv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id ms19-20020a17090b235300b002740f8fa612si2099003pjb.21.2023.10.19.07.29.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 07:29:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jSoIP1Bv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 86D7083700C1; Thu, 19 Oct 2023 07:29:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346042AbjJSO2v (ORCPT + 99 others); Thu, 19 Oct 2023 10:28:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235419AbjJSO2u (ORCPT ); Thu, 19 Oct 2023 10:28:50 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B977181 for ; Thu, 19 Oct 2023 07:28:48 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF1DBC433C8; Thu, 19 Oct 2023 14:28:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697725727; bh=vrmCvzbkkBVSxXWM3SZHEqQqXmxnifCIGVOhub0zocA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jSoIP1BvdZ+4pK32XX6bDu52py28olAPlSy2C1zHeWXO/zpTECaHzWH4A/NX9Mh15 b1I7Z/k+aDZkHCHgp63m1dL7cbiFWjeD6omFbo7dV7Knf2jUfAnmVapMPJKnHS2Vva KEervM3AFGoVRIuAprZH1N5DApVKDRSgZZuVQ/GBomFTl6QMuRSDimtsm8UcVk1KYs iDcIIZ5yFZnFYH3HBJTPaoJfjuaOSK9v+bFT38ay4vLJdfvV5vi7EB0NHygZNDSYtU R3tR4CumlrVQ9Z7ciMMcEym65Rs8iwuydm4cVM2eJhVeq4syldPJ7I9KfNUpHJjsPz BKqP6zhWLyrVQ== Date: Thu, 19 Oct 2023 15:28:43 +0100 From: Conor Dooley To: Kris Chaplin Cc: thomas.delev@amd.com, michal.simek@amd.com, krzysztof.kozlowski@linaro.org, robh+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, git@amd.com Subject: Re: [PATCH v2 0/2] w1: Add AXI 1-wire host driver for AMD programmable logic IP core Message-ID: <20231019-dilation-monogamy-580b3be46638@spud> References: <20231013093109.37165-1-kris.chaplin@amd.com> <20231019142526.10592-1-kris.chaplin@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MgQN09eSoyCijghA" Content-Disposition: inline In-Reply-To: <20231019142526.10592-1-kris.chaplin@amd.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 19 Oct 2023 07:29:09 -0700 (PDT) --MgQN09eSoyCijghA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 19, 2023 at 07:24:16AM -0700, Kris Chaplin wrote: > Changes since v1: > Updated IP name and binding to axi-1wire-host and filenames to match > Comment pruning where operation obvious, additional comments where not > Unwrapped helper functions for register read/writes > Removed un-necessary device reset on fail to add device > Fixed duplicate clock disable in remove function > Move bus master structure to per instance > Improved hardware testing with multiple w1 instances >=20 > Add a host driver to support the AMD 1-Wire programmable logic IP block. > This block guarantees protocol timing for driving off-board devices such = as thermal sensors, proms, etc. btw, please do not send a vN as a response to the v(N-1) patchset. It ends up hiding things in the depths of people's mailboxes that sort by threads. Cheers, Conor. >=20 > Kris Chaplin (2): > dt-bindings: w1: Add YAML DT schema for AMD AXI w1 host and > MAINTAINERS entry > w1: Add AXI 1-wire host driver for AMD programmable logic IP core >=20 > .../bindings/w1/amd,axi-1wire-host.yaml | 44 ++ > MAINTAINERS | 8 + > drivers/w1/masters/Kconfig | 11 + > drivers/w1/masters/Makefile | 1 + > drivers/w1/masters/amd_axi_w1.c | 395 ++++++++++++++++++ > 5 files changed, 459 insertions(+) > create mode 100644 Documentation/devicetree/bindings/w1/amd,axi-1wire-ho= st.yaml > create mode 100644 drivers/w1/masters/amd_axi_w1.c >=20 > --=20 > 2.42.GIT >=20 --MgQN09eSoyCijghA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZTE9GwAKCRB4tDGHoIJi 0r3oAP4/hAJWtFGlfZ1oFX0R/zBl4H3FGxM0AOyERrzTlQgmvAD/amRWRevk1fWr jByhe3brBXKMb/OxEUO+GZe+PFmoiQQ= =8IRd -----END PGP SIGNATURE----- --MgQN09eSoyCijghA--