Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20231019100639.4026283-1-andre.draszik@linaro.org>
In-Reply-To: <20231019100639.4026283-1-andre.draszik@linaro.org>
From:   Sam Protsenko <semen.protsenko@linaro.org>
Date:   Thu, 19 Oct 2023 09:31:36 -0500
Message-ID: <CAPLW+4=oY1PjTTbsLq6QL5k37CZnqY1NprC1AxyAMkO4zBBDsQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] tty: serial: samsung: drop earlycon support for
 unsupported platforms
To:     =?UTF-8?Q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>
Cc:     linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        alim.akhtar@samsung.com, linux-serial@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 19, 2023 at 5:06=E2=80=AFAM Andr=C3=A9 Draszik <andre.draszik@l=
inaro.org> wrote:
>
> Commit 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") removed
> support here for several old platforms, but kept support for earlycon
> for those same platforms.
>
> As earlycon support for otherwise unsupported platforms doesn't seem to
> be useful, just drop it as well.
>
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Andr=C3=A9 Draszik <andre.draszik@linaro.org>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

>  drivers/tty/serial/samsung_tty.c | 16 +---------------
>  1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsun=
g_tty.c
> index 6b8d4b4402e9..a74ecc78f4e0 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -2735,17 +2735,7 @@ static struct samsung_early_console_data s3c2410_e=
arly_console_data =3D {
>         .rxfifo_mask =3D S3C2410_UFSTAT_RXFULL | S3C2410_UFSTAT_RXMASK,
>  };
>
> -static int __init s3c2410_early_console_setup(struct earlycon_device *de=
vice,
> -                                             const char *opt)
> -{
> -       device->port.private_data =3D &s3c2410_early_console_data;
> -       return samsung_early_console_setup(device, opt);
> -}
> -
> -OF_EARLYCON_DECLARE(s3c2410, "samsung,s3c2410-uart",
> -                       s3c2410_early_console_setup);
> -
> -/* S3C2412, S3C2440, S3C64xx */
> +/* S3C64xx */
>  static struct samsung_early_console_data s3c2440_early_console_data =3D =
{
>         .txfull_mask =3D S3C2440_UFSTAT_TXFULL,
>         .rxfifo_mask =3D S3C2440_UFSTAT_RXFULL | S3C2440_UFSTAT_RXMASK,
> @@ -2758,10 +2748,6 @@ static int __init s3c2440_early_console_setup(stru=
ct earlycon_device *device,
>         return samsung_early_console_setup(device, opt);
>  }
>
> -OF_EARLYCON_DECLARE(s3c2412, "samsung,s3c2412-uart",
> -                       s3c2440_early_console_setup);
> -OF_EARLYCON_DECLARE(s3c2440, "samsung,s3c2440-uart",
> -                       s3c2440_early_console_setup);
>  OF_EARLYCON_DECLARE(s3c6400, "samsung,s3c6400-uart",
>                         s3c2440_early_console_setup);
>
> --
> 2.40.1
>
>