Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Thu, 19 Oct 2023 11:02:10 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
        alexandre.belloni@bootlin.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        corbet@lwn.net, joe@perches.com, linux-i3c@lists.infradead.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, gregkh@linuxfoundation.org,
        imx@lists.linux.dev, jirislaby@kernel.org,
        linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/5] i3c: add slave mode support
Message-ID: <ZTFE8hrRgPBrb7e3@lizhi-Precision-Tower-5810>
References: <20231018215809.3477437-1-Frank.Li@nxp.com>
 <20231018215809.3477437-2-Frank.Li@nxp.com>
 <dd06c2d3-e273-4356-835b-42619543dfab@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dd06c2d3-e273-4356-835b-42619543dfab@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y1uzen23AC68fy4M3SEOegkSnOs6VkSTF8R2/kM+CqkTjC1hCjXXQjq7k6Kk?=
 =?us-ascii?Q?zav6tlWxqO2DWtBaVH8/A3DADup5I6L8exowLXhBdRQs+5EtsGN+hc+QLKbw?=
 =?us-ascii?Q?G8IfqTToqEodokibRjOM4M0fZy3+iD3jfgdC/obSXQEsq2Q5dXjB6nOZpel4?=
 =?us-ascii?Q?f4fs+VERp3nGuk1VcWND8ALnNij+9S3umPpq3s6Ao5YAewIYa44JRvotqyf3?=
 =?us-ascii?Q?d/wdGkzySetNUJrH97NlmMC3sseZd63djsGOAlCp3vrnbdvfI8XgJTi2HDWm?=
 =?us-ascii?Q?kn39gZjCKmWi7nfGb0uEVH4wEDNe2wL4dcp6rVggBBUydLMNvjoT5CNRni5S?=
 =?us-ascii?Q?Yd9OpyxBprLE94LTi6TfsgvrKcxKfk9n6PkcGnD1zon5Kr0py6MnWpY49qSK?=
 =?us-ascii?Q?bx9ne+gZCYBlfVx3J7NdsJBgUFhCLSXfRuww8QdZcbQAhC9G5OnUFYM20R5u?=
 =?us-ascii?Q?3DDWIL3exM7fSSBfCUD23UOj+kiAa8iw6nh6XCqPlVNOrTJHU9HZQg7ug/UJ?=
 =?us-ascii?Q?Fv+ZKlPmjbLVJMAQSpvp3KGOfCriNgyMzFvSVcKBXaWmZw6muYxe3WCeYVtW?=
 =?us-ascii?Q?xMz7kc0BhU+VZbY1NQWZRw3j8EAjumhxpMEgC0kTWI/gWLc5QOrYiR7gMJz0?=
 =?us-ascii?Q?uhoHq5APSNlcCzD7Fp33ZezEGZ6wmrV4oBgpTHKhbfsk8Hqn2bXEgJioVMy5?=
 =?us-ascii?Q?rk/WMeeoTtRz6DDaqovSgBVKsbalrcSLw7BgDJJM99Tx6/CQwtVJ8cs/7anc?=
 =?us-ascii?Q?t4xafduIrqLzOquQiyg3SThdOuRYFEITYxCKTBAly0I2IqgrbOfrcV8oknXo?=
 =?us-ascii?Q?W5km1UZxp/rgNZeul6aNmpTHeE4BwKT0AqoDISHmW3JZU4PoSPVp1EgtioHO?=
 =?us-ascii?Q?Fn5ayv/7M+PL3HfZiyE9UYj2X6IwPF50NoPtzZY2DrbTWJ/+iSabgDFIgLvL?=
 =?us-ascii?Q?6wXx3PO1u+dDrBYL/WOtb4NAsny8ZDRgtmRjPLQKwZCQ+zL1EPT7qGChTZEO?=
 =?us-ascii?Q?qVEEv++feVdrxma8HcjDIe8j2AAAIiXQF1+EyZThx2kcszrY59zkXfKNQRiS?=
 =?us-ascii?Q?5kFPHUcxuq37azP3iC5wo7/blFUTe7ETtA8WISPsOrpAd+SFYk4eHD4RhlpJ?=
 =?us-ascii?Q?nTclptrZeQVjzw6BEOVFcTNf0KMBmIm3kGNs9+gdEKM057pyWruTQv912VlG?=
 =?us-ascii?Q?tkITRqxJ4fVq2zbHOjiy0fIkOW5Jtqj0zT/hZP8b+HJ17VnKWaUmPn9Ss2Pc?=
 =?us-ascii?Q?KmgussQDnkwENjuWUzTyOWFWG59ELrIEoPlHojd4Hg73XYUI2/vWkmNDPPAo?=
 =?us-ascii?Q?Y9JAoAJiD5gp4UUDyydmNEwV1Lu8+LOvud1ojJWRMSL+QcYXw+OOGdzH5+Am?=
 =?us-ascii?Q?92x7eICqVE+2E0SlK1TH6yc5RYB9FVUNLCnSPoN3soKOpyHsKK41z4/nw7VX?=
 =?us-ascii?Q?71IV8o8FHEEcyL6lV82mK9knaWEbTkU4WJVQp6mHvxcitxiH21nBBOYZpOsi?=
 =?us-ascii?Q?jzIAhTWNMdJ1Yfz7yCw+OeUqy17B6TZB9E2yyMfSoNOE+Rf/s8a2dmWFs+bU?=
 =?us-ascii?Q?XBUzIQhd4OnYucK6kriDfzGg9gsSYKKysJC4PQBf?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca83ba9f-c26a-4c53-aba7-08dbd0b463a1
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 15:02:18.8986
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vXICP/9WotQ3LOcKdW+EXuKigcII7J8u7PVCQrzHlyh0h5bpvxXfi0Lpbtl4diuz6mi+dEsJU+/0+XAXFnYRuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8374
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 19 Oct 2023 08:02:34 -0700 (PDT)

On Thu, Oct 19, 2023 at 09:00:05AM +0200, Krzysztof Kozlowski wrote:
> On 18/10/2023 23:58, Frank Li wrote:
> > Introduce a new slave core layer in order to support slave functions in
> > linux kernel. This comprises the controller library and function library.
> > Controller library implements functions specific to an slave controller
> > and function library implements functions specific to an slave function.
> > 
> > Introduce a new configfs entry to configure the slave function configuring
> > and bind the slave function with slave controller.
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  drivers/i3c/Kconfig       |  26 ++
> >  drivers/i3c/Makefile      |   2 +
> >  drivers/i3c/i3c-cfs.c     | 389 +++++++++++++++++++++++++++++
> >  drivers/i3c/slave.c       | 453 ++++++++++++++++++++++++++++++++++
> >  include/linux/i3c/slave.h | 503 ++++++++++++++++++++++++++++++++++++++
> >  5 files changed, 1373 insertions(+)
> >  create mode 100644 drivers/i3c/i3c-cfs.c
> >  create mode 100644 drivers/i3c/slave.c
> >  create mode 100644 include/linux/i3c/slave.h
> > 
> > diff --git a/drivers/i3c/Kconfig b/drivers/i3c/Kconfig
> > index 30a441506f61c..d5f5ca7cd6a56 100644
> > --- a/drivers/i3c/Kconfig
> > +++ b/drivers/i3c/Kconfig
> > @@ -22,3 +22,29 @@ menuconfig I3C
> >  if I3C
> >  source "drivers/i3c/master/Kconfig"
> >  endif # I3C
> > +
> > +config I3C_SLAVE
> 
> It doesn't look like you follow Kernel naming convention (see coding style).

I checked I3C spec. It use words 'target'.
Is it okay using I3C_TARGET?

> 
> > +	bool "I3C Slave Support"
> > +	help
> > +	  Support I3C Slave Mode.
> > +
> 
> 
> 
> Best regards,
> Krzysztof
>