Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp418125rdb; Thu, 19 Oct 2023 08:07:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEuDatZ54/jVWaSwk4Xsikkbl5rQL3t1uC3shNoogh+XA0f5L4b9oKiSufN30tpigosxkuC X-Received: by 2002:a92:d482:0:b0:34b:aebd:a512 with SMTP id p2-20020a92d482000000b0034baebda512mr2611279ilg.14.1697728063511; Thu, 19 Oct 2023 08:07:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697728063; cv=none; d=google.com; s=arc-20160816; b=al81IolIZN3tcvYGtJ9qQuHcTso7r9fN4+CW9xv4vbK9PUvvA0Eo5IuLcFzDqZtkIE qnmWN4ADWosHDNXHpj0+H5j42j11ENh13MyvOLYTfrAjvElI3DPY6TNxar31/aYR7M7f mAd6H4/tu4cdXQX+1QzZ/9+Y9DiPf4MtQ//6DS0WLlxJFGWW64QS6HGdPjoorjVsERfr K1/SgteHB4CmT3SWpibsdGk21K0YPvOQ9DC0G1vtV5lWFyr6Vb/HgQNNrOVpZCuqgtg0 By/idIK7Z8XOno4OQMguPNiiViNVkoa0iOI16kNDr9z9u3nkgf7eULjjCQi56dIEJg7U OVXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=YEWprmYpoYPHIElmYMgnPZvVKsSszYHwSAF+toFkvg4=; fh=sCriQ7/2nt5D2vAB/Ra7jLtjWQdsqDRto1Qs6xfAg4c=; b=kAPiqieo7/lDs+uQzDzZ/m7/rJzbB4d6oH5YU73eUQzM/Z5VhJJJx48XDMpLv/aR+G ZRdDkqls0Yg+kuowTk+kE+5KRK32g9OhFsr8itN7Cdv1ifjtYoyjY1W+mwc3uiPFXg59 1zviS7Iur0SSlSOuck8Q4J9LpwifGcwnoix3sbhWTttGK16ZMb45qfMHGfH6sb6MAb6O m0b8hQvSedQJcFjTdOnDnmRxN4ZfzJNvLdjkk6OWA5CdYBPLCsqAuh+WRVZ70BkcPiCS GRmoAsWjCuUHiKpnRvwZ1Ue6Xzt8w1VW4FtCzlXxoCSZe9slYLIQ1I9e30JVA4E1oucO Vd8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="bU/bhre1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id bs2-20020a632802000000b005855bd1ebbasi4350335pgb.204.2023.10.19.08.07.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 08:07:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="bU/bhre1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 70BF9823CE8E; Thu, 19 Oct 2023 08:07:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346240AbjJSPH3 (ORCPT + 99 others); Thu, 19 Oct 2023 11:07:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345800AbjJSPH2 (ORCPT ); Thu, 19 Oct 2023 11:07:28 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C9E011B; Thu, 19 Oct 2023 08:07:27 -0700 (PDT) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39JDfXx1014951; Thu, 19 Oct 2023 15:07:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=YEWprmYpoYPHIElmYMgnPZvVKsSszYHwSAF+toFkvg4=; b=bU/bhre1DWeo5CPdRE7GmcnokkbyN/bw27AGLUfBE/5tsWnr8mhxgzHvRXEQWNN0ryAa aVtXW9AxNd0nWZ2cvvQINjQkATmMTt+/u8uzFrHIRY7HFgvyVLyDOmRsdvatKIpUzL+B AbiLqA8PHyGeFN/M85tOlZNqrtINE0VuAIJwFLnWBiqkEtW8PNA9rX5hSdTPtv1aRpby 2LWJzSJwuxeUya6aBH37/BsMlR8irxBTHGUXgv1PTGVrfUosmL+LrVd50lJz59AU4TrA /nKcB4No3OJZ5kcRDsenMqYO0wPeWuKmFXVqjINKLLx27CdGm5ElCDbxdy3X0pJ9Bn75 Fg== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tu3pj0d20-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Oct 2023 15:07:22 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 39JF7LJE031825 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Oct 2023 15:07:21 GMT Received: from [10.48.241.70] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 19 Oct 2023 08:07:21 -0700 Message-ID: <5581120f-a3df-46c6-ab02-02e97f85d94d@quicinc.com> Date: Thu, 19 Oct 2023 08:07:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] wifi: ath11k: fix temperature event locking Content-Language: en-US From: Jeff Johnson To: Johan Hovold , Kalle Valo CC: Pradeep Kumar Chitrapu , , , , References: <20231019104211.13769-1-johan+linaro@kernel.org> <20231019104211.13769-2-johan+linaro@kernel.org> <4233c8af-5911-40bf-b5ba-dd0a63863a45@quicinc.com> In-Reply-To: <4233c8af-5911-40bf-b5ba-dd0a63863a45@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: NbSrSioYAYZiZfrAbTSB-2m-lbm-dqCj X-Proofpoint-ORIG-GUID: NbSrSioYAYZiZfrAbTSB-2m-lbm-dqCj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-19_14,2023-10-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=597 clxscore=1015 spamscore=0 adultscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 phishscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310190127 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 19 Oct 2023 08:07:32 -0700 (PDT) On 10/19/2023 8:04 AM, Jeff Johnson wrote: > perhaps have a goto cleanup that does both the unlock() and the kfree()? or goto exit to be consistent with others, including the DFS radar event