Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Thu, 19 Oct 2023 17:36:04 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Saeed Mahameed <saeedm@nvidia.com>,
        Leon Romanovsky <leonro@nvidia.com>,
        Jason Gunthorpe <jgg@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
        linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: mlx5 ConnectX diagnostic misc driver
Message-ID: <2023101923-tried-provable-72e7@gregkh>
References: <20231019082451.785aa123@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231019082451.785aa123@kernel.org>
Precedence: bulk

On Thu, Oct 19, 2023 at 08:24:51AM -0700, Jakub Kicinski wrote:
> > The ConnectX HW family supported by the mlx5 drivers uses an architecture
> > where a FW component executes "mailbox RPCs" issued by the driver to make
> > changes to the device. This results in a complex debugging environment
> > where the FW component has information and complex low level state that
> > needs to be accessed to userspace for debugging purposes.
> 
> You're being very dishonest towards Greg by not telling him that this
> is a networking device, and the networking maintainers explicitly nacked
> this backdoor. Nacked it, because you can't answer basic questions like
> "what are the use cases" with more than "custom config and debug".
> 
> Whether Greg wants to take this into the "misc" pile is entirely up 
> to him, but you gotta give him more context.

Well, in this case, no way in hell will I be taking this.  If this is a
networking device, it needs to go through the normal networking driver
review process, thanks for the heads up.

greg k-h