Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp443285rdb; Thu, 19 Oct 2023 08:43:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7ijfQuMqaLlQob38ESutRspgEhcKKXU6DPc2O6aer+OF2OxHyoWgrxYi4KM+Bh4vAQVaf X-Received: by 2002:a17:90b:3704:b0:27d:5964:4eec with SMTP id mg4-20020a17090b370400b0027d59644eecmr2567643pjb.1.1697730210490; Thu, 19 Oct 2023 08:43:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697730210; cv=none; d=google.com; s=arc-20160816; b=tFZhGafbBHZONmYSvPUuwhd16PvwhaJLV2EJKUJSbWKinmGuRcvq+vkW51Jr3etxd5 H3l5A66UqQ5vRtkJmqrsts+z/5bndYrEGBVfpiwuLTfC+c6xbzWUPjOlBxMZdwIyMcRd foETI4wAF8vr5JyBT1v7HiR3IvYqdG+dyBCYKmK6L5Ehdfqb37fW5Ve3w57Dv2fP8YAE bazMyu/eyjRAW3atGr9qPPLl8VIi8okdlEtrPa5b1BkRuqBcCIz/n8NxapL5sEzPLuvS m2bsF8AnPTg4BvnFwcVU5Q00F3IWmLQf73KkAijSPVj3gJ7qlsN7m/ZkMk4I8CXMhgiz J1Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=m5c5l8SIeAeHvSL1jx8+0q0u+g26FvM5h1CD3FOLwXk=; fh=/aDmCdY+1L4QKQkZAtnAVsrPv0dOl8HSaUbPXwirxIw=; b=LW223jr5iK/oQU/3oyOnV9VXVOl0nzRmRwEYYiIIHiQY8TuopGX9lbaSbIX51uWmnO eBbL9dWcUdshXklQbPf54CmuCv6knKT1AZyag+aH5Y83ysOEO5EmP4FNH8dFn77+2/t1 TSmnBLcarqNh1opq3xzW0smfI95l7oZkowhgca9froDLkydB7QSyoNdQtp3kpSWz3cIg dP3G61gYN/mNoRuybGh2GslYbPOlFoZ/XAfl/+3wWvnm4W+bkto/DDSov0sdxKbLy/jc DV1bVeZl/dgpGJVJDoL8CDB6ULtAPZ7c6Z7nVBtBNo7YupR0IlsVmcFxjOGiXFnHduXR iA9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fPJP5QNd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id j11-20020a17090a94cb00b00278f5fad9b6si2395881pjw.139.2023.10.19.08.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 08:43:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fPJP5QNd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 838C280936E2; Thu, 19 Oct 2023 08:43:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346384AbjJSPnY (ORCPT + 99 others); Thu, 19 Oct 2023 11:43:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346364AbjJSPnW (ORCPT ); Thu, 19 Oct 2023 11:43:22 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C3D71FC1 for ; Thu, 19 Oct 2023 08:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697730148; x=1729266148; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2oh5pmAgDCd2gtHRN+bxNVTY3NzlD1CeuvsiPYhNrM0=; b=fPJP5QNdPwDubZXSpLdx5s+tYxfSx5W4oolQIBtuEdbV36fwHoKmF73n H0nmizmYAeR5g7MHViIM36F18hhWMjIdqzXLJK6zMqUjY2r0nsQmq4bem BYKg9E74FeTDtlV9nIa/5WBJgwqC4+DkxjUiC5llNQbr7hzVDy9M/vn3n w+kswEQsJGgsLbeR0vdUeEktp1av2zY6Bq3XX2I9RwvpnPNHWmhECdUi8 ym/X/IbId2Iu4uYNeOZe6LhCgIN/3VmsYwJxm2j4Wvfy8jvr5AtQGCs5+ wCogPRXgozvoEjRygrFV8gP9SKCjzXAldzEXKoqzkQej+MJSn4Ya6fDio g==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="386110789" X-IronPort-AV: E=Sophos;i="6.03,237,1694761200"; d="scan'208";a="386110789" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 08:42:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="930648762" X-IronPort-AV: E=Sophos;i="6.03,237,1694761200"; d="scan'208";a="930648762" Received: from jiaminka-mobl1.gar.corp.intel.com (HELO intel.com) ([10.215.251.143]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 08:42:20 -0700 Date: Thu, 19 Oct 2023 17:42:09 +0200 From: Andi Shyti To: Soumya Negi Cc: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , Andi Shyti , Julia Lawall , outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2 1/2] staging: vme_user: Replace printk() with pr_*(),dev_*() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 19 Oct 2023 08:43:28 -0700 (PDT) Hi, On Thu, Oct 19, 2023 at 12:20:09AM -0700, Soumya Negi wrote: > vme.c uses printk() to log messages. To improve and standardize message > formatting, use logging mechanisms pr_err()/pr_warn() and > dev_err()/dev_warn() instead. Retain the printk log levels of the > messages during replacement. > > Issue found by checkpatch.pl > > Signed-off-by: Soumya Negi Acked-by: Andi Shyti Andi