Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <c418625c-755f-4e2f-93e7-f2a5d8c7fba3@amd.com>
Date:   Thu, 19 Oct 2023 08:52:52 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] pds_core: add an error code check in pdsc_dl_info_get
To:     Su Hui <suhui@nfschina.com>, brett.creeley@amd.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
References: <20231019083351.1526484-1-suhui@nfschina.com>
Content-Language: en-US
From:   "Nelson, Shannon" <shannon.nelson@amd.com>
In-Reply-To: <20231019083351.1526484-1-suhui@nfschina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFIyQTkydGVOSFQ3OU9tYlJCU3RONko5UkVvL1Q5TVhPWm5LYXBYcEZBdTJh?=
 =?utf-8?B?c2doUWorYUhKRmsvSURLVllYQTNxbjVYaFMxME4xcnpwenpZV1JhSTU1Z0hy?=
 =?utf-8?B?dC9OT3pnZnlKZ2JWWjNjTzhRaVBaMWRRVlAvbFZ2Y2dMRzJ2WXk2VXV2QU5C?=
 =?utf-8?B?L096d29DVkpMNzQvUG9EQm5XTzVXck5RWmV1b2c5OThsM1lzT3UxY0I1dzhG?=
 =?utf-8?B?bm8xL3NGZ3o2TklzREQxalA2c0RIVlVmMmtzSUNkaGlKamwyWjNyeThYS3do?=
 =?utf-8?B?ajkzczlIV2tPMkxWTkFFQTNjMHVLNmMzM0VTNkpuNytaR1IvTExlWTFmZEdv?=
 =?utf-8?B?UTVScXRBbCtPNWFBcXJUM2cxNlZqVHBuZ3lDQmhYRGtyQ0ZjeWxwcVdycmpI?=
 =?utf-8?B?bDVVTmtweE96NmVvK01Ld3VCYlBsTk45MUZjd3lmMFF0a0ZIeW5Pakw3bUhH?=
 =?utf-8?B?dFN1QW41VzJMUWFNS29HN1BGc3VVRmlxelppNzRxNDVYR0JBRHFLOTBOeUt5?=
 =?utf-8?B?UXhjTlJFb2NoaEc2UmdLUnZyTmNPdk14dzA5N045NFBJZzBnNWxCdzRPZSti?=
 =?utf-8?B?UTZ2R3RFQnFsNXZneXIzdnFUcXU1eXg1TnJKQlQ3dUJTcDNINUVxUW1wT3BJ?=
 =?utf-8?B?RWJiREx5bWk3dmRrWEQ3SlVYSTBHM2FRTk10cFZVQ2Z1L2xuZlRNUGx3blht?=
 =?utf-8?B?T2xjMDRPOUQ4WWdUZit1bHN5L0JsZ3BvcXBVZmF6aXhhVDEvUjM5WTR5bXE2?=
 =?utf-8?B?YndyOEZaMk1wbGxKdUYxV1ZhcDJKeU9xQ2ZOa0hzNDlaWXVxdWpHNHFGTGVs?=
 =?utf-8?B?aG54Y2s0alN3bW0waURKRjRESStPNnJOWmNoQlB2U1lyQXRHcmZKNVd2MHdx?=
 =?utf-8?B?RC90UUc5REl4QTRiS2h2eWZsNEg4MW5NeWFsUkVMNXpJZDFFWEppRjV0Tm5M?=
 =?utf-8?B?VnozaG1xa29xSmU1eklCYjBjVHRtdlR0Qm54dlBUbnA3WlpoTkFzclZLUjhN?=
 =?utf-8?B?V3o1TVEvVElwNFk3aWlOeW10bTBka2g1U2l5RGN5bVoyTG1zTFJuR2FuNVVI?=
 =?utf-8?B?TjZTY0U3elZBWVFkZmxKeVVPbm9mRGpXNS9IaFlJNEl2UnRkQURtTUpwbmFz?=
 =?utf-8?B?K2YzR3Fuc1VwV2Q0bTVNYWtVbGRUeHZFRG1Ud0VHVlFUR2IrOVJtdW9mcjBY?=
 =?utf-8?B?Tmp4UmN6QWpzZEFqRHhxZ01zMWQrNWQ3ekwrbG14c2pvbW9DWnpmM3VqWDc1?=
 =?utf-8?B?NitFTkhONkQxelYwbVI2bHVPTVFqR25NMGs3U1B3cHdXbEhaSGNMQzdYalFp?=
 =?utf-8?B?M3dKL21RYW5ja0J3ZkNuZExQM2wxNmRBeG5BRVA3ekluNG5KUFZsaEYzSXZ6?=
 =?utf-8?B?YWIwVWJtOEFYU2ZqaGp1YXVFaVhwNkhVV2tCbDYzeENGd3NkOC91YVRFOTlv?=
 =?utf-8?B?T20wYSs3a3NIak5QaTUzTy9PMzdDbkQrajVKQTZURGhrWDlyK0FHSkNVNlRm?=
 =?utf-8?B?eW9EYWhxRFNDTVBiR2VQb2JSdVI5ZmdnSHRFM1c1dnNmR2RaV0M1L0JEYWtI?=
 =?utf-8?B?S2hJKzhYMHl4eEFuK1pPYzVyY0plN2pyb3dXWmRIZWZpTFNQeXlRekpBc0NW?=
 =?utf-8?B?clRBalEvazVIVVBQVWs5YnpSNHNnOUFDMmxXZDF6cmpXUDdadFVXaXlmTmlm?=
 =?utf-8?B?ZGVjOXV2YTlpYlljNDFrNFY3UnR2RjlLZDM1NFlaa204UFl5VWYvVUtZK3NF?=
 =?utf-8?B?Vyt2enB1dklETWpRL3JoUzl3S2thUmZKaUZsdjNmUDRZZnp6ejZNdERvK280?=
 =?utf-8?B?UHJldmhPZU5HT3pMMTA3T2xqOCtsa05Ea0dYbUI5cjhvQ212c3pTUGRET3VO?=
 =?utf-8?B?TXhHaVZpNCtLMTAxTERqTlBMd1hjOUZnM2FXOUNVMEwrMFk0ckc4ZnBGUHVz?=
 =?utf-8?B?Mm1mMVN4UXlCT0FydGs3Z1ZaOGVWZFZIVDVGSjcxQjhVUGxGZjNQZ0hmN1p6?=
 =?utf-8?B?NjM5YzdjdUZIUDRwdDVMeXR2bFNqWGtBKzk5dGNldFIvRVhJVHRKM3dCUVBO?=
 =?utf-8?B?QWpTUGtkNERaLzdvdU1tOTlLQU53VHBvK3dHN0JkRHQxSDlqVWY5d3NRNE1Y?=
 =?utf-8?Q?UGxCVBoQxudsbAFpE6L0LKix8?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fb85e3d-6780-4fd7-a8ed-08dbd0bb75fa
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6583.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 15:52:56.1396
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GrMjaly2loqpsSLtY5VBoek+Sl94qaBfzVzj6rD9DXbj+ywoNGky7M/SdLw6/HzMQmAC7ZgarPndNnqeYepQow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8071
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 19 Oct 2023 08:53:09 -0700 (PDT)

On 10/19/2023 1:33 AM, Su Hui wrote:
> 
> check the value of 'ret' after call 'devlink_info_version_stored_put'.
> 
> Signed-off-by: Su Hui <suhui@nfschina.com>

Thanks.

Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>

> ---
>   drivers/net/ethernet/amd/pds_core/devlink.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethernet/amd/pds_core/devlink.c
> index d9607033bbf2..09041f7fccaf 100644
> --- a/drivers/net/ethernet/amd/pds_core/devlink.c
> +++ b/drivers/net/ethernet/amd/pds_core/devlink.c
> @@ -124,6 +124,8 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
>                          snprintf(buf, sizeof(buf), "fw.slot_%d", i);
>                  err = devlink_info_version_stored_put(req, buf,
>                                                        fw_list.fw_names[i].fw_version);
> +               if (err)
> +                       return err;
>          }
> 
>          err = devlink_info_version_running_put(req,
> --
> 2.30.2
>