Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp451554rdb; Thu, 19 Oct 2023 08:57:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNKNfUN74+wKXX6+YJrCRHlaqU12J7dzeIi2LdCDZ9CjMZQ+dn0g8B0iu0VjBYc5kgNX1g X-Received: by 2002:a05:6358:ca6:b0:14f:d52:39cb with SMTP id o38-20020a0563580ca600b0014f0d5239cbmr2687029rwj.26.1697731034079; Thu, 19 Oct 2023 08:57:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697731034; cv=none; d=google.com; s=arc-20160816; b=lHCT/0w77ILDZ0YlIUwCfKtZhQW/I+yC+CiEkJs0Ve7CZUeWw8N+8QIc9qGPPfF5Rc zn4HOUp+D+jV5t5rYOZZS47AztrmZLt4tW4q/fzlwkT/J2+ralDU6kF2LuiaaGptvtx0 74TYcGge4TCeHdr4mMFYBmOZqZOBcBKiitn741dK/VII3YSjiJhTQYE1MP7Vrnf/qliQ MQxhijoIXmYa7M8m1MW27lLPzmUNRJMvaJJ3N88NyKCHCbwH1gSAABShZQk2h6xFhDXQ oOXyM+2oD25rKRgTH/0TlRjENCjftb/0u753ZtqKq019aG1++tIRN7J01VJ3mApq6fUX rxVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jbfnkUyxs+if9zkd1YMenEXUo5oRbUbKEe5mZ7tj8Tk=; fh=H5TEBUPv0rBG5RLveLK6EPbywB5R2NeABwKkIz/9wik=; b=AVIvyGobfQo21NeOOjUoERglfCYVx3EQXHE9ACZ4DziSr/9Eh0QOqCy660TSzqa0Pd e+x6/c0nerQF9rmDHBQ+7osHl6UPvxKlzuwU2u7LCFT6cmjiyfwETq5syryDh/72GKya AhWBo3HwN0sK1yX+4U5n96lYI0LvDwfCiBYtXLpwvr98a9MMxgkekPozrHtIRYikOrZ/ UixLi/oFdvjliETrA/GJtqKl6M8z1yRM7KHhSh/aZh81XVTTjuvKnQvknpw0yKty6b8s EIpCYtRvH5BAZUZn11lgBSvyNW5FZhyXooNRUkPtF/F7q3gNauW4DH9yfnREgpThUmH0 0dAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Q/+n6Luz"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id e186-20020a6369c3000000b00578e5228c76si4624909pgc.505.2023.10.19.08.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 08:57:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Q/+n6Luz"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id DE36681ABAF6; Thu, 19 Oct 2023 08:57:11 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235453AbjJSP5I (ORCPT + 99 others); Thu, 19 Oct 2023 11:57:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235449AbjJSP5F (ORCPT ); Thu, 19 Oct 2023 11:57:05 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A46893 for ; Thu, 19 Oct 2023 08:57:04 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E20AC433C7; Thu, 19 Oct 2023 15:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697731024; bh=oZW9El7VXfMlH/VjYu7huedpwgs6ijSWuN8AI0F6kg0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q/+n6Luz9GwG6HQrsfZY+Lv6ogNKsddYTTdWLU2j9GiVS743nVlWPtpjikCg0F+Pl 2CA/Cx1ibkoVk2m4Hvge3iZC1nA3+ZHIA5k7QkrYa78naY/yOqF+csPtT/u3rGhe2l RnYhAos6uCfn91ovO43W9/pkXO76q0erViErA9JzuZOaMCn0TWufk6YTWYq+gsl/H6 L6K1ADdf15xLlNbMt0NlUCDvjCMQG7NMZ2Wks+9ytza30c1YLyCbd9m503IelAyp5e 7DdSjiTWireDqXJBbfCQhvOD6CtUr65KE1Tn6nRJGiMdX+b/HEE+2bTmTJpuwM0Tl0 o4dGtvCpZ8EkA== Date: Thu, 19 Oct 2023 17:56:55 +0200 From: Simon Horman To: Przemek Kitszel Cc: Jiri Pirko , netdev@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shannon Nelson , Michael Chan , Cai Huoqing , George Cherian , Danielle Ratson , Moshe Shemesh , Saeed Mahameed , Ariel Elior , Manish Chopra , Igor Russkikh , Coiby Xu , Brett Creeley , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Ido Schimmel , Petr Machata , Eran Ben Elisha , Aya Levin , Leon Romanovsky , linux-kernel@vger.kernel.org, Benjamin Poirier , Jesse Brandeburg , Jiri Pirko Subject: Re: [PATCH net-next v3 04/11] bnxt_en: devlink health: use retained error fmsg API Message-ID: <20231019155655.GM2100445@kernel.org> References: <20231018202647.44769-1-przemyslaw.kitszel@intel.com> <20231018202647.44769-5-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018202647.44769-5-przemyslaw.kitszel@intel.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 19 Oct 2023 08:57:12 -0700 (PDT) On Wed, Oct 18, 2023 at 10:26:40PM +0200, Przemek Kitszel wrote: > Drop unneeded error checking. > > devlink_fmsg_*() family of functions is now retaining errors, > so there is no need to check for them after each call. > > Reviewed-by: Jesse Brandeburg > Reviewed-by: Jiri Pirko > Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman