Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp451765rdb; Thu, 19 Oct 2023 08:57:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH42Wgeh1/oQdtijcBGN6ivHRYw++dZm0v6iPkifWR8F58aYUIdpJv+4rJ12t+vdWZ/Ndu6 X-Received: by 2002:a05:6a21:3281:b0:143:f4dd:dfae with SMTP id yt1-20020a056a21328100b00143f4dddfaemr2909787pzb.43.1697731054344; Thu, 19 Oct 2023 08:57:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697731054; cv=none; d=google.com; s=arc-20160816; b=xWCJH06PaTgsXR/MP9AeDwMsDSl8A47u5+hla15ScCWhP8FhdyZ8VZmen8M4hqQBV4 N4MIW4/0Qt++ME9OC0gld/prcM5oVSW8zLC/yyJN1jIWvDq6LGhlfOIFBtgBNGXe/PBD suqi6mWZJRp+Zv91ZDIMSwJD42r/2mF+A0fGHV0nbJo8w0Z66FT/v3mGI+CWb1kpHsLj +2ts2WBSwZ/N8DJ3P+fY9hO2F5kYF36JwFcQlTrwHos9bxMeypIyQlO+LLqzc5DTdF2n EVnm6RhGyzOxTJyFMvqsClmXkVJxSjYwAf3pceKvV3nR270+z7YwUtUJOEVNaQNHXSy7 WQcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=R/y9gdDQo8+PNz8huqnCgSWdZZJO/YHWPQscTCSoIys=; fh=H5TEBUPv0rBG5RLveLK6EPbywB5R2NeABwKkIz/9wik=; b=JE7vFy5iFWg3hCFSE325nZ6W5brbFlcmW88wz+o8Q/YsDICKTs5HvXs5ha/feToSeZ pC+GcHSQZGaCp2/WSjbVgNTG7a98vQP5cPb2/aWOrekWKLeZkyBQNBU4fU/jj7dNw/+t 0zjZdBYB9fkl8Zoqzun3btzADc0nYeqv9hF8Suph2+je2BCLK0aqMgxPVXXbBs0e+NlH jw4wO/clCKhWXXO+CFY6dWC56CUrk5hg/houchUWtKKKNrIGCwFOST5Bi5ytJpyj4R2w BPLwT0UsQ7kMDcnvQ3iNH/JTT+rIgtT5zKUg+vhc/aa6BoTNn28HsnUyZQTMBeOQAMI9 29jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WYRwDhwh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id c6-20020a633506000000b0059c0f9ef964si4875095pga.635.2023.10.19.08.57.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 08:57:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WYRwDhwh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0A26F822D131; Thu, 19 Oct 2023 08:57:33 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346405AbjJSP53 (ORCPT + 99 others); Thu, 19 Oct 2023 11:57:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346427AbjJSP5Z (ORCPT ); Thu, 19 Oct 2023 11:57:25 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7733124 for ; Thu, 19 Oct 2023 08:57:23 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1E9CC433C8; Thu, 19 Oct 2023 15:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697731043; bh=IyvcanNAQWnGPKBbEt2/asf2ufwI0jEwMEXgnN1yo2Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WYRwDhwhqQwOsSO42kQ0SnAT5OGpQdlL+jYpQ/sz7hingpNSMF2WA9WmMCNobxTRV dEjV1nmozpw+AK6sIf8cyGpOLrN93pce7iNDj5LeBy7Ys3I6bumvRbMbZye4Z27aNU ZxKFsoIZcmoktWlRgbmKz5n8XN0NT3uzCUTufZfNgyQENBsEnH7SdEOziTA5CI4QWX CSMMglJALjZO1Lkp7mmEnuHUoPZvLMLQpw/Q1xg3SA2F0D2LdFg9nCcUP70N9P3q4a H8j6cqcYN/bzPu2LL3iuJGrL+uSdbOqp0J4q/oF8MdDY5KxNdS6W7yyYeEMf88mP4h nR9YGoumrtLag== Date: Thu, 19 Oct 2023 17:57:15 +0200 From: Simon Horman To: Przemek Kitszel Cc: Jiri Pirko , netdev@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shannon Nelson , Michael Chan , Cai Huoqing , George Cherian , Danielle Ratson , Moshe Shemesh , Saeed Mahameed , Ariel Elior , Manish Chopra , Igor Russkikh , Coiby Xu , Brett Creeley , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Ido Schimmel , Petr Machata , Eran Ben Elisha , Aya Levin , Leon Romanovsky , linux-kernel@vger.kernel.org, Benjamin Poirier , Jesse Brandeburg , Jiri Pirko Subject: Re: [PATCH net-next v3 05/11] hinic: devlink health: use retained error fmsg API Message-ID: <20231019155715.GN2100445@kernel.org> References: <20231018202647.44769-1-przemyslaw.kitszel@intel.com> <20231018202647.44769-6-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018202647.44769-6-przemyslaw.kitszel@intel.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 19 Oct 2023 08:57:33 -0700 (PDT) On Wed, Oct 18, 2023 at 10:26:41PM +0200, Przemek Kitszel wrote: > Drop unneeded error checking. > > devlink_fmsg_*() family of functions is now retaining errors, > so there is no need to check for them after each call. > > Reviewed-by: Jesse Brandeburg > Reviewed-by: Jiri Pirko > Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman