Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp452020rdb; Thu, 19 Oct 2023 08:58:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhferlw519brcjaMW0IM4B92PGxf2jmFbpP0Tnshnt6YZTLAlHSQKeBhEXiXYfoSddpG+9 X-Received: by 2002:a17:90a:1918:b0:27d:2371:9f74 with SMTP id 24-20020a17090a191800b0027d23719f74mr2594184pjg.0.1697731080925; Thu, 19 Oct 2023 08:58:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697731080; cv=none; d=google.com; s=arc-20160816; b=v0tX+XWbo6xXOXb4HjaCvX4YtY57eshWNlxUsKE4ArDFJKNpS+Pusnan2Sv6m8vHEE NZ5Opy89svwtMXzA2g6y8gC2YoEpOWXNVZMRTaqX328+QYWTVtr5ym3L1hms19M2iRIT 0Iw03jbH6lNNBXhw0NcdW/g+xt0e0SZ6kCc97ajAeWL4p2ywskVBHZ2YFcWFWJ09/uiz AzaJzoCV5ZtcfHuoYSPG9+w4a+Cg7dVfbboW5U2KVNQWrncjI7E3KJunX2cF9N5iNMDC kqEIvOnxHgfGiwe4e/DwEVceqUF9Qt4mct4KuPk2o6bLImqt9Af6ZfZvoIrucnb4lny1 Gz1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bNoh9+jNrIE2CKbdH1T+L6l7ZGi3/S53DJRN/zlY2sE=; fh=H5TEBUPv0rBG5RLveLK6EPbywB5R2NeABwKkIz/9wik=; b=vQFWhtGrM2mVi9UFGbU0ZBcmFLEizP8+NcIaVKYzgt2C0xEG1P/UrZcdw0MoKrSGVr yFTbSFGsQc8DcZaIEyvIkgrKiY7SeaWv9JippxHgqnTUgaRYcth+sNgIG4QinLj4aA5I lTFq7cC9MFMGFh17xEPTrIpHgDNooYGhrC6M+fcRsfui4d2ViPIvIE0VvHcLNR/V5ZCR 33vxoLWC7TbEDML+FiNDjQaPPz/eOKzpvIYfrdQcbZjh+ZX3qNhhnFr9dGxOBPRp6/Kr a3W+1RkqwjgtEwpCGMp7R6CA2ko5NZHJVQLi5+Ar2CnO305w8cHyE3cjBtN4fW0nqT3O MA9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=R7amKmKh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id z1-20020a17090ab10100b0027ce6cd3144si2373262pjq.126.2023.10.19.08.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 08:58:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=R7amKmKh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 59ACE81ADB4C; Thu, 19 Oct 2023 08:57:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346466AbjJSP5u (ORCPT + 99 others); Thu, 19 Oct 2023 11:57:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346461AbjJSP5p (ORCPT ); Thu, 19 Oct 2023 11:57:45 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 371BA19F for ; Thu, 19 Oct 2023 08:57:44 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C10B0C433C8; Thu, 19 Oct 2023 15:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697731063; bh=aV4zjqdTfT5hQ+Z2OY2yVVJ9007OGiHOsvnzeD0O/ds=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R7amKmKhwgcduuPk4cZHH2A/v5VghUZCV1R05tamsUU4eMloSv38OcUTUeQcP7two AT9p3bjWlWF9hjZOYORos4KTOdS1mGajy0CdSBmlrAFlVggnJmH/HRgCP2SAO80TvQ dtgSi27oCjKwrSotT8ejuUHuhN+fJnYQnmh4cvqsQwei5gyOHCihrnCOGJemI9eog4 +S0Fqv4wXJpgLQvJtQjsjdYQ7gbalJff2P96sUn6pGX8VJzLbVi7N6jVLeQYZZ1iCz TD4mWA+Sbl8e3qh3S7iur6g5ugg3AydfpeC1l3UtiTZliE+TFNnfiK9c/9nXpz9+It QfcmeyoL6PKKw== Date: Thu, 19 Oct 2023 17:57:35 +0200 From: Simon Horman To: Przemek Kitszel Cc: Jiri Pirko , netdev@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shannon Nelson , Michael Chan , Cai Huoqing , George Cherian , Danielle Ratson , Moshe Shemesh , Saeed Mahameed , Ariel Elior , Manish Chopra , Igor Russkikh , Coiby Xu , Brett Creeley , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Ido Schimmel , Petr Machata , Eran Ben Elisha , Aya Levin , Leon Romanovsky , linux-kernel@vger.kernel.org, Benjamin Poirier , Jesse Brandeburg , Jiri Pirko Subject: Re: [PATCH net-next v3 06/11] octeontx2-af: devlink health: use retained error fmsg API Message-ID: <20231019155735.GO2100445@kernel.org> References: <20231018202647.44769-1-przemyslaw.kitszel@intel.com> <20231018202647.44769-7-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018202647.44769-7-przemyslaw.kitszel@intel.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 19 Oct 2023 08:57:58 -0700 (PDT) On Wed, Oct 18, 2023 at 10:26:42PM +0200, Przemek Kitszel wrote: > Drop unneeded error checking. > > devlink_fmsg_*() family of functions is now retaining errors, > so there is no need to check for them after each call. > > Reviewed-by: Jesse Brandeburg > Reviewed-by: Jiri Pirko > Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman