Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp452556rdb; Thu, 19 Oct 2023 08:58:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGKct7CKYXiZbe2OnNPpn1nBpN14H3ZZoqZBQOuILk+UUWUUe91oCeay1/x3Hm2/4DyyHg X-Received: by 2002:a62:798b:0:b0:690:1c1b:aefd with SMTP id u133-20020a62798b000000b006901c1baefdmr2469201pfc.5.1697731135229; Thu, 19 Oct 2023 08:58:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697731135; cv=none; d=google.com; s=arc-20160816; b=N8kpDt1WZfICQ1NMOAZBtFII8xs4yqLqGV+zmQk/9LBjQiQ0lHlSsl7tUJfO3SWJOt TWSypktxMk0JXTld9RbThZQAkLW0gE3DwUzOgmJUxY1LgGUTBcYWuXp5HRqWjPAa7ROB 0J/WaCyvld1PTVGJKkq9iUSZW5Mc4NDSlZmWh08XEQQq60usWFT4IsEPpWKeBkLlE19f E3tZoA2RIC1gBcVKraxrRXG889udCoUYdYOdBrSVK25EgLjUmS5E03AFYuL+Z+NsAqyE gwTMJPNrufIbh5CrxTOsNglySnZLyorlmbmYfrDUSbY7oj3+0aScadHDa+W6ov8J5rRI sROg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZfiaWus4iEkVqDW1GvOP0ENec51tbloO0L9IE/zfJGk=; fh=UDufT8NXtYWO7ObT2rCjisxNem3Iq77RtnQzklj05Gs=; b=eGwbHr1Uv0PCmpmHsf08BzY7SQ1ZpRM64dkKwEwU/dydVNgwN8u0TZIv+Ph47k6jgk J9Nn5YISKBDRgDfprJCXtU6vgrvFJdSPh2BeWelDH5BEcbuKxRYPdfwB5BctMwyD8Lpr rR5O8Yrm0ukNfuuA3ZTM5kTndqLAbeJK3J+HOmdOLl3whRnHpcKbsyxlAhM2xTcvqSaV Ct2+VhGlrESMhngyuO7hCIHqcgQByl1ITz3usuz/h0vifDMf3MIG60tFhsVMXiRTVayv hCsmxqELI7LC/zf2eZsvUbsjodpd+LA1hMfByEH4oYeqZ6/UbA/arIILCBXR9RDDvNQZ HvPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mir1vfOg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id by35-20020a056a0205a300b00578d0d070f7si5807996pgb.659.2023.10.19.08.58.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 08:58:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mir1vfOg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 6FD2D81C46E1; Thu, 19 Oct 2023 08:58:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346478AbjJSP6g (ORCPT + 99 others); Thu, 19 Oct 2023 11:58:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346470AbjJSP6b (ORCPT ); Thu, 19 Oct 2023 11:58:31 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77193132 for ; Thu, 19 Oct 2023 08:58:29 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C4B9C433C7; Thu, 19 Oct 2023 15:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697731109; bh=bMzvQMdR1FFY3JOsuLWSMqDn7XLN36i9gNGyqjkvK48=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mir1vfOgTzR55V1WKCUVIHJI7ZWoTaZ55a3JrJF3w4FhIF0QrWAwtJES8Nz/HE5q2 6QTER8wUwQcQnEwJnIMflv9be0dc1uT89bPb7r/B0h700Mtgee8aUKMx37pckn71F4 Ob5xXWcjqbQiOYbyxLu4otbWdZ09byM0Tp/cXcgUuVgCVhR7tclaKdcSVgOqdnIi0O KAfm9Cez500PBXmYpEl8H79ik1RvRTaQrXsbBcNRUi/QVz5hOIkKYYjN7C/H1E9N/z hNZk2Tb2W68H1iF10VcdofyZm7Tlo7Y2iLHporo9rthSPjhf5DwHU/Sbd6gyVhhtaX 4FmQh2nec1jQw== Date: Thu, 19 Oct 2023 17:58:21 +0200 From: Simon Horman To: Przemek Kitszel Cc: Jiri Pirko , netdev@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shannon Nelson , Michael Chan , Cai Huoqing , George Cherian , Danielle Ratson , Moshe Shemesh , Saeed Mahameed , Ariel Elior , Manish Chopra , Igor Russkikh , Coiby Xu , Brett Creeley , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Ido Schimmel , Petr Machata , Eran Ben Elisha , Aya Levin , Leon Romanovsky , linux-kernel@vger.kernel.org, Benjamin Poirier , Jiri Pirko Subject: Re: [PATCH net-next v3 10/11] staging: qlge: devlink health: use retained error fmsg API Message-ID: <20231019155821.GQ2100445@kernel.org> References: <20231018202647.44769-1-przemyslaw.kitszel@intel.com> <20231018202647.44769-11-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018202647.44769-11-przemyslaw.kitszel@intel.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 19 Oct 2023 08:58:52 -0700 (PDT) On Wed, Oct 18, 2023 at 10:26:46PM +0200, Przemek Kitszel wrote: > Drop unneeded error checking. > > devlink_fmsg_*() family of functions is now retaining errors, > so there is no need to check for them after each call. > > Reviewed-by: Jiri Pirko > Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman