Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp452624rdb; Thu, 19 Oct 2023 08:59:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7lbrfcNqMCeBss4zY5ji3yRCTElr5Tut7xbQ7Aq4nLEi/kactcerXzxz6M0mWUf+tG+RX X-Received: by 2002:a05:6870:3923:b0:1d4:d5a8:3d1a with SMTP id b35-20020a056870392300b001d4d5a83d1amr3010147oap.30.1697731144344; Thu, 19 Oct 2023 08:59:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697731144; cv=none; d=google.com; s=arc-20160816; b=IST6G55Eok/iQLRqWrYFc+iRLdXYDs23oHUHFiPoUCb98/cLSDIyQc1Tt2ex+chcIc TVqBs7Pj9u+fGFuAdVRn2adupDuQqCpWfQKfBY3hr+CfIoNvFVncbOKFPK1MssqtGIqf GyEtWC9ef1cvAdEBIp8QthawYmohVmojHYyghOzbVO+ek9kr0ZaNcCguwA+4AUcqdvZ2 LBjazzxKyfYb1Y8p96MvencjFLG81gGMoVCt2mt2+zBwjhPDcjZ4i4niPBdhsk5N/843 ccauT5keUjhZuC5C/Z33ZCQfLempheTvEHUa5DcoyZhIprsLPRI+fRj7DmJXUmoUtgMx jXPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Sqe3YdS4wubesIC0u20ixFEz+wyO7uepupzpYjuNCyM=; fh=UDufT8NXtYWO7ObT2rCjisxNem3Iq77RtnQzklj05Gs=; b=VaS8aSCijyNay0SJaQiZNSg9DcdbSF5PpFpBiQAfB0u/RY2AxrCbtJQOyaPWaKmbLU AQWcTEpXurqXW9mQN/jAWwbeJfC2O4yKTYhIwPSE/0d19KOipKC/u27kugRzQ+SFKLnt bGOKI9F3Tj8ITYp7NlLRg84zkl2/LXxdmsbjrURJdlMjzO+73oJuw4QpEwcJ1voP9Fia jzxHknRAs3Bf9JsDCW5YfftRHScOaMqnXw5C5OBiuJWC0gLWE1QYpnmbXIrApj0Muww7 Qc3T+BgrgpLJ4uR1eEUBliga27wMuOOz1trNsVuhxzmiPswStW+DvTAW8DdAP6cFjC8w CEfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pIMEjzLZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id a21-20020a637055000000b00578ca217740si3109635pgn.711.2023.10.19.08.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 08:59:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pIMEjzLZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 30F188332542; Thu, 19 Oct 2023 08:59:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346474AbjJSP6w (ORCPT + 99 others); Thu, 19 Oct 2023 11:58:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346400AbjJSP6u (ORCPT ); Thu, 19 Oct 2023 11:58:50 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12BCD18D for ; Thu, 19 Oct 2023 08:58:48 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C714C433C8; Thu, 19 Oct 2023 15:58:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697731127; bh=RED0CJL+hPkFLtbUoM2J+IsjZHHMt2828xR1we1htEY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pIMEjzLZjLgM4lkh7HpfhoilrwnyBw22Puv87akd6/dppeG0IEdpzWjwc67wO7McM JDmcI9ppg6q9rqWeevB2HvKKEhyzwnnTzCHZumeUorJ6eOcY/zDBM9Ec9ncRTxvEBK A0lw+i5g2OTipG0ll+zC8X/kpoJ8cGufCU+VEp7d0CGFA0/6aLZgMI21SPSdzGnFPo v4RfSKQW2G/tK16nPyHl0l6IpFT0uwo6Sx3tYSGKrpTuB0zMxNevY5Xq1xrRFYdB8i Cg82onWRPfY/xMRf+Xbq8nqoYBkt2PGbhroLd39EQ0GKYkN1IwW4r9Syrt/TCpYBwB aOVgZHJM2uo1g== Date: Thu, 19 Oct 2023 17:58:39 +0200 From: Simon Horman To: Przemek Kitszel Cc: Jiri Pirko , netdev@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shannon Nelson , Michael Chan , Cai Huoqing , George Cherian , Danielle Ratson , Moshe Shemesh , Saeed Mahameed , Ariel Elior , Manish Chopra , Igor Russkikh , Coiby Xu , Brett Creeley , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Ido Schimmel , Petr Machata , Eran Ben Elisha , Aya Levin , Leon Romanovsky , linux-kernel@vger.kernel.org, Benjamin Poirier , Jiri Pirko Subject: Re: [PATCH net-next v3 09/11] qed: devlink health: use retained error fmsg API Message-ID: <20231019155839.GR2100445@kernel.org> References: <20231018202647.44769-1-przemyslaw.kitszel@intel.com> <20231018202647.44769-10-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018202647.44769-10-przemyslaw.kitszel@intel.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 19 Oct 2023 08:59:02 -0700 (PDT) On Wed, Oct 18, 2023 at 10:26:45PM +0200, Przemek Kitszel wrote: > Drop unneeded error checking. > > devlink_fmsg_*() family of functions is now retaining errors, > so there is no need to check for them after each call. > > Reviewed-by: Jiri Pirko > Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman