Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp452749rdb; Thu, 19 Oct 2023 08:59:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEGHob9SoAbmsQxr8N/WWLj1p8OfDUYJfvZxpaQSmgSwCAP9DiB5wiNt8BhZG0hMpU0VBpx X-Received: by 2002:a05:6870:818f:b0:1e0:eb36:a7ed with SMTP id k15-20020a056870818f00b001e0eb36a7edmr3301114oae.29.1697731159775; Thu, 19 Oct 2023 08:59:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697731159; cv=none; d=google.com; s=arc-20160816; b=IKgLTzEN2jsU40xeJhHoA7JzIwIryZcYwfzFD1nGAMB1PvaINQVm4IlTyPLGE08pr9 ZYyc21lUdoMveAevCdR3tgUuoRr/Jq0Ynaox4EbFNJEqJHoby6r1baEl8xCdzkxS8BA6 wGANtCUNx9Ka9vw8DI0fsYT6IJOSZis9KhE1HxIxhwqYf1NxfUOoatzgwjKHA8fwBvpV D+VdUT6xgFb25L/nmedxl66UV/T3dMe11+nHoUm9qjjHHBEZDIQRlckmWJF/2t8rVvAQ iyFgsCVoVCuEsL3hvAfs/g641R8aLP7cmrdZ5yHlQLFcTjAKjFzb/GI3Fi9Te7ej/d+X /qQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mYZhVfiJdPzFfsEzoZERnw9LWWxEaNYaiOeNaT8xy0A=; fh=H5TEBUPv0rBG5RLveLK6EPbywB5R2NeABwKkIz/9wik=; b=BpHf7HMk+YbrpGBfmKp7qhy8qsVZLWcgp629UnFWH3mpujvwIMWh47R3WQHcn2Vr/p xK/LhKV8KA0r95srU7eZzWeRBB8oZLr2+F57syqbC80WsvXQbQGfJL/4P1kn7vCwdTZY x7lfLMIxKyxNJ22AsMBesaWFdNIlcJkCfC6SMJS38oksKyrl+mgVPgu7hllCZi0hl1Ei tTvqdHAZfVP7FAXkpzmXxk7JuFR2R1gOdniYO6q93Vcp8dIoSCO96+fR8vAyApfTl5cf pGCUibEHuTcoRXkVIZIbZaF6Fj3CM5Fs6CNjiX1LOinOzeaz3ApBTbEynWqegDflsU/K sf2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gB4mWxIT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id j8-20020a056a00174800b00690d25b1991si6705915pfc.41.2023.10.19.08.59.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 08:59:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gB4mWxIT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 40C9182A855B; Thu, 19 Oct 2023 08:59:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346510AbjJSP7M (ORCPT + 99 others); Thu, 19 Oct 2023 11:59:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346462AbjJSP7I (ORCPT ); Thu, 19 Oct 2023 11:59:08 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88F371A1 for ; Thu, 19 Oct 2023 08:59:07 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E909C433C7; Thu, 19 Oct 2023 15:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697731147; bh=i1omozby4EP2nJtt2vwivrLCaXUQEHO8dCe2Ki30RdE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gB4mWxITYCEoH4eeUe26dhMkqyiRASOc8CnzXBKadpF2jM4Jor++fIE8HeWVojDd8 UWuHv6j9VWNAvv9PS9ZMf3GFP8S6wNl3bpoc6hfxA1k8ZSQDg5H9B/JDHyeIiynCz4 Pqtgvba9TrvWlrVx7h3axoOXJItKoAW2GP6QaxuZJH7PZo1X/l24/kgtxgMFp00wK6 Ck6NvnMcRA0iBa0dNmK7dOmB6p74T3fAGtYhNtplqrA9SGxHJmTDgR6nWSlH2pU763 w1HQPz6OSGgxd90uSrvuf4nkTG9su647yEV9akQaAbBPI7k+6rLSrxPaxJNPMmaBWz G0bIjtmhHr9SQ== Date: Thu, 19 Oct 2023 17:58:58 +0200 From: Simon Horman To: Przemek Kitszel Cc: Jiri Pirko , netdev@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shannon Nelson , Michael Chan , Cai Huoqing , George Cherian , Danielle Ratson , Moshe Shemesh , Saeed Mahameed , Ariel Elior , Manish Chopra , Igor Russkikh , Coiby Xu , Brett Creeley , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Ido Schimmel , Petr Machata , Eran Ben Elisha , Aya Levin , Leon Romanovsky , linux-kernel@vger.kernel.org, Benjamin Poirier , Jesse Brandeburg , Jiri Pirko Subject: Re: [PATCH net-next v3 08/11] net/mlx5: devlink health: use retained error fmsg API Message-ID: <20231019155858.GS2100445@kernel.org> References: <20231018202647.44769-1-przemyslaw.kitszel@intel.com> <20231018202647.44769-9-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018202647.44769-9-przemyslaw.kitszel@intel.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 19 Oct 2023 08:59:17 -0700 (PDT) On Wed, Oct 18, 2023 at 10:26:44PM +0200, Przemek Kitszel wrote: > Drop unneeded error checking. > > devlink_fmsg_*() family of functions is now retaining errors, > so there is no need to check for them after each call. > > Reviewed-by: Jesse Brandeburg > Reviewed-by: Jiri Pirko > Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman