Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
MIME-Version: 1.0
References: <ZST/WggW4hSVs9d4@gmail.com> <202310101636345668937@zte.com.cn>
In-Reply-To: <202310101636345668937@zte.com.cn>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Thu, 19 Oct 2023 09:01:17 -0700
Message-ID: <CAJuCfpFwAexdhHubUjrDxs9er7npX6JtX6B78Vkj_pZ+B-1uAw@mail.gmail.com>
Subject: Re: [PATCH linux-next v3 1/4] sched/psi: Change update_triggers() to
 a 'void' function
To:     yang.yang29@zte.com.cn
Cc:     mingo@kernel.org, peterz@infradead.org, hannes@cmpxchg.org,
        mingo@redhat.com, linux-kernel@vger.kernel.org,
        juri.lelli@redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Oct 10, 2023 at 1:36=E2=80=AFAM <yang.yang29@zte.com.cn> wrote:
>
> From: Yang Yang <yang.yang29@zte.com.cn>
>
> Update_triggers() always returns now + group->rtpoll_min_period, and the
> return value is only used by psi_rtpoll_work(), so change update_triggers=
()
> to a void function, let group->rtpoll_next_update =3D now +
> group->rtpoll_min_period directly.
>
> This will avoid unnecessary function return value passing & simplifies
> the function.
>
> Suggested-by: Suren Baghdasaryan <surenb@google.com>
> Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>

Sorry for the delay, I was traveling and just got back. I think Ingo
already applied this patch but FWIW

Acked-by: Suren Baghdasaryan <surenb@google.com>

> ---
>  kernel/sched/psi.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 1d0f634725a6..be853f227e40 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -434,7 +434,7 @@ static u64 window_update(struct psi_window *win, u64 =
now, u64 value)
>         return growth;
>  }
>
> -static u64 update_triggers(struct psi_group *group, u64 now, bool *updat=
e_total,
> +static void update_triggers(struct psi_group *group, u64 now, bool *upda=
te_total,
>                                                    enum psi_aggregators a=
ggregator)
>  {
>         struct psi_trigger *t;
> @@ -503,8 +503,6 @@ static u64 update_triggers(struct psi_group *group, u=
64 now, bool *update_total,
>                 /* Reset threshold breach flag once event got generated *=
/
>                 t->pending_event =3D false;
>         }
> -
> -       return now + group->rtpoll_min_period;
>  }
>
>  static u64 update_averages(struct psi_group *group, u64 now)
> @@ -706,7 +704,8 @@ static void psi_rtpoll_work(struct psi_group *group)
>         }
>
>         if (now >=3D group->rtpoll_next_update) {
> -               group->rtpoll_next_update =3D update_triggers(group, now,=
 &update_total, PSI_POLL);
> +               update_triggers(group, now, &update_total, PSI_POLL);
> +               group->rtpoll_next_update =3D now + group->rtpoll_min_per=
iod;
>                 if (update_total)
>                         memcpy(group->rtpoll_total, group->total[PSI_POLL=
],
>                                    sizeof(group->rtpoll_total));
> --
> 2.25.1