Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Thu, 19 Oct 2023 13:01:45 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Leon Romanovsky <leonro@nvidia.com>,
        Jiri Pirko <jiri@nvidia.com>, linux-kernel@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: mlx5 ConnectX diagnostic misc driver
Message-ID: <20231019160145.GS3952@nvidia.com>
References: <20231019082451.785aa123@kernel.org>
 <2023101923-tried-provable-72e7@gregkh>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2023101923-tried-provable-72e7@gregkh>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pThtCiUzZEHaJ5b3mivmJ1zK8UJn8ueEGvPU3vg9MzTBYHSbzaouSOinlbuZ?=
 =?us-ascii?Q?Tc3W2gIMjDOzJGHW4blRKFxp8difY/GTiefzvnuERhr8WNQ3eVyQolWhAY3R?=
 =?us-ascii?Q?QwOHTbbiPYKcEqKmHIcf0p2W2VmKVMOVVO3C06p/PGjgvuf/E+nu9+DmxV4Q?=
 =?us-ascii?Q?5Tyfj09MoqlFZcwYTFgmoixiMLDtZUj0SeHazIBcQ77TLwdVJlfxoh68CS48?=
 =?us-ascii?Q?GCPbgTDRNmvJN/ZcVVTWI2E8wxgZn+cGOCh90IHy5w89tlcPb9oZ0k3Hj6tQ?=
 =?us-ascii?Q?YrEPqPummGFxYAfdastDQyKGy/0hriMwtovS0Nl3rluttc+60mF+LkRI3gNO?=
 =?us-ascii?Q?LDWF9ZomQz4QMJeQTUwdrz9vDs0KT//wtrM62SkoktX39bV+uCZRf2vPh5bJ?=
 =?us-ascii?Q?SUD67MWGeoKKBGurOymf2cYv9AU7yjJl8oBpf2WRObyLemKIxZSVE+G3i2bD?=
 =?us-ascii?Q?hY6ZGwhJWQE0/YIG886vFnOz3RaLOPKzbGsB4DOxOg0fpLtrqSSIs943xw5L?=
 =?us-ascii?Q?2oR54/sReTVGDPi4zU8oczNDWJzTQePDX1CKixCRkq4z85VEBa8SDJh3wd7V?=
 =?us-ascii?Q?cvFItjeS3UNlWo5jrn2dBk1I35l88r7VNqUWhW23sMVBrscnbG9PH9ttJ3//?=
 =?us-ascii?Q?Lo6y4XKWPKGq3s0TOUmeooAJ7GPI8OJVgVWtjP8vrYgKGwLl5UXoCwJbrZvl?=
 =?us-ascii?Q?SaEv68K4IicBlrxHTW70iZAknTRDvhCfQFc2FlicCQCfPubANRlcq1M7rKBm?=
 =?us-ascii?Q?XnOBnOUrb683L32aG1zgZ66jmIey0cntsKzeMDYL9Lcsvw+m1q0MzL7KbwTD?=
 =?us-ascii?Q?ZqW3bIFjDQtGb1OSohGw50vCKS8dAIFjLrNJKwdqk0x+06nQhFFMrbb14m2S?=
 =?us-ascii?Q?E5j57IofgN1Lyz8HkZRww24FA0wxhtOVtRCPXBlg7VHtQ561HcIKxrRFGiOh?=
 =?us-ascii?Q?1m/8Vc2QS5gKSpf5eYT1G9a4L8wmhJ92Yu54WYOOGUNOQbMBousrQcmrjlqF?=
 =?us-ascii?Q?YH6/CRAu6BuORUY7JLb9bJ0XnCOp7ntn4+hDwLToKJZRfBy/DcoDD/fiAJVe?=
 =?us-ascii?Q?qoYY7Dkcx/6cpLlTY2g+sT/rY/TUKbQ7jic49mF8K5ZyCDYPJ07rcQfSqFxp?=
 =?us-ascii?Q?YF0QLgTJFJpdfnp0nzBsqFHxrbGsfXizDD6YJQbHIPlONRKE6ELMH2tuPCTz?=
 =?us-ascii?Q?xUSP+SG3Tx16UbNrp7adoR2vhS5SpvKoPDbAI0IFz95IPBNcWsMAWO9LYU+y?=
 =?us-ascii?Q?ul+p47l9BmZ/d1Bg5NWUUlKu5nbTMa1oCkqDYvaAObewDauTUSl4kjHzs3Px?=
 =?us-ascii?Q?Tj0TxDBQoYDmBfCVXbCXl38WIa5txdJwP/y2rk6UglzHVQ/gGfQG85LKHKrG?=
 =?us-ascii?Q?pKCLSTT/br7EXctVdCdqcXNLHQHeWk9Pu3qWWBx00hS2/d77yZs0yuoh5Y8W?=
 =?us-ascii?Q?bqe+HwhE9iGIMWRgUupCabC7lz11LrSrWjgyWHYyjKYrc1fde/tUZkg/4FqP?=
 =?us-ascii?Q?bqOeoppBpnkGa6AGNZ+MCF0Roov9t4elB9fdoSMIEtAV/IYaKXn2XPCfGHCi?=
 =?us-ascii?Q?hQxITeqQ+h+wO7KQWKijZqMmwlzLJjn5Eh9kQZOE?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f993f39b-c0b4-47d4-cce2-08dbd0bcb375
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 16:01:48.8259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z8gMEmKw9SjveG9SQZkabh4i6ihK/wmBeV7iz+TCCNdYkSyiizrCM+bp+0BJRZdN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4080
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 19 Oct 2023 09:02:03 -0700 (PDT)

On Thu, Oct 19, 2023 at 05:36:04PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Oct 19, 2023 at 08:24:51AM -0700, Jakub Kicinski wrote:
> > > The ConnectX HW family supported by the mlx5 drivers uses an architecture
> > > where a FW component executes "mailbox RPCs" issued by the driver to make
> > > changes to the device. This results in a complex debugging environment
> > > where the FW component has information and complex low level state that
> > > needs to be accessed to userspace for debugging purposes.
> > 
> > You're being very dishonest towards Greg by not telling him that this
> > is a networking device, and the networking maintainers explicitly nacked
> > this backdoor. 

Do you have a lore link?

> Well, in this case, no way in hell will I be taking this.  If this is a
> networking device, it needs to go through the normal networking driver
> review process, thanks for the heads up.

It is not just a networking device. mlx5 is a giant and complex
multi-subsystem piece of hardware.

This is shared debugging and configuration interface to the device FW
that interacts across all of the different subsystems the driver
supports.

Looking at Saeed's tool capability on his github it is significantly,
but not exclusively supporting RDMA (ie drivers/infiniband), with some
features for the mlx5 VFIO drivers, mlx5 VDPA and a bunch of lowlevel
PCI stuff too.

Calling it a "networking device" in the sense of "it is owned only be
netdev" is not accurate.

We think misc is an appropriate place to put something like this,
there are many other misc drivers that are sort of similar APIs to
access embedded FW to manage and debug it.

Jason