Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp455422rdb; Thu, 19 Oct 2023 09:02:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHSxGJvg+eLj4HlwqefTPfVfBHHYEmlDkcLWxJcQDN1/KbQx/in6CzvwB82wSljFk+4O2xL X-Received: by 2002:a05:6a21:18e:b0:159:cf93:9b50 with SMTP id le14-20020a056a21018e00b00159cf939b50mr3251112pzb.46.1697731338581; Thu, 19 Oct 2023 09:02:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697731338; cv=none; d=google.com; s=arc-20160816; b=1GVCixVo3z1V8uEwvfBmzw12yl4dZmeXJxgBkee3vGT+YZMY6jdpNs7YS+0uQn4Q83 JEMbRWiGi+rHt3km2W6I38sCJIWARcREjbvKmp+zi7QCpm8Y9sJjknFSPxlYz0YvpFCa 3JdjH1xkBndDMK5Ar37xwjOcyo1QDh4Sz5Qgj4GDld7D0sY0XXJ/jNaQxl99kboMVNmV NcWmyeExkRnw9ia8oGC4bklLjoAcGA0jUUfJcrlc842Srz/9WOi6KpDhQMAdLm7l3CcT 1Tiro+upGOOeIKbw1FuAuJ4Wn+zDte/mtpztPTsFsPJgixlpI8TBLev9rp8xkPIdCkkV pOYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=QAEbVxck7NIMOPFoyufkI7+poSNQZD0kt5lDnU1GmDY=; fh=M27MsQCmrWvIi82GjoEcR7ViSaJtC03Is4k28r1Y/ls=; b=hbHrTHGmYR3DhApb7p5C8UC+S2BslkN2AkDN8+ak/c0E6M6M06vjKaug4IiRv1w4Ru XWkQC5dUUq7sJYALWxFvX58yte0SQoz1tCq+uvvOs+2Pw52/z2F600Ha7bbfsMxzABNk s5+uyHyRRAwQvRnVk5N5iDnRsrPyfyQR6Ke6nNKzSn35mlguM72k/VSXgxk0VtivTd8Z rSEQLhWWKGdT+OBR9KifOCMKShuE73XWrChH6W1t+FH4PfgbJh11wldKzwIy5g499Lb+ wJnO29JhPwWybte4HpBf72v3zMTdgqtwyW3u/g515L5sW5AQADz37Smm7EZuycS6q/GU qloA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=wWcQIDL3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id y12-20020a056a00190c00b00690f74dd2ccsi7061464pfi.69.2023.10.19.09.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 09:02:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=wWcQIDL3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 7E24083BB594; Thu, 19 Oct 2023 09:02:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346491AbjJSQCF (ORCPT + 99 others); Thu, 19 Oct 2023 12:02:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346499AbjJSQCC (ORCPT ); Thu, 19 Oct 2023 12:02:02 -0400 Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFD50138 for ; Thu, 19 Oct 2023 09:01:56 -0700 (PDT) Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-d9a4c0d89f7so9454533276.1 for ; Thu, 19 Oct 2023 09:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697731316; x=1698336116; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QAEbVxck7NIMOPFoyufkI7+poSNQZD0kt5lDnU1GmDY=; b=wWcQIDL39rUsqDiUSrhQesgnzs++1sOmT2AoGZrzDEHpC54Xf4PF5W+6I54F8wl48j vSBv6uBvlD8ph/3X/5lBMzExPF1JTS6nrfITdCQVZMyhTt3j/e/yvchiZCBj6vdyaDPh XYejc/h1rMFyc//XMgw9foepsVhh4rqBS0xBYFcRpBxfpvOMUMqxtireJdDFfdwPCY/Z MoOFXj4BBDkybxTC6R56DbyCACXUSEyXfC7wV2tT7ONbfS9mlowZgk3PRz4a42s4Adh7 5SP/xuJ3oQmuiqU2qzrRpWB675P9oMtGRiv+HsZK83dsq76fWpRFoyJDLXSe8EKvpMQZ 5f4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697731316; x=1698336116; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QAEbVxck7NIMOPFoyufkI7+poSNQZD0kt5lDnU1GmDY=; b=d2a/SN5gzgMkCeIR0gqHk6uoNVuyGK53F61WaWdZi8qB2GZka99T7EVNJ7eCPkSF1X tMeVkCuEdpNtUhMplY4KWXGRPJPVH6RFpAEKNb92RGzeZVSU3kE67/3tX5016Po591Sc rQwcMnI0LHwNYSL+2iVdgM4ne5bynR7t4/8wzyIUbxZiboNpZfjAXA9iaJ9J2Xh+HJbj W02qh8X/iLtGiw/DXqOcckB4CUq54fGd1X0QRn3y/15oZwVyDlLNhVbntan5LE++bdzW wvqV2jYzCJ8gcarIe2HZ+esOiATiI6rbFlw+8WGwQFht0y+hB6uCb7UdBFwkm35UcHSp CNnA== X-Gm-Message-State: AOJu0YxJHUoH8eClGX9SNnTQlkFrCcqgf1nlXwZjeG7E3admhYCQeK+O 5/Aunz46kHcQ4mEKI08WC6xYE6qSnfZi8D9UPklxqg== X-Received: by 2002:a05:6902:c7:b0:d9a:e6d6:42f8 with SMTP id i7-20020a05690200c700b00d9ae6d642f8mr2773004ybs.29.1697731315891; Thu, 19 Oct 2023 09:01:55 -0700 (PDT) MIME-Version: 1.0 References: <20231009025726.5982-1-link@vivo.com> In-Reply-To: From: "T.J. Mercier" Date: Thu, 19 Oct 2023 09:01:43 -0700 Message-ID: Subject: Re: [PATCH 0/3 RESEND] Per memcg lru_gen node stat To: Huan Yang Cc: Yu Zhao , Jonathan Corbet , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Peter Xu , David Hildenbrand , "T.J. Alumbaugh" , Axel Rasmussen , Ryan Roberts , Kefeng Wang , Suren Baghdasaryan , "open list:DOCUMENTATION" , open list , "open list:MEMORY MANAGEMENT" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" , opensource.kernel@vivo.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 19 Oct 2023 09:02:16 -0700 (PDT) On Wed, Oct 18, 2023 at 7:32=E2=80=AFPM Huan Yang wrote: > > Android can't use debugfs in production, but I > > think we'd prefer to use memory.reclaim for eviction anyway because it > > respects memcg limits and reclaims from slab. > Yes, shrink control this actually can use proactive reclaim. > > > > So maybe it's possible to add just aging functionality specific to > > MGLRU? It'd be nice to know how you're going to use the aging, or why > Due to debugfs not always mount, if we want to now lrugen's info, maybe > nice to offer a memcg's node to show per memcg's lrugen info. > > you want this version of eviction instead of what memory.reclaim does. > I think Yu's inquiry was about whether you will look at the lrugen info from the memcg file for a production use case, or just for debugging where you don't have debugfs for some reason. Because it's a long term commitment to add the file.