Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
MIME-Version: 1.0
References: <ZST/WggW4hSVs9d4@gmail.com> <202310101641075436843@zte.com.cn> <ZScQZLTssSfq19Jm@gmail.com>
In-Reply-To: <ZScQZLTssSfq19Jm@gmail.com>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Thu, 19 Oct 2023 09:04:45 -0700
Message-ID: <CAJuCfpH8mBCx-YvL0bLzUSHf_N+k4ii9uWpRX5JxOHxvD=Rdbw@mail.gmail.com>
Subject: Re: [PATCH linux-next v3 2/4] sched/psi: Avoid update triggers and
 rtpoll_total when it is unnecessary
To:     Ingo Molnar <mingo@kernel.org>
Cc:     yang.yang29@zte.com.cn, peterz@infradead.org, hannes@cmpxchg.org,
        linux-kernel@vger.kernel.org, juri.lelli@redhat.com,
        mingo@redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Oct 11, 2023 at 2:15=E2=80=AFPM Ingo Molnar <mingo@kernel.org> wrot=
e:
>
>
> * yang.yang29@zte.com.cn <yang.yang29@zte.com.cn> wrote:
>
> > From: Yang Yang <yang.yang29@zte.com.cn>
> >
> > When psimon wakes up and there are no state changes for rtpoll_states,
> > it's unnecessary to update triggers and rtpoll_total because the pressu=
res
> > being monitored by user had not changed.
> > This will help to slightly reduce unnecessary computations of psi.
> >
> > Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
> > Cc: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> > Cc: Ran Xiaokai <ran.xiaokai@zte.com.cn>
> > ---
> >  kernel/sched/psi.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> > index be853f227e40..143f8eb34f9d 100644
> > --- a/kernel/sched/psi.c
> > +++ b/kernel/sched/psi.c
> > @@ -704,11 +704,12 @@ static void psi_rtpoll_work(struct psi_group *gro=
up)
> >       }
> >
> >       if (now >=3D group->rtpoll_next_update) {
> > -             update_triggers(group, now, &update_total, PSI_POLL);
> >               group->rtpoll_next_update =3D now + group->rtpoll_min_per=
iod;
> > -             if (update_total)
> > +             if (changed_states & group->rtpoll_states) {
> > +                     update_triggers(group, now, &update_total, PSI_PO=
LL);
> >                       memcpy(group->rtpoll_total, group->total[PSI_POLL=
],
> >                                  sizeof(group->rtpoll_total));
> > +             }
>
> Yeah, so I believe we may have been talking past each other for past
> versions of this patch: why is this patch modifying the order of the
> modification to group->rtpoll_next_update?
>
> It should do the below sequence, nothing more - see the patch attached
> below. This is basically a combination of patches #2 and #3.
>
> And then the final patch removes the now superfluous 'update_total'
> parameter, which is always true.
>
> Here are the commits I applied to tip:sched/core:
>
>   e03dc9fa0663 sched/psi: Change update_triggers() to a 'void' function
>   ...
>   80cc1d1d5ee3 sched/psi: Avoid updating PSI triggers and ->rtpoll_total =
when there are no state changes
>   3657680f38cd sched/psi: Delete the 'update_total' function parameter fr=
om update_triggers()
>
> I rewrote the changelogs for readability.
>
> Thanks,
>
>         Ingo
>
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>
> From: Yang Yang <yang.yang29@zte.com.cn>
> Date: Tue, 10 Oct 2023 16:41:07 +0800
> Subject: [PATCH] sched/psi: Avoid updating PSI triggers and ->rtpoll_tota=
l when there are no state changes
>
> When psimon wakes up and there are no state changes for ->rtpoll_states,
> it's unnecessary to update triggers and ->rtpoll_total because the pressu=
res
> being monitored by the user have not changed.
>
> This will help to slightly reduce unnecessary computations of PSI.
>
> [ mingo: Changelog updates ]
>
> Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Suren Baghdasaryan <surenb@google.com>
> Cc: Peter Ziljstra <peterz@infradead.org>
> Link: https://lore.kernel.org/r/202310101641075436843@zte.com.cn

This version looks correct to me.

Acked-by: Suren Baghdasaryan <surenb@google.com>

> ---
>  kernel/sched/psi.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index be853f227e40..79f8db0c6150 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -704,11 +704,12 @@ static void psi_rtpoll_work(struct psi_group *group=
)
>         }
>
>         if (now >=3D group->rtpoll_next_update) {
> -               update_triggers(group, now, &update_total, PSI_POLL);
> -               group->rtpoll_next_update =3D now + group->rtpoll_min_per=
iod;
> -               if (update_total)
> +               if (changed_states & group->rtpoll_states) {
> +                       update_triggers(group, now, &update_total, PSI_PO=
LL);
>                         memcpy(group->rtpoll_total, group->total[PSI_POLL=
],
>                                    sizeof(group->rtpoll_total));
> +               }
> +               group->rtpoll_next_update =3D now + group->rtpoll_min_per=
iod;
>         }
>
>         psi_schedule_rtpoll_work(group,