Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp460592rdb; Thu, 19 Oct 2023 09:08:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEdfdAKIw6T/MAL0Pj3/AXPRzbrFOKjSMgb0uV/XTcDI32o9cHDQL/Kj4vgk7Q3IicILBJn X-Received: by 2002:a05:6a00:189f:b0:68f:c7c5:a73a with SMTP id x31-20020a056a00189f00b0068fc7c5a73amr2981300pfh.16.1697731695670; Thu, 19 Oct 2023 09:08:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697731695; cv=none; d=google.com; s=arc-20160816; b=vqu3Ixh/TL1BBrm4JfpyqPUGpB6pTJrpvrRJNFQ49aF16wYSfEsEZ/FSBeyVhch0Cf VHqzwvrZe6e0fvw0AAbhSDLh1rK1/IJAe0K+u0or4+0QHowa4CGENWSQBNeAk+0msWMD V003Y4Ojjhxqg5D9JbwkkQ2cK0huadcMcCxW/qhoTDaM+d2OXXNF3F9TW6n9XHqhuSHk lWk5Es01gtThSP9iG3Eq1sHfOcjERELm1mqlmFTRSquqHCpVuUc8lLwgYRlVMU7r/o+i N+tDDTLoGsqbZ+r1wscKJjA/a8n9OYeuZsqidE3H2pNVBSKdhGKhacnhjvnKvlr8U5Cu lS9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=EmnPH3jDYtW1cB98XlzrlUIo9mVxEt9reMcjg2WxHC8=; fh=isu86EmybElWFqzY2mFjTrILxzGsKaA2jv0Vt1oDWs8=; b=JMAj7LSP2E0BnkzmWWr8p7kiHt+zDeEi5TQaiGEM+jIUfaADs+VP3ptW8vuRjZM6/1 zfwFmUpVUmPudLg1eHUL1JIdLFS+GNG1Fcw3PqGFiBDA3U09qP70lGIzCRZqb25nfxvw /8UWNx+XQB4RNVhwjUYsJU75zL5YjrRElJyCIZ8UH28ixZJP3KXzITs7hvvSj2MsXwxF +pxPSINZ3qQ/iNtdCduc9Q0xyuDzz+4DonSDPrU9XvKiyPj9qYC4QBcbtrhzdqlHx385 4wk25AGC+TEwU86C3dfnnG4eybbcoMLgmGE8zNidmMvh18QaD69PH3NXYOi60KPPHj4U wDvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=cCRbVbNz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id fj19-20020a056a003a1300b00690ca3d66bbsi6811713pfb.262.2023.10.19.09.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 09:08:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=cCRbVbNz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 9DCFD82A8562; Thu, 19 Oct 2023 09:08:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345398AbjJSQIE (ORCPT + 99 others); Thu, 19 Oct 2023 12:08:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235445AbjJSQID (ORCPT ); Thu, 19 Oct 2023 12:08:03 -0400 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5263EB3 for ; Thu, 19 Oct 2023 09:08:02 -0700 (PDT) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-5a7dafb659cso100082957b3.0 for ; Thu, 19 Oct 2023 09:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697731681; x=1698336481; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EmnPH3jDYtW1cB98XlzrlUIo9mVxEt9reMcjg2WxHC8=; b=cCRbVbNzlwGw84+vIDfFOxj5/QQROMhI34VNTd16rimtz/qvWIS8o0cG3yoaWdsdwm xQua4nIuFRZ97laGDqsZhYq/iqulYY6dQY1k5+zqUhEUbnbQOqIumkBzbzX2le+lJjRe knhYBW2zEevNoAAtnSwLsUuFjwI3+s2F4jsauy+i57DrSr6sJsnUu8QkwBGPfJJkRW53 l3MMk/LO8NM7sFXXtPmx4cM8WWFjw+OlNsXTiHg9Xnq62l7B8mz1YJ9hUVhmc0Ljvce3 1y4vC3aYkh1Mx1o8VJ8NOBBmvkuvz1YfatH4jzoxZRA/cy5KPnLz0ICilDiBzsxlkqXu GT2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697731681; x=1698336481; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EmnPH3jDYtW1cB98XlzrlUIo9mVxEt9reMcjg2WxHC8=; b=Sy8u/+qMyCJwRx/m5PHkheycSdG7D/W1PKQ/aV5AQ0T+WLS1nnEPAieCTnIXorC+wq VuN1RYqCrmKOcqFvtsH2n9h2NiQjHJ4jj1cm0PfF63zoTvorAgRW7KIG4IRcRjLKyBvw pOkSX9zc893k5kwy38iIhU4RjerPbe9KQYF2HeF4MfiP9bp6dNAr6vaJ4agVphx5Gt/v X7IGojUpxspeG+dBc5laXs6XuGA8lBJ7dCJgbgWJ21sDJy2t4zw+FRuaVvvwNwUFesP6 /M9vb3m84KsriK73lIr13gtiyouN4fox3YJBh9WPrE6yT9sNILri61mjdSaB8yUKMy6q BOcA== X-Gm-Message-State: AOJu0YxZmhsf5W1IdqtwzdMyYIQd6EUST8H4ojqVCuThKhUnYONjLyUD 5pL2cuRKIGWsE5oMBTvnQBnSmuD47VmpfULF7t4arTHGrtAvfjtSH1wWlA== X-Received: by 2002:a0d:d9cf:0:b0:5a7:af46:d79d with SMTP id b198-20020a0dd9cf000000b005a7af46d79dmr2636378ywe.43.1697731681014; Thu, 19 Oct 2023 09:08:01 -0700 (PDT) MIME-Version: 1.0 References: <202310101642598576993@zte.com.cn> In-Reply-To: <202310101642598576993@zte.com.cn> From: Suren Baghdasaryan Date: Thu, 19 Oct 2023 09:07:50 -0700 Message-ID: Subject: Re: [PATCH linux-next v3 3/4] sched/psi: update rtpoll_next_update after update triggers and rtpoll_total To: yang.yang29@zte.com.cn Cc: mingo@kernel.org, peterz@infradead.org, hannes@cmpxchg.org, mingo@redhat.com, linux-kernel@vger.kernel.org, juri.lelli@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 19 Oct 2023 09:08:12 -0700 (PDT) On Tue, Oct 10, 2023 at 1:43=E2=80=AFAM wrote: > > From: Yang Yang > > Update group->rtpoll_next_update after called update_triggers() and > update rtpoll_total. This will prevent bugs if update_triggers() uses > group->rtpoll_next_update in the future, and it makes more sense > to set the next update time after we finished the current update. > > Signed-off-by: Yang Yang > Suggested-by: Suren Baghdasaryan I believe Ingo's version at https://lore.kernel.org/all/ZScQZLTssSfq19Jm@gmail.com/ already includes this change. > --- > kernel/sched/psi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c > index 143f8eb34f9d..79f8db0c6150 100644 > --- a/kernel/sched/psi.c > +++ b/kernel/sched/psi.c > @@ -704,12 +704,12 @@ static void psi_rtpoll_work(struct psi_group *group= ) > } > > if (now >=3D group->rtpoll_next_update) { > - group->rtpoll_next_update =3D now + group->rtpoll_min_per= iod; > if (changed_states & group->rtpoll_states) { > update_triggers(group, now, &update_total, PSI_PO= LL); > memcpy(group->rtpoll_total, group->total[PSI_POLL= ], > sizeof(group->rtpoll_total)); > } > + group->rtpoll_next_update =3D now + group->rtpoll_min_per= iod; > } > > psi_schedule_rtpoll_work(group, > -- > 2.25.1