Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Thu, 19 Oct 2023 18:45:53 +0200
From:   Michal Kubecek <mkubecek@suse.cz>
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     =?utf-8?B?S8O2cnk=?= Maincent <kory.maincent@bootlin.com>,
        Oleksij Rempel <o.rempel@pengutronix.de>,
        "David S. Miller" <davem@davemloft.net>,
        Andrew Lunn <andrew@lunn.ch>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Vladimir Oltean <olteanv@gmail.com>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net v1 1/1] ethtool: fix clearing of WoL flags
Message-ID: <20231019164553.zcc6d2vbxzw4m4c2@lion.mk-sys.cz>
References: <20231019070904.521718-1-o.rempel@pengutronix.de>
 <20231019090510.bbcmh7stzqqgchdd@lion.mk-sys.cz>
 <20231019095140.l6fffnszraeb6iiw@lion.mk-sys.cz>
 <20231019122114.5b4a13a9@kmaincent-XPS-13-7390>
 <20231019105048.l64jp2nd46fxjewt@lion.mk-sys.cz>
 <20231019152743.09b28ef4@kmaincent-XPS-13-7390>
 <c0f98227-459f-43c6-9c0e-db0a7ea07c9e@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="esat6ae76hdj6xm2"
Content-Disposition: inline
In-Reply-To: <c0f98227-459f-43c6-9c0e-db0a7ea07c9e@gmail.com>
Precedence: bulk


--esat6ae76hdj6xm2
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 19, 2023 at 09:20:31AM -0700, Florian Fainelli wrote:
> On 10/19/23 06:27, K=F6ry Maincent wrote:
> > On Thu, 19 Oct 2023 12:50:48 +0200
> > Michal Kubecek <mkubecek@suse.cz> wrote:
> >=20
> > > On Thu, Oct 19, 2023 at 12:21:14PM +0200, K=F6ry Maincent wrote:
> > > > On Thu, 19 Oct 2023 11:51:40 +0200 > Michal Kubecek <mkubecek@suse.=
cz>
> > > > wrote:
> > > > >=20
> > > > > The issue was indeed introduced by commit 108a36d07c01 ("ethtool:=
 Fix
> > > > > mod state of verbose no_mask bitset"). The problem is that a "no =
mask"
> > > > > verbose bitset only contains bit attributes for bits to be set. T=
his
> > > > > worked correctly before this commit because we were always updati=
ng
> > > > > a zero bitmap (since commit 6699170376ab ("ethtool: fix applicati=
on of
> > > > > verbose no_mask bitset"), that is) so that the rest was left zero
> > > > > naturally. But now the 1->0 change (old_val is true, bit not pres=
ent in
> > > > > netlink nest) no longer works.
> > > >=20
> > > > Doh I had not seen this issue! Thanks you for reporting it.
> > > > I will send the revert then and will update the fix for next merge-=
window.
> > >=20
> > > Something like the diff below (against current mainline) might do the
> > > trick but it's just an idea, not even build tested.
> >=20
> > Seems a good idea without adding too much complexity to the code.
> > Will try that and send it in next merge window.
>=20
> Not sure what you mean by next merge window, we need a fix for right now,=
 or
> we need to revert 6699170376ab ("ethtool: fix application of verbose no_m=
ask
> bitset").

Not that one, that's an old commit that was correct from functional
point of view (the only problem was that it sometimes triggered
a notification even when the value was not changed but that also happens
in other places).

A revert of commit 108a36d07c01 ("ethtool: Fix mod state of verbose
no_mask bitset") is already in net tree as commit 524515020f25 ("Revert
"ethtool: Fix mod state of verbose no_mask bitset"").

Michal

--esat6ae76hdj6xm2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEWN3j3bieVmp26mKO538sG/LRdpUFAmUxXT0ACgkQ538sG/LR
dpXp0gf/bEEu3zB+iSkVxzX/WV0Xxd6xXvSYXcnqG9J80GINiRxy4sBkPLrRt/Ui
VGEBESwLL8hgo60xyejU0GLthr2HQtgXiDxzh+cEisaJVx5wOu4CWkZgw/M/amvN
UkEDGLn+NTYNUFuvlmE1MNX+OKK1gd/WeqW1ZskPW8ZwsmxMyGab1r9Q6ViienSZ
1tPwEGnm+pMu1LLDw4x21U18Bd05sHqz7LyUc6CwD3JVnYYjZKAyLwhy7MvgTYfC
Dfl18XL+OwtfqoQYd2ChqLxsCOGjwJb9WlCBzOeTo8dgxGv9FRb3zIaJ8UVomMOH
E77QtxWJtK0FzrJfgmS0XCgiT36mLA==
=WWBP
-----END PGP SIGNATURE-----

--esat6ae76hdj6xm2--