Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp487916rdb; Thu, 19 Oct 2023 09:51:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdFHijly6pr+C91Nwxo4XCLI/6VEfuwbaADhzmamyGs5vdj+FBXiCDkpN5wNg50JOMAwu6 X-Received: by 2002:a05:6a20:3d11:b0:171:a8bc:74b2 with SMTP id y17-20020a056a203d1100b00171a8bc74b2mr2824612pzi.7.1697734261708; Thu, 19 Oct 2023 09:51:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697734261; cv=none; d=google.com; s=arc-20160816; b=K7rkzkNhIQ0gD2p30M7B5+oNaMIjUafTHWL3U93vqQCVnpLmEFyCSxYS2s4qmPgaLt 5+T1dRROvJUOEry8RhZU9QWp3Nq0cxGHcoaAHRrF35DKn+RBpLhqjyrWkoX+LdViMPdP mOFF1LPM8i1o/5klNZK2yaaMulW1rYniHXctq7edOi4/Jusqv2Ks28FbZaUjrnB7q5qA sCKp3doQiEDYrcr/nVhOwj3SEOYArgHqKpdEkZ9pzYfdkKZyewU7o2hPQl/O/VW9JysF bEU+D3YNOYM49Lcv6mWxlx77158wFShL+Fx9bsLvBbNcCL82Ki9qNzEiBJ+JuysiyjW8 HHaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lQweQwwpGWkIMbApVgMDhxYexLyt5MEybIY7O6WupmA=; fh=ffpO0dbyf5OrQ+8fxCAUHL2zW1A0gWLMLBKrbx8JUT4=; b=JVhYIv36u7iphw3Dhjz+MTpn9PYilXlJolwpKKRLEG+4RCYtU9QFTikCjO5qM0X7MI p1pakMdkFTeuStaNxjQvyDlg1XeAhs/f/YMtSULQElUhr0sfB9Vu80+uwE8sgLEZ5RGe RJfZpSIc7pEbP468MbtjxMzBx7TJ/fy0TFmU+a4/ur/0LTSrjqajOuRMhwUawY4pnRKC wzjpfMeyMSWqDOy5Y4nu7P5+YNI5l17mgZpVJNdzbt/Kzj1Tqq1wQvm0nSeo0XV2h3Qi CGo4WyJfOFomYs7NsrgFcLPsiw+nGZL18tDydQAwNdNAHPHl34edsnanNmjtRS5xgDB7 S2rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=BnG+Idv8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id o5-20020a656a45000000b00573ffd25b44si5295454pgu.182.2023.10.19.09.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 09:51:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=BnG+Idv8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id E13E7819701E; Thu, 19 Oct 2023 09:50:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233227AbjJSQug (ORCPT + 99 others); Thu, 19 Oct 2023 12:50:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233035AbjJSQue (ORCPT ); Thu, 19 Oct 2023 12:50:34 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 423B013A for ; Thu, 19 Oct 2023 09:50:32 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B14CC433C7; Thu, 19 Oct 2023 16:50:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1697734231; bh=FXh21OoAGR8XHVEBB81BE7UVszOS/EKxof6T4KL6Nl4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BnG+Idv8nNr0gcKnCyQpK3n/ViH2zsIUK+GNsyvYWvaNLLRkuhA3s6xv1G6OP5uEJ z8+9ayy43IEQoWYNVfjdT9j5RzedEbnOiqaC9LsPyfeKYpLo32AhxWtG1lYZdAId81 oVxmwWcFznV37Idq+XTw28lf/Vy534RnOGktF4do= Date: Thu, 19 Oct 2023 09:50:30 -0700 From: Andrew Morton To: Baoquan He Cc: Dan Carpenter , Philip Li , oe-kbuild@lists.linux.dev, Lorenzo Stoakes , lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Linux Memory Management List Subject: Re: mm/vmalloc.c:3689 vread_iter() error: we previously assumed 'vm' could be null (see line 3667) Message-Id: <20231019095030.7a1f3c93bc18511f52524aa8@linux-foundation.org> In-Reply-To: References: <89caf59a-d3b9-409d-b1ae-9e370cb9ee7d@kadam.mountain> <20231018085248.6f3f36101cbdfe0990c8b467@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 19 Oct 2023 09:50:52 -0700 (PDT) On Thu, 19 Oct 2023 10:28:21 +0800 Baoquan He wrote: > I think this is not a real runtime bug. The only chance it can hapen is > when (flags == VMAP_BLOCK) is true. That has been warned and could never > happen. I updated patch log and paste v2 here. Thanks, I updated the changelog in-place.