Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Thu, 19 Oct 2023 13:50:55 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Leon Romanovsky <leonro@nvidia.com>,
        Jiri Pirko <jiri@nvidia.com>, linux-kernel@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: mlx5 ConnectX diagnostic misc driver
Message-ID: <20231019165055.GT3952@nvidia.com>
References: <20231019082451.785aa123@kernel.org>
 <2023101923-tried-provable-72e7@gregkh>
 <20231019160145.GS3952@nvidia.com>
 <20231019092346.3387fad6@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231019092346.3387fad6@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m2QeUGTSIhugvMw4yqr/yxoQr1ewUJgzCdBGv+WpqooXHD2JQUG+g0k8JF0X?=
 =?us-ascii?Q?kcUEveujD4kEbOSSbONfK0+E7S/zRdg/ler5pHBpLQi3OWYKEaIzkpxxJm4f?=
 =?us-ascii?Q?afnViiWya+S5oAanP1Zs1AwEnV7ZOhdmnWspzQIuIcpmtWFPqgYW+4M/Tb7Q?=
 =?us-ascii?Q?oeMARqUhHNKIFQVoBNBhGZyHyJH2/QTchqWNxdZHkmxhpS/wqPfGjvzMXGZg?=
 =?us-ascii?Q?3DqCmIXgZUAsM0YHZwEFx7TEAu6sllsDfumwteXogPYAVGyQEUFVgoy19iPS?=
 =?us-ascii?Q?PslKofodAd1s2cCvWIn8mPEE2BTo4hxyelBk2Wc16cuQtQz4Ieao/gViTPHd?=
 =?us-ascii?Q?ekqDnW55nlbGbcd/wNLQ1K+v4syDpHAx/IyYk8DR6r2Jl9p4vRhwB+GNzs4E?=
 =?us-ascii?Q?UTSmHNNjCEGaAn1llRkVj8okUquPIgrkCkAa+GFRPr1o7fM21EW6q937zyEZ?=
 =?us-ascii?Q?LUNTZ6WzQLrQ2wbisIQh0RNUvcP+Is1YrqIl9n25vWNG2hb22++tRNJO11Rs?=
 =?us-ascii?Q?i/4h6ccno+i909BHSK6MeTCto6Razl3+oxa3NurW+8EX0aKYPKW0PTPq0U11?=
 =?us-ascii?Q?B+I/8pPbeBAgaj6r7yjE1qzm4HW9H6afA14nOtym1fLGdfyMvhydwkIkEnLT?=
 =?us-ascii?Q?rWDlqGNr4m/yoQbWELoJDNiWpPQiNJJ4dt7Fbqae6DToEOqKXAjo2QXNGVt1?=
 =?us-ascii?Q?lK4jl4hhnumhVS4ryUFd6/M7vMRHuja6ZOGBqebVXwSoYCZQ73dgSB5zob2G?=
 =?us-ascii?Q?lNnHeFXO7W/v48vQQQNYdMycLrKZn6WBAWKGHnB26Yf+9Zcd7kUTemj5wRrN?=
 =?us-ascii?Q?W4e3QYP/BMK7LsvZG8BsSpQDatcVxMbDEejr+GPDXahrWWnzPve7JUSHwQF5?=
 =?us-ascii?Q?6wUKwIyXtL6RJNEJDjdYqqps5e92nq3271SDx3hfXryrgPY4+mQ9HNWv8WYt?=
 =?us-ascii?Q?1Mof2XmqHa1dVKPbzRWoxLtd9X/nHinm2zoDYMkd//3qiU5AvhTpya3y+LJp?=
 =?us-ascii?Q?u8yrg1LqdrXTZ+xCQiD934fRJBoZgKoJMgpOmE8C1FUv7ZY/JHyHQjSJLWHy?=
 =?us-ascii?Q?Gtvfiios06olKO6D334iSaau0avwuvd6oxmIXoyXdVdN/ksijMVaNam6IqXA?=
 =?us-ascii?Q?oIyppcvm/LSq0XWs9fXhYjuMzvK9A1mSv/JX2kOyNpkqDi0knyK/xlfLC8O/?=
 =?us-ascii?Q?/lrJv1Gb53/G2kfXTGbQ4swtTk1QvNtkBtjemiHqP9DGEquSROE0kDSWnAbb?=
 =?us-ascii?Q?PfK8viB3c/iZq8PhuBPzTo6b85FrYyqDq6NVVuejgpnPLdcEto7zYUpaC++2?=
 =?us-ascii?Q?m3vZ3kB16CkyfadZt9AIiczz8hZm3EkQYSX8ObibVyi7pCozxZqqvkHv2rpp?=
 =?us-ascii?Q?bxc05Bh2ImDrsF4nHhhi50Ky4OZQqxKhFt+7if/OdQfzKcxLVxgi9DwuF4kf?=
 =?us-ascii?Q?Nx292Vx5LWkC6lcnU9t0QeWCCl7vA9zrbq7kPcYbSvMS+bVERU9cqqWKK/zh?=
 =?us-ascii?Q?AUk3dFvWGEUJ1t+rZ+bMrFh+ItKZ80u5qMHaln7DPMw6jW8LJVaIHhXtfFFz?=
 =?us-ascii?Q?HQRb2+UKCtFwPivmlk9uBbuQDHiNjGtFLSf4azdp?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72deaf7f-db57-475f-0a39-08dbd0c39105
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 16:50:57.4563
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mOz6+CoxcaQ6lm7cPlmm/RpxzDe6Ly4hW0XDrx6tNke6dTFz9JfamUCmqhERo4LW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5336
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 19 Oct 2023 09:51:14 -0700 (PDT)

On Thu, Oct 19, 2023 at 09:23:46AM -0700, Jakub Kicinski wrote:
> On Thu, 19 Oct 2023 13:01:45 -0300 Jason Gunthorpe wrote:
> > Do you have a lore link?
> 
> No, it was pitched at conferences:
> 
> Last year's LPC: https://www.youtube.com/watch?v=JGR9ZCeiW-E
> This year's netconf / KR, but Saeed didn't have slides:
> https://netdev.bots.linux.dev/netconf/2023/index.html
> 
> Really, you should be asking Saeed this, not me.

You brought it up. I was at that LPC talk, and you made it clear not
to even propose using devlink. Seems like that is what Saeed did to
me.

> > Looking at Saeed's tool capability on his github it is significantly,
> > but not exclusively supporting RDMA (ie drivers/infiniband), with some
> > features for the mlx5 VFIO drivers, mlx5 VDPA and a bunch of lowlevel
> > PCI stuff too.
> > 
> > Calling it a "networking device" in the sense of "it is owned only be
> > netdev" is not accurate.
> 
> Yes, let's now have a pointless augment about when a NIC is a NIC
> and when it's no longer a NIC because it has offloads.

This is not a pointless argument. How mlx5 hardware works in the many
subsystems it works with is NOT your exclusive decision to dictate
just because it has a shared networking port on the back of the card.

Lets focus on a community conensus approach between all the subsystems
please. If you have a better suggestion how to address this
cross-subsystem need then please share it.

> My point is Saeed pitched this to networking maintainers *twice*

I read that as for a devlink version, this is clearly not devlink.

> My point is Saeed pitched this to networking maintainers *twice*
> and then purposefully left us out of the CC list.
> That is absolutely unacceptable IMO, but I'd like to consult with
> others to make sure it's not just me. Please allow me some time
> to do that.

It is standard practice not to CC'd netdev for mlx5 related work
outside the scope of the netdev driver.

Jason