Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Thu, 19 Oct 2023 19:15:22 +0200
From:   Andreas Klinger <ak@it-klinger.de>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Angel Iglesias <ang.iglesiasg@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Sergei Korolev <dssoftsk@gmail.com>, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: bmp280: fix eoc interrupt usage
Message-ID: <ZTFkKl6Qu4vpfcC4@anderl>
References: <20231018152816.56589-1-ak@it-klinger.de>
 <20231019162209.18872-1-ak@it-klinger.de>
 <ZTFfRaShatWdxGB9@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZTFfRaShatWdxGB9@smile.fi.intel.com>
UI-OutboundReport: notjunk:1;M01:P0:8hVPFhKhLK8=;eztUtI2Qv6usiHJlHiN8ptlPj04
 2xuPNcmH3Cn4jhkvgtlYiZwUrvofz2zGtBfD8Z53AG+F9FXzc3cSZMheGjOOxL1G57lXhCvw8
 O53xNPxnq29dRBCmj+VpIlz+2eoVWhIBH8P0xJFcx0hBbSltAMOqAkSQweJBEoXR1Svlw7W6Z
 0cHx7yAlpbG4pR3yFvEBglxIRM8avdsouO3i9TWvonlL5yy5uP0xl/evHJuofNpcSaR7XMedG
 vFUYML2Chek9CshUbpylNG8bqK2FYgLMDB+27Gu1WbZKMlwtHOB64Pj94TV3yuhtSzRli0Ypo
 ZtPwH+MihBvh8CCxIhHYjbV5Oy79DKyYpouv5iK5Kb1EhW0d9OX27Zsd8ln4MZFzsGc3E3kKw
 UYzidNZtcewFV10ntUjEaw6LqtaZc/iY6qr0m11wLF129YQIpXMNjlZnbAJTn5nM4x8FmkS0V
 lM7SCDjNTa0uSAlMfSFJRi4R3Ingy72l6ndDvNUlwbe/GXvnLl8wbVxP1U4/WngKy5ClUfkgj
 gLG0WWU7LKHTKwCyKvGqVQ5FrpLXODodURfJNEYeyN6YRgge0mqtu6PMQ5tflmeMkI6x2aI22
 +LUELIXll2feIXlIrV6zwkL+WrdZEla9SJF/ednSb/lcA4RkuUkMVLR2srFie90/veMa/foW7
 8R9wQm80ud/GYZhOVxvvWqEfjfUV7XTgpacQxP6Zsiun8DEg9bE/ryL2IU0wIAMvBFh0h4yYA
 SsL3jvjy48OiuvzHsiwija3OcpC5kO+yiGWCYtEBtFp6rNI38QGpPH+jbMb/qJ1JOo3taIZIB
 XRImQ/3H8w/imGZSJ2wnw5zG5NxsOdFjM3SmvGq+Jfzlc/D6BNqCnNaFpBajQ5/ioyvoBD1Gu
 w183fzSGJdob9NaaCYgX/eCZnavnO5tSP30A=
Precedence: bulk

Hi Andy,

Andy Shevchenko <andriy.shevchenko@linux.intel.com> schrieb am Do, 19. Okt 19:54:
> On Thu, Oct 19, 2023 at 06:22:09PM +0200, Andreas Klinger wrote:
> > Only the bmp085 can have an End-Of-Conversion (EOC) interrupt. But the
> > bmp085 and bmp180 share the same chip id. Therefore it's necessary to
> > distinguish the case in which the interrupt is set.
> > 
> > Fix the if statement so that only when the interrupt is set and the chip
> > id is recognized the interrupt is requested.
> > 
> > This bug exists since the support of EOC interrupt was introduced.
> 
> > Fixes: aae953949651 ("iio: pressure: bmp280: add support for BMP085 EOC interrupt")
> 
> As Jonathan already commented, this is part of a tag block below...
> 
> > Also add a link to bmp085 datasheet for reference.
> > 
> 
> ...somewhere here.
> 
> > Suggested-by: Sergei Korolev <dssoftsk@gmail.com>
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> > ---
> >  v1 -> v2: Remove extra space (seen by Andy)
> 
> 
> And seems Jonathan mentioned that this is already fixed in his tree.
> Did I understand that correctly?

I just read it in the archive. For some reason I didn't get Jonathans mail
yesterday. Sorry for the spam.

Andreas