Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754381AbXKSWhM (ORCPT ); Mon, 19 Nov 2007 17:37:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752016AbXKSWhA (ORCPT ); Mon, 19 Nov 2007 17:37:00 -0500 Received: from ms-smtp-01.nyroc.rr.com ([24.24.2.55]:38335 "EHLO ms-smtp-01.nyroc.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751981AbXKSWg7 (ORCPT ); Mon, 19 Nov 2007 17:36:59 -0500 Date: Mon, 19 Nov 2007 17:36:39 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Bastian Blank cc: Glauber de Oliveira Costa , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, glommer@gmail.com, tglx@linutronix.de, mingo@elte.hu, rusty@rustcorp.com.au, ak@suse.de, chrisw@sous-sol.org, avi@qumranet.com, anthony@codemonkey.ws, virtualization@lists.linux-foundation.org, lguest@ozlabs.org, kvm-devel@lists.sourceforge.net, zach@vmware.com, jun.nakajima@intel.com Subject: Re: [PATCH 7/24] consolidate msr.h In-Reply-To: <20071119222151.GA11178@wavehammer.waldi.eu.org> Message-ID: References: <11946337851964-git-send-email-gcosta@redhat.com> <11946337933104-git-send-email-gcosta@redhat.com> <11946337991750-git-send-email-gcosta@redhat.com> <11946338053158-git-send-email-gcosta@redhat.com> <11946338103068-git-send-email-gcosta@redhat.com> <1194633815833-git-send-email-gcosta@redhat.com> <11946338212915-git-send-email-gcosta@redhat.com> <11946338263902-git-send-email-gcosta@redhat.com> <20071119222151.GA11178@wavehammer.waldi.eu.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1110 Lines: 32 On Mon, 19 Nov 2007, Bastian Blank wrote: > On Fri, Nov 09, 2007 at 04:42:48PM -0200, Glauber de Oliveira Costa wrote: > > - wrmsrl(MSR_CSTAR, ia32_cstar_target); > > + wrmsrl(MSR_CSTAR, (u64)ia32_cstar_target); > > Hmm, why do you add explicit casts? The compiler should convert that > correctly on its own. > > > +static inline void wrmsrl(unsigned int msr, unsigned long long val) > > Hmm, long long is 64 bit on all x86, but why not use explicit u64 to > show that? (quick reply) With PVOPS on it gives compiler warnings without that explict cast. Without looking at the code, IIRC with non-PVOPS it is a macro directly into asm, so it didn't matter what the cast was. But with PVOPS as a function, it gave compiler warnings. Take it out and try compiling it for both i386 and x86_64. One of them gave warnings. But maybe it's not a problem now. -- Steve - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/