Date: Mon, 19 Nov 2007 14:52:10 -0800
From: Greg KH <gregkh@suse.de>
To: David Miller <davem@davemloft.net>
Cc: david-b@pacbell.net, stern@rowland.harvard.edu, zwane@arm.linux.org.uk,
       tytso@mit.edu, torvalds@linux-foundation.org, stable@kernel.org,
       reviews@ml.cw.f00f.org, rdunlap@xenotime.net, mkrufky@linuxtv.org,
       linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
       jmforbes@linuxtx.org, dely.l.sy@intel.com, davej@redhat.com,
       chuckw@quantumlinux.com, cebbert@redhat.com, cavokz@gmail.com,
       alan@lxorguk.ukuu.org.uk, akpm@linux-foundation.org
Subject: Re: [patch 19/26] USB: mutual exclusion for EHCI init and port
	resets
Message-ID: <20071119225210.GA23798@suse.de>
References: <Pine.LNX.4.44L0.0711191403400.3005-100000@iolanthe.rowland.org> <20071119195955.B0C482214F3@adsl-69-226-248-13.dsl.pltn13.pacbell.net> <20071119.143241.165308264.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071119.143241.165308264.davem@davemloft.net>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1168
Lines: 32

On Mon, Nov 19, 2007 at 02:32:41PM -0800, David Miller wrote:
> From: David Brownell <david-b@pacbell.net>
> Date: Mon, 19 Nov 2007 11:59:55 -0800
> 
> > > This addition certainly won't hurt.  Did we ever get any feedback as to 
> > > whether it actually helped?
> > 
> > ISTR that davem refused to try it, after reporting an
> > intermittent failure on the original patch (which only
> > addresses one end of that hardware race).
> > 
> > So, no ... but given we know that closing only one side
> > of the race isn't quite enough, I think we need it anyway.
> 
> I think we should put all these changes in because at a minimum
> it's a step in the right direction even if it doesn't close
> the hole %100.
> 
> So please let's merge the mutex and the msleep() change in
> ASAP, thanks.

The msleep one is queued up for the next Linus pull, and after it goes
in, I'll add it to the -stable trees as well.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/