Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp572640rdb; Thu, 19 Oct 2023 12:24:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGZgDP1MFmnl4YHlrgj04C3wbCGepT3SundmFiqWCdEA+idI+K1bbwzm9psy4ST3cyzEmK8 X-Received: by 2002:a17:90b:3d07:b0:27d:5616:9907 with SMTP id pt7-20020a17090b3d0700b0027d56169907mr3112907pjb.46.1697743497195; Thu, 19 Oct 2023 12:24:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697743497; cv=none; d=google.com; s=arc-20160816; b=I8sdoaqDQSjyE0kS++If1BJZXIw4wQD56TsKg+IxLTxL5cONr0k9v+jzGSLoC2eAkG neUMW4eTjiMQstPosRP9HUje3qW6OimQlyBTfF5PH/tvpSV32en7RdDP28YWqxOaNC7L Dyn8hS6JQ2UDhwzspvjPWdvIq1PFuyqU42bpJOAMtyIjhRRu7FeDlG6bMzE5YMEgI6AP IpBK7Q/l1D+KDrBW5HMIGi/PQ48wbOm7GGnUvGN54wjOu9gDhUfDjzr7p9VZVQH6ZIKh WgfhnpLlCjAio627UGcqylLGpZRIkZ06r/TBKtgoyHhfyZgnI/bOglmLpmrwKxT4Mrnw 2i3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:mime-version:date :dkim-signature:message-id; bh=erlpPmXWY7ZgLDQf2M75tSp97C2n2Bc8pqWhV/xELGQ=; fh=CntFv+biRsHOs6e4h5E8rlrA+bHoxUzfu6nr/Y3AdEc=; b=OyRMzHSQyA/WK2nFy36jYwWd0q0Qbrz9sHhstFxbzu5IEMUWNrMdGHeGDOiKfhzR6X HtIXyP23O7+otSBmmuRWicuK1HdnxM0wU6/I++STo35iwWSXvIbkKrXwVkpfNzmenoPn MZbMd16zTOMkYCcPW6nadgXqE96pGq6xyx9fXjrO0+7eriOUvhulzqpRmtAqh9Bjjm7w IHEF94kpU13BKXDdHYpctrTfCBW9T5OIvASCho5g0B3eE5mjOl7C5xhXaxEBfj3X+xI6 2gwp+0MWUIYn0P6S3tp61nJfTuwpDBKZf8158VF2+uSNthqPkNQUd9fRsIeN6LJ2+JKH wujg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=cMOzuvxp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id ne10-20020a17090b374a00b0027995cf4342si299360pjb.55.2023.10.19.12.24.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 12:24:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=cMOzuvxp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 1106E827332F; Thu, 19 Oct 2023 12:24:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346497AbjJSTYy (ORCPT + 99 others); Thu, 19 Oct 2023 15:24:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345878AbjJSTYx (ORCPT ); Thu, 19 Oct 2023 15:24:53 -0400 Received: from out-204.mta1.migadu.com (out-204.mta1.migadu.com [95.215.58.204]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51C90CA for ; Thu, 19 Oct 2023 12:24:51 -0700 (PDT) Message-ID: <97a90b2d-cdc3-ac00-b1d7-1e735648ca8b@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1697743489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=erlpPmXWY7ZgLDQf2M75tSp97C2n2Bc8pqWhV/xELGQ=; b=cMOzuvxpwmLzmJbBkoXqhQdHNGyh15FaR2A2gm2PCoORxqU7QRUcx0BtQsWs6aqYz8dzyj 1DPOnTWCaGdln779BeQw8Sfo29neyXcflWnltqZScgP/n6pNZTbYx6WYFGw0B8IHdxTNYE qvWySZcJ7YIXtL+4TcvZRm3dmO5hoTM= Date: Thu, 19 Oct 2023 12:24:42 -0700 MIME-Version: 1.0 Subject: Re: [PATCH v7 01/11] bpf: Add sockptr support for getsockopt Content-Language: en-US To: Breno Leitao Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, io-uring@vger.kernel.org, sdf@google.com, axboe@kernel.dk, asml.silence@gmail.com, willemdebruijn.kernel@gmail.com, kuba@kernel.org, pabeni@redhat.com, krisman@suse.de, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Song Liu , Yonghong Song , John Fastabend , KP Singh , Hao Luo , Jiri Olsa , "David S. Miller" , Eric Dumazet References: <20231016134750.1381153-1-leitao@debian.org> <20231016134750.1381153-2-leitao@debian.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20231016134750.1381153-2-leitao@debian.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 19 Oct 2023 12:24:56 -0700 (PDT) On 10/16/23 6:47 AM, Breno Leitao wrote: > The whole network stack uses sockptr, and while it doesn't move to > something more modern, let's use sockptr in getsockptr BPF hooks, so, it > could be used by other callers. > > The main motivation for this change is to use it in the io_uring > {g,s}etsockopt(), which will use a userspace pointer for *optval, but, a > kernel value for optlen. Acked-by: Martin KaFai Lau