Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <14fff2c8-010a-4fc7-b1eb-7af85e3868b5@intel.com>
Date:   Thu, 19 Oct 2023 12:19:42 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net v2] i40e: Fix I40E_FLAG_VF_VLAN_PRUNING value
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC:     Mateusz Palczewski <mateusz.palczewski@intel.com>,
        Simon Horman <horms@kernel.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        "Tony Nguyen" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>,
        Sylwester Dziedziuch <sylwesterx.dziedziuch@intel.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20231019163721.1333370-1-ivecera@redhat.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231019163721.1333370-1-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1R6Y2p0c3ZqSU93K2k5V1JLMXB2YjFtMEV5UUE4SWhXQzVYbkhtbkJqOWF0?=
 =?utf-8?B?OTF2cjBadHdjczk3clptcDJuNVhKOGt6dk5lZjJXbUtSaS91cG9hazVLRlpH?=
 =?utf-8?B?Ulg1Zm1lY2FXMG1hdXRJVUVpaFJsZ0htYlFHellqMyttUzJJSmJ5Rlk0d0gv?=
 =?utf-8?B?eDRpalR1UHVzTnV0QmZlTHJraFpJd2ZWaXVtMEpaZDluVG9tTkRPckR6b2JX?=
 =?utf-8?B?c1A3Z3d6K29qbUVDazZXd2xSWWt6STlmOUJYZ3JtKzAzREhNM3h1UWVmTW1H?=
 =?utf-8?B?ZVAvS2pHL2pIbjNWaVVoamJydzM1UFp6NDNhNm42QldrcGZDSTZzY2xrOHlG?=
 =?utf-8?B?Q1o1d01jTEtONjhKbVNhV3BkWkl2KzRvTjlaSHhid1lRbWlyb1haUnNBMzVv?=
 =?utf-8?B?eXdVM2x1aEs4dk52aGhnWmtkN3FsTU5ycktHUkVlb0s5OFlRZXR4Sjh6U2R0?=
 =?utf-8?B?WU9QRWZKc2M3dkcwV1NwVkJkWm12U0p6REhuQXozcG94SUY0U1Q5eGFPOHlq?=
 =?utf-8?B?WDZYNzNTaVJ0R2x3cHpkR29Idk9TYmpqa0VNV2V1OEYxUlZnMVA5V3lzU1V1?=
 =?utf-8?B?NHlXM2JaOUw0d3ZWc1A3NXNxMkVFRDNxbFBMaE9wd0lkTEhUYjBxM3RXK0F2?=
 =?utf-8?B?QmJLZUpXRWYvcmV3UGV2T2lab05wQklKMXk5SERES05kR0Mya29iRHg3cE1a?=
 =?utf-8?B?U2cxakZ4TlU4KzhsRjRuR1h0eGxoeWxZTHpKTHNmSnlvdloxZHhxL21tTXpM?=
 =?utf-8?B?MCtRV09xYVpzMFU1MnFkWDZJVC8vTUdoTCtINkNxZCtRMy9PTTVWMFFXdHNB?=
 =?utf-8?B?aGNucEdyOWpudkdRRVJSalNBRWY1M0VqditoR1p3N1BnQ1kxcFZpeDg2cE5W?=
 =?utf-8?B?eVp6L1FPbHMrMUs3S25UeUFKZ3JPTnhVNldVVklxb3FFNk5LSW05VDlJY3VR?=
 =?utf-8?B?UUcxVXdlQzByaGJIU0JTT0d2RnlialF2QnpjNW92ZVVSRTVYYnU3dThlejJs?=
 =?utf-8?B?UzNJQjdFQUVWYThZcWRoa3U2aHVrRlVQbXlodEZQbmRKeXFLQ1lsZUlMYklQ?=
 =?utf-8?B?eUR0T2FWVURjNzdmZlRmTXFwck5IR29jcDJDQlZRbzg4bDdtTEhSMVpURThD?=
 =?utf-8?B?elNPMmppU3l1LzZBOFRKQ25SY0UwOFprL3dFalZSMDlIU3dtWUFXVkZEbTF1?=
 =?utf-8?B?R2NRT0hFeHlKVi80VnFNVlRNb0hWQlZjd24ydzJpUDZwRmxoMHRRck4zMmhM?=
 =?utf-8?B?OTZGQWZWbkRlVmpydEt5eE1MRnhxOVo0OHMvRmNuT21HWXQ0REhBcy9UOXMx?=
 =?utf-8?B?SDYrVTc5UlFWSU13V1pXM3FLR1ZES05oRS9HZWpPUHFEemNRUSszV3FUUUFu?=
 =?utf-8?B?SmZKd1FLOWhmUWRCYWFNN0lZZzM0dGF5QmJjVWpMbnNYSHFnam9ibnphQU9V?=
 =?utf-8?B?L20zU3dKbjV2TU14T0hhUTM4dUZlOVc3UERZcng1dEhrb0FNQURKQWdpQmRM?=
 =?utf-8?B?QVZLeStrK2VwVVRYOWNQaEZrbnZwaTc1RkZzZUZLSDAvWE10aVh0T3hJeFc1?=
 =?utf-8?B?ZDNhQW1VZG5YWFhnLzM0NjdXeFZQcEhNK3ByV0dvVUhvMHdiRzVWSTVhOGpI?=
 =?utf-8?B?QVJ6aGpZVGZDaUlVNFFyUU1MOUtVMmh5M0RWd09RWE5pQUdNVHZwVk8zSFBZ?=
 =?utf-8?B?VnpzWDAvRnVKb01KNlhKd05BRDFLWkc4RmlVS1pOUDRwbkVnQkQ3S0ovOG9I?=
 =?utf-8?B?cTNrY0kyV3g0eWlEdm9MaVRhek9oR25VZS9xVU9BRXgwSUZFYldNYTIwZGd3?=
 =?utf-8?B?dW8zWE9MMzQwb2krR0JzTndGdXZPWnRkYmc0eWhPWUdaalJTd0dza0hoa05G?=
 =?utf-8?B?a0xMQTBYT2RiZWNxYVZRbVk5WG4wL1N2bytKMEg3T3g2UzI2VWdqQUpoR1gx?=
 =?utf-8?B?ZGhGMzhMUmU1ZG5rMHYzUk0wdS9ycnhsMVN6SGlrakpXMnZXRDRwM3FaRDln?=
 =?utf-8?B?cGg3S2VoMVdGNS9ZZnlibGtlVjE2UGtneXVmSXNSOGlrMVNCVnZMcmhFREJs?=
 =?utf-8?B?dWhlVW1QeC9CR2cxSHpGWGxrOVp6NHRwZmFLUXd4UW1HTTZjdTBhYkNnWXRG?=
 =?utf-8?B?NmpHNXJCS3Y3b1pobGlxUWRyZS9JbHlWSTdCaENJTllQTHNFd3pHSmFEYU42?=
 =?utf-8?B?emc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ef99838e-44b7-49c1-b537-08dbd0d85a14
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 19:19:44.7122
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FFPEx/kc+hA7cwoLcHqeo1pwEbVcUiYDh/cgUwLiZIrc5iD9rce1nlKzrPy7t6776/vxJZ9SotcGCE/i0eHmY7PnSMluLT4F6C+gUCRgEAo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5637
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 19 Oct 2023 12:25:52 -0700 (PDT)


On 10/19/2023 9:37 AM, Ivan Vecera wrote:
> Commit c87c938f62d8f1 ("i40e: Add VF VLAN pruning") added new
> PF flag I40E_FLAG_VF_VLAN_PRUNING but its value collides with
> existing I40E_FLAG_TOTAL_PORT_SHUTDOWN_ENABLED flag.
> 
> Move the affected flag at the end of the flags and fix its value.
> 
> Reproducer:
> [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 link-down-on-close on
> [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 vf-vlan-pruning on
> [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 link-down-on-close off
> [ 6323.142585] i40e 0000:02:00.0: Setting link-down-on-close not supported on this port (because total-port-shutdown is enabled)
> netlink error: Operation not supported
> [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 vf-vlan-pruning off
> [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 link-down-on-close off
> 
> The link-down-on-close flag cannot be modified after setting vf-vlan-pruning
> because vf-vlan-pruning shares the same bit with total-port-shutdown flag
> that prevents any modification of link-down-on-close flag.
> 
> Fixes: c87c938f62d8 ("i40e: Add VF VLAN pruning")
> Cc: Mateusz Palczewski <mateusz.palczewski@intel.com>
> Cc: Simon Horman <horms@kernel.org>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>