Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp579327rdb; Thu, 19 Oct 2023 12:38:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEOGJ0RVeBWxtj180IpIFaiEmU1eORdzlQcftLA65TXoihBEa0aR5jDDw1uSW6nBE1708C8 X-Received: by 2002:a05:6871:5389:b0:1d5:a955:8bb3 with SMTP id hy9-20020a056871538900b001d5a9558bb3mr3821606oac.43.1697744335822; Thu, 19 Oct 2023 12:38:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697744335; cv=none; d=google.com; s=arc-20160816; b=Re9fFX0lf597lxQLcJH9ZfCkRFYpUsyTWXryST1CI/JBmGOynqybYWipV0nTWI1/F/ cVPHCY8Ry1X/rfr1TZoxsYTwIBCri6Az5Rvn7puNm5l8dnYY2PBjxKCKgZbeUSbh6wsh F+KeukP57Nh/AJob8Ya9wKBYlwMMFZNbHBeCrkN3Mf6xjk47b9iPdiHKvg7VHrfWeS67 xg26PoH2TaE9OeAIaeA5HJs3ASXiRtovz1tOw5stBjgLzeioshp1LleDD/OLPaNSX0Iu ttyf9txUSD3HWXfbDH/l0DcvoYIwYBud0kls7awNWBYY3rENorIlx3yhX1QS9e4bLjFl dxRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:mime-version:date :dkim-signature:message-id; bh=gdtap++lMZMR+npoayI3yJj/d7NXDRQud4t4dlixIKc=; fh=lLOohGrmB3Jsjt95py/bhxonQrL29S9GvyOVW9vDsWQ=; b=cAUAeCD2Hk5jHtQi+hPRZPmNv1SvgDLIji7/91Myuf1Nc8/4KnTnF+W+3rYksyurWD 9Zu6It5NPEzB1OWd3ns836UV/pUa1ECGTdqwrEf8j5AixfFDWoctFu1ZHghR8s906OF8 jDOIGb2yfw+FuqWB5lY6hsdKeYgPrAk7FRoyHoh4ih7QWZiuEdryyoR0C00t8RE1WLUW ARCcunvHvZdt2kxN1ntVM4T9cV7IfmN64Qlw9CbL6UWxKvXKcxIhHk6gZOrxmZjT0ost C8geHkAv7sHKu1ua6pBSi1MXCTTHYs112Znu2H0xGCqQeaIt0juMisNiKjOeEfraRXsL JMGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=KoAjOWrg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id q19-20020a632a13000000b005aaf19c3981si249317pgq.329.2023.10.19.12.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 12:38:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=KoAjOWrg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id A276F81BDA68; Thu, 19 Oct 2023 12:38:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346117AbjJSTir (ORCPT + 99 others); Thu, 19 Oct 2023 15:38:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbjJSTiq (ORCPT ); Thu, 19 Oct 2023 15:38:46 -0400 Received: from out-200.mta1.migadu.com (out-200.mta1.migadu.com [95.215.58.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CACAFA for ; Thu, 19 Oct 2023 12:38:44 -0700 (PDT) Message-ID: <45656c55-3b36-e5f1-e391-fcdf3b7894e6@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1697744322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gdtap++lMZMR+npoayI3yJj/d7NXDRQud4t4dlixIKc=; b=KoAjOWrgYuvMBCnvtBDFwNWO8ZD33nPPs9iWlNLqybcahwjCcVTJc5AVHcEiOIroK1ljdK Ohq4ZJcXM/7eiRAqDVl3mr6JTHXZnJJJlrIcuXuZqyUB9NrqZ//UczaWu0sWo5py1I1k+N Lv689zCHO651BaHSRJ6lWs1cZxrWmTU= Date: Thu, 19 Oct 2023 12:38:37 -0700 MIME-Version: 1.0 Subject: Re: [PATCH v7 03/11] net/socket: Break down __sys_setsockopt Content-Language: en-US To: Breno Leitao Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, io-uring@vger.kernel.org, Willem de Bruijn , sdf@google.com, axboe@kernel.dk, asml.silence@gmail.com, willemdebruijn.kernel@gmail.com, kuba@kernel.org, pabeni@redhat.com, krisman@suse.de, "David S. Miller" , Eric Dumazet References: <20231016134750.1381153-1-leitao@debian.org> <20231016134750.1381153-4-leitao@debian.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20231016134750.1381153-4-leitao@debian.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 19 Oct 2023 12:38:53 -0700 (PDT) On 10/16/23 6:47 AM, Breno Leitao wrote: > Split __sys_setsockopt() into two functions by removing the core > logic into a sub-function (do_sock_setsockopt()). This will avoid > code duplication when doing the same operation in other callers, for > instance. > > do_sock_setsockopt() will be called by io_uring setsockopt() command > operation in the following patch. Acked-by: Martin KaFai Lau