Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp630201rdb; Thu, 19 Oct 2023 14:32:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHR77NUOaXfbcxFxWiX5xhIzzxywxITNaMDN96c9nGySYC40/ABKpSgbDKJYYaSRKPURBHX X-Received: by 2002:a17:90b:2d8a:b0:27c:ef4b:6dcf with SMTP id sj10-20020a17090b2d8a00b0027cef4b6dcfmr138318pjb.21.1697751160089; Thu, 19 Oct 2023 14:32:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697751160; cv=none; d=google.com; s=arc-20160816; b=Dow4gEv+iIhqKFe1KGVJJoAEzMHzmgbeYDZAQ6GnpQk2V0SgrG/jnOMymvVxsiP02G kuZxZl35k0MqPBgZbqUi8U41nV5MmtEaE82CM+/70hmiyuQQslZYyWfs0EZKEBCPf7DD dj3OXxI4sQeUDk1m9iyFFsjg7gordPMeg1MbAa8TS0vjP9tH8ubjBtr8giihlMSyf602 K12IgQmrDWzhtcmjcIC7WXkWWwCXi11uqympmVto9HPlFu1CziJ5ikiZsgY2QH8pcZMM 6Y0EOPBt0I3KCq7CgQ0vq/ZYBY1qZLIFrfAYegcR7yFDVYiBf3QKZCVUZnTerrsTDUbN IFHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=avCTzwnDjRulD6OVSJFXgcVdYNeuXlO1b7I3sIdF1NU=; fh=xpP89JQ+GYdvJ3ANFC5g5vXjIv2CT8q3b+qC9sGohvw=; b=IP9eT3TdYT20BofPqLwxn24aTZZxjZPjrZrJBx8uNT0XSGN+p1aGKVyP3v3c9vBv/9 JyUy5WFmn63rjvsntVQTC8J3TEalw470XpSEAa+C0CVH5sM1pKaCo8bSt0oV5Sst0Gs2 pVvIaTdEkVjyTsLCwuRqq2fU6EPbMYf68wXqQ8UwsMDAVepJsFfiA3PRAKpFWKzYxvlf hnnoXAiuCImm7zGkI5W70T4+Z8wNU5n7mUWo/qyIwp6GA9BQCG5H97GW4P8DJ3Einmf5 cl1/wi+9HKklZdUOfMfwsHRUszr6syyM9YrEknlTVZA3ycJIHMxoF/x6d+UIjQzUVfaL lA6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="S5tk2/F/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id n11-20020a17090a9f0b00b0027b49f7c003si2937817pjp.15.2023.10.19.14.32.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 14:32:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="S5tk2/F/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 6B99F83C7599; Thu, 19 Oct 2023 14:32:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232759AbjJSVcW (ORCPT + 99 others); Thu, 19 Oct 2023 17:32:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230039AbjJSVcV (ORCPT ); Thu, 19 Oct 2023 17:32:21 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11E8F93 for ; Thu, 19 Oct 2023 14:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697751140; x=1729287140; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cw5t3VXt7tUZOXYsPRrDLRYcGpbLTXZ9huugpFgVVdo=; b=S5tk2/F/nh2Set71ZKZOWU4D2DwKz60DiX5gpgxGBCaruI8nVzPm5gV1 6KtB6p9mYkBLriFKTr/Y8D7TcUPU9txR/GH7T0M24Z3PHk0r77ZJ7c8Hb 14hAK53DAIHSCZhJqtvL/R5Ikt54NnHw9EJtkFHAdKVkywX/VxjeSeim3 JofTF1u59F1x8ypJk7OoUXCDJANcief6UENbz02cB4FUCdk4ebaZmfQuJ AoW99bVewz6eCWLu/U4dhaS31gaLI3cAKdL2axC2HdeR9GkFyZG8TyC0j L4A+fXJ6HEsa2XMirJyeLAniOQ/p6KkjJ6r6GZ/5EN4n31Ljmu+8YPDYo A==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="390258002" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="390258002" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 14:32:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="707002209" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="707002209" Received: from xuanyaoo-mobl.gar.corp.intel.com (HELO intel.com) ([10.214.165.172]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 14:32:13 -0700 Date: Thu, 19 Oct 2023 23:32:04 +0200 From: Andi Shyti To: Soumya Negi Cc: Andi Shyti , Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , Julia Lawall , outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2 2/2] staging: vme_user: Use __func__ instead of function name Message-ID: References: <996c9f92e7fd288f67c02dfb0ba524ab7c5fe421.1697696951.git.soumya.negi97@gmail.com> <20231019191428.GA32717@Negi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231019191428.GA32717@Negi> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 19 Oct 2023 14:32:29 -0700 (PDT) Hi Soumya, > > On Thu, Oct 19, 2023 at 12:20:10AM -0700, Soumya Negi wrote: > > > Replace function names in message strings with __func__ to fix > > > all checkpatch warnings like: > > > > > > WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get', > > > this function's name, in a string > > > > > > Signed-off-by: Soumya Negi > > > > you forgot my ack here: > > > > Acked-by: Andi Shyti > > > > Andi > > Sorry I forgot the tag Andi. I'll add the tags in v3(Greg has suggested > more changes). There will be some new patches, so I'll leave the tags out in > those as you may want to review them first. no problem. I don't see reviews from Greg in this v2 series. If you are referring to the changelog, then you don't need to resend. Andi