Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <695670fd-6762-42d3-b38c-fb347c8beb1d@oracle.com>
Date:   Thu, 19 Oct 2023 15:57:51 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/4] vhost-vdpa: reset vendor specific mapping to initial
 state in .release
Content-Language: en-US
To:     Jason Wang <jasowang@redhat.com>
Cc:     Eugenio Perez Martin <eperezma@redhat.com>, mst@redhat.com,
        xuanzhuo@linux.alibaba.com, dtatulea@nvidia.com,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <1696928580-7520-1-git-send-email-si-wei.liu@oracle.com>
 <1696928580-7520-3-git-send-email-si-wei.liu@oracle.com>
 <CACGkMEtkcyC54M_8A63uBEYjJP+EinLzTk3gP8CQ_rWs0Omt-Q@mail.gmail.com>
 <1bd79050-8eb5-49f6-9e58-6c7eb3fcab3e@oracle.com>
 <CACGkMEt_zvBM=ysbXZJEC1sdbCk=BpcWvtjeuP_L2WH4ke1dWQ@mail.gmail.com>
 <CAJaqyWf0AhsS6kaGUMVCosDjuRoeCAqO3OTVC=veqjV3jCqUjQ@mail.gmail.com>
 <8f8c0c28-59a4-489b-9276-fc3b5cfa8faa@oracle.com>
 <CACGkMEs0W1joaNh0-a27Nekxn8V8CmGgr99p+r60dA6sQeys5g@mail.gmail.com>
 <c9c819b9-4a63-4bb4-a977-881f6e653ed8@oracle.com>
 <CACGkMEuX8-T6BhbiqkTfF3NBoxS35zQ=k6Th=h0G5sDz4DV93Q@mail.gmail.com>
From:   Si-Wei Liu <si-wei.liu@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <CACGkMEuX8-T6BhbiqkTfF3NBoxS35zQ=k6Th=h0G5sDz4DV93Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDVTWUcwM1lVUGpOTHVNYTMyUTRkQVU1WDdONkdVMGtpMFNnWVRRTVo0WU16?=
 =?utf-8?B?cXgzSzZrSjVTTXQyQWY4encvWTBjeTA0Y3hZRk8xMnd1K1NLVC9vVTk3ZHpp?=
 =?utf-8?B?OTlNS1puTHVOYlAvRTBIMU5hUHN1ZS9SQXg1YnNwMFlJY3BqZENyaEpaOUp3?=
 =?utf-8?B?bklxRjNjOFE1TWR5MUxESHo5ek1CSWNCL2F6VGd1aExkM2d5b01YRDBDUFJG?=
 =?utf-8?B?d2pHcWJmdjJ2TU1jZjl0UzdzVGZ4OWUvOXN5QTZ0ZjUwMmtNMzQ5MmpxWkgx?=
 =?utf-8?B?ZGQ0M0ZQeXFleThPb3JnV1dYQnM0TGt3TmZOSTBFYjBMK0kySG9GOHhwV0Mr?=
 =?utf-8?B?REE2S1I0T0g2SGN1U1Y3dHAxMHF1WC9nVjM1T2tuemgxblFIZjF2QW5TZzlt?=
 =?utf-8?B?ZHhaOG9vRmdLK01lSU9uQUlCQVBDK3hkdkNUZEEzS1dWbnhhTmRWR0o0Kyt3?=
 =?utf-8?B?Mm15aFRMb2xpWHBNUHZIVzhpeE55MVdhVTlZQmNtTWxSc2hsNTMrZHJobjhY?=
 =?utf-8?B?SlFCZmp6dVc4ZHJOZy9Ya2ZMd1U4V3lXWkwwa08vUGt5V0JwWHJ0cTdoM2Jx?=
 =?utf-8?B?bUhCblR6dzBXT1FSQlh1WStZck5oR24vWThwaUZXYnVQWGVWZXJBNTA1L3Y4?=
 =?utf-8?B?YVVXNGY3Mno4d243TWpJRTlTbldoR1k1VVVqSlYyb3d2dzJONnN2REdWa0R3?=
 =?utf-8?B?L1Z4emdnMFRFTzlScjQ4ZkFwY25NSWYwNWJmcmNrTG1MZ2NNeHpsVW9JU1NY?=
 =?utf-8?B?cm9tT3pHL2FlTThOaXZKbVJqSHlmemQxcUFtZXZpdXk0UTJzQ21pRDNhN2hr?=
 =?utf-8?B?NUJWNjlUSS95QTUyV283UDRNTGZGU3A3OHd2NWpsMys5Q0tjZXd6ZG9xbzgw?=
 =?utf-8?B?dTYwNTFKVkZQdWNjSDBkb0hFNG9LLytQK1ZybTl5bnd3S0JJMFhvMlo3N09R?=
 =?utf-8?B?VlJTN0pmM3JoVHBLTUNva2hzZm5XRzVzemkxVitoVXlsRzZFN3VtZ0szSVky?=
 =?utf-8?B?Sk5rS2xETDV4VTVnTWlXcXhaWWY3YWZ3alVVa0c2V2lFdmtsMHRQYkYxdmNn?=
 =?utf-8?B?REg3T3laRG91SEtITVQwT3pGaG8zRW1hUVFXSEhEQ3RvUWx5bE5wMk5QZjFC?=
 =?utf-8?B?d1crY2xaTWc1dWZ0Sk92QVZXMTQwRVJPUWwrNkZrS0UxRXllZlI2UW1TVEV5?=
 =?utf-8?B?NzVkZDRsRWo3V2Q2QjE2dGg5ak9YQVhTNmlXVEN4UmxVOHd1RDlwVHRXVXNB?=
 =?utf-8?B?MEhXRlZxQ09YcUttL3NnTGVzbDdZQzJ4ZUVyNm9OSSs2ak95WnhTcFQrK1d5?=
 =?utf-8?B?M1ZOa0xrNlgzMThqWFlxWE9ySERYN2QrQXNJOGxmaTF1QWxBMmxNRW9qT3p5?=
 =?utf-8?B?SXlKOExSekFqQkxPMlR0dldoblJkRy8rc1FodEVIRTkwK0ttdE1KNUp5alpU?=
 =?utf-8?B?Y1FFcHdKNjBneW9iM0FWTmp4Z3ZuNGlxak5ZMHZ5STVSK3dYUkdjL2Zhb1lr?=
 =?utf-8?B?K2ZvYTQ0TmszU2VJRUxGdVI3dXZPTmpTM0Uxc2YvRDFOUkhQM1dGZUx5UmFS?=
 =?utf-8?B?U0ZNeSt3UnhJdG5UbUFHVjU1WXBQYmorK3JnZGNxQ3NwRnZaenROdXB2Yi9j?=
 =?utf-8?B?cXU1TmcyVm92ai9XUCs0Z3FKN3VWODN1TytEdUZWQmZieVpieWZrUzR4a3g0?=
 =?utf-8?B?V09HZE1DanBOSXBIYUtJeFFEeWlFUHhOc3cwVEJEODEzd3pFWDhINlc2NVBD?=
 =?utf-8?B?dDdYaHpjdXk1M0FMYkFFYWxZY3N6QnpTRjhqU203OGdXV1hhb3diZ2c0NHY2?=
 =?utf-8?B?VmpmYkNZL3VoUHN1Rk0wOVp5bzJtc1ErZ1pHa1BnTkhMOW4zY2kwWDRoZEhu?=
 =?utf-8?B?UmpJSWhSN2tVZ2NKekdyYllPVDBXSjFvbE9FWk5sZkhiRnJrZkJEOG9ycUc3?=
 =?utf-8?B?akpzMkl4Wnp2YkVWSzEzY3I3UjZTcHI2cytLanZ4MTZOM2xNT3pqZnZWaDc0?=
 =?utf-8?B?QlprVmlFZW1lbXdmYmFiQzRXRlFyMmJSUEhCZmRtemFkSkJDQnpLakU1NU9a?=
 =?utf-8?B?U21CeUNCamliVkVueFlRVStUUmZ1UENxRysyYlVudmRYTW1QY2tyK2NRaUVt?=
 =?utf-8?Q?eknhuyadQZgNVLCikMZsV11xp?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?Uy9zdXFRd2VnVDJQQjJpL3E2eStYZ0MyelYxY044eDBvdHZZaFVIOEk1R2hs?=
 =?utf-8?B?K0xiRU1RdjJpU2pUbTRNaUQvV3d4ZGJiOHZwZ240cGk5VzBjY0FyVWVkYU5Z?=
 =?utf-8?B?SHZRajF5MWJCR3c3RGROS2tvM0ZMdDN3bVdicjl5MENPWXRtZFRDcW01Nm8x?=
 =?utf-8?B?YjZEdUhwUW5Qbm5WbWo1blVQU01HakFNbU5xaThXVkpJV1hBMVd1Ym1FWXVa?=
 =?utf-8?B?MFgxSjJXZ3dhMFBOQVhPelJBSEsvYWFKb0pHNFd6cHc1OVhTV3RDNlBCdnoz?=
 =?utf-8?B?Yms4M1ZiVHZOeFZsOWswb3hzTU1KYVNVSjYzeTdhSEVLVThWMXF6Tmp6TVNU?=
 =?utf-8?B?RTFJR20vMjlxRkxPODludzhEUkxIMFJxZXIzU1FYUTdiRllGMUtrb1lwVFUx?=
 =?utf-8?B?TWlpU3AxUTQzSmdKNnR4Z241c1JZUU9SMzYvM2lvZjVqY1V5TFBvTnl0R3l5?=
 =?utf-8?B?MjdTRFEyOVgxcjVmSlZHcnNrQXNxeGdBQm5ZRFA0aDdHamFPR3hFa3JvNTUx?=
 =?utf-8?B?eE9wQ2dubks5S3NsN0d2Z2xlelVMZGQwZUVnNjAvN1V1SXJZVHFJZTdVVzB6?=
 =?utf-8?B?eWVvamszRDMrMU40TmhRcENUMHRUM1doTGo1STRkSTBwZkxpbDY1emRHcFlt?=
 =?utf-8?B?eWN2aHRQTVdPS0ttcTVFOVFjb2hmRjJHd0xodndHc0dkSVJwSFpjRWdzc0xm?=
 =?utf-8?B?MXdJbzI1dW45RGFqZUt1OVRWcUVMR1FSck43aHZhbGJ6WXZsNTBxR0h3Nyt3?=
 =?utf-8?B?b2V4dFZyWXlvMTdIWUZXSS93MGNCQ3p2R0xLclhPY0d6bWpHK1B1ejRwNVNV?=
 =?utf-8?B?Ym9ubVJXZGJPeTJJVjNIdG9kUWpyUVRHVkhxMWNXSmtIZW01bENLZnMzajk2?=
 =?utf-8?B?SzByYTVNRjgzd1J6aXY4bXRFQlY3Qjcya3N1UXVPYXUzWGhzY29EUDlkUlZN?=
 =?utf-8?B?cUd2K2VXbEoybzJCekhCWlgvVFJPYS9WZCtMenVERVZKRkNwOVNpdTRPb2t6?=
 =?utf-8?B?eFBscGYxTUNlZnBDSnNGYTZTdVJFU1BIZTE0WVQ5ekE1UnJJRHlWMzNUMlZ1?=
 =?utf-8?B?dXJDTEdvdERCMVFjTHA1ZjJ1YlIraWtqWnRTS0djUG1pQU5ycjZRbkpkdCsr?=
 =?utf-8?B?QW9LbFNvTWh6ZWlnVUxhT1QzTlZoYlVCWkQrallxbXZNSGRBZzlpRkRsV0Jy?=
 =?utf-8?B?NzFobDJXUUQ1b3FzTmt1cXA3TGlrVkUvZFIvN0puUVN5YUVXOGlOV3Y3MEZ6?=
 =?utf-8?Q?46LF0DF9ocxgvXR?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad3e31f1-bd02-4b1b-1501-08dbd0f6d43a
X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6535.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 22:57:55.0474
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l14ZHHD1F5wsFQKJR8Y0xARbT6s6sEPHuzrbwEhEI0eAz5gi//2pHMlB9Zfyv1YVTj/j+USv1KCE8OJrTwRl4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB7079
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-19_21,2023-10-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=836 suspectscore=0
 mlxscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2310170001 definitions=main-2310190194
X-Proofpoint-GUID: bdV3YFrx4B3-RoRiGoPODBiefyjW0dVp
X-Proofpoint-ORIG-GUID: bdV3YFrx4B3-RoRiGoPODBiefyjW0dVp
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 19 Oct 2023 15:58:18 -0700 (PDT)


On 10/17/2023 10:27 PM, Jason Wang wrote:
>>>    If we do
>>> this without a negotiation, IOTLB will not be clear but the Qemu will
>>> try to re-program the IOTLB after reset. Which will break?
>>>
>>> 1) stick the exact old behaviour with just one line of check
>> It's not just one line of check here, the old behavior emulation has to
>> be done as Eugenio illustrated in the other email.
> For vhost-vDPA it's just
>
> if (IOTLB_PERSIST is acked by userspace)
>      reset_map()
... and this reset_map in vhost_vdpa_cleanup can't be negotiable 
depending on IOTLB_PERSIST. Consider the case where user switches to 
virtio-vdpa after an older userspace using vhost-vdpa finished running. 
Even with buggy_virtio_reset_map in place it's unwarranted the vendor 
IOMMU can get back to the default state, e.g. ending with 1:1 
passthrough mapping. If not doing this unconditionally it will get a big 
chance to break userspace.

-Siwei

>
> For parent, it's somehow similar:
>
> during .reset()
>
> if (IOTLB_PERSIST is not acked by userspace)
>          reset_vendor_mappings()
>
> Anything I missed here?