Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp698347rdb; Thu, 19 Oct 2023 17:16:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFlP8ZYd4eeKwFDyw5lY6HDyF8Oo+HelDnuo/yU63fXtpSTwaACKxCu218Bqz8DkjhKNKnj X-Received: by 2002:a17:902:ed83:b0:1c5:9c73:c91c with SMTP id e3-20020a170902ed8300b001c59c73c91cmr455669plj.48.1697760973202; Thu, 19 Oct 2023 17:16:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697760973; cv=none; d=google.com; s=arc-20160816; b=g4O0qzMJIyNR56QqYewlWbWTz0bddud5Z9oSffrZjFSUagljzescuGt3JrtDjdRqOm MBmjxnK56IYV/2+qbbbihKrJ5bnQ8L89Vu/6wQtzWJ/PWoWg0lsnGT534Qt7Bh/Jc834 QozfrfUX4xsqYSEkRczsbQQ+z2P8P3IcR4800Sc4U8r+X87K8mrABEkKbsQUq4hqbcEU JTNHo7g81GMsTt24icNOGHsRKgwBwo0jD3A9wmorCO8824B2OxThNVwQsIwGgGhvAOoS xIM0FJlFSCA6ZcVKJdrWlqayGGfOzBfP8jAjy/FIbWQ5Nt1+pwl1PMHMpGCKlDZVETyF uMqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KCVrvRoy4SGPWE20sLca2ThSQwQI5qn6X68QgvLEZPo=; fh=xMWt1I4aL365R4xIisdiMEWHP6uuMIVMinH1A31oqA4=; b=V8IiKeU/CHhDY+U/afKJe4Dxv3na6meQyu3A0zvDLRWStVVU106DTXv2PAHfWf6A1a GIBa6X0pm0lPFUE92necCbpPbzDZmC4ykBQnJaUROH4EdKq0Yf42wHCO9MQ3uOA3eY1Z Bt1a40sxYUoQMxf28dhtO1D3VdWTThtzYwy1LAfxfl/vZASQuFfk/2msSmi1Hf+yge9x hgVkRbaeRjZnPwIOjYHkVqomFd9H96M1kQ7e83tDe9FqpA2h2V9ISqm9zrCn3ue152xr aMsy2aA83czjhPBg7eIFMO0VBfR+SH+Riwpd+8vAjZvO9tYW97QoZnQG1s+a1+t6i4Fw BNGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Z8c2oT9A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id p8-20020a1709026b8800b001c3845d008csi529679plk.424.2023.10.19.17.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 17:16:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Z8c2oT9A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 23CF082CFA7B; Thu, 19 Oct 2023 17:16:11 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346767AbjJTAQB (ORCPT + 99 others); Thu, 19 Oct 2023 20:16:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346755AbjJTAP7 (ORCPT ); Thu, 19 Oct 2023 20:15:59 -0400 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 418CC137 for ; Thu, 19 Oct 2023 17:15:57 -0700 (PDT) Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-6ce2cc39d12so190033a34.1 for ; Thu, 19 Oct 2023 17:15:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1697760956; x=1698365756; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KCVrvRoy4SGPWE20sLca2ThSQwQI5qn6X68QgvLEZPo=; b=Z8c2oT9ABdXS4JFpoFEZXMc5FLveIg5FD1kmw/RtiibToeWIBu5R53AjQYfm7xMfap uDQPfXMeufg3Z7xV1ZfPji8+K3NFQsuMz6tFzL8Nhey0UkkLOd9iMnBVeiTCcEpyu/IX AQS2Bo628GnAj+2mDbiL0d8lDG/zDwg41Ca+Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697760956; x=1698365756; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KCVrvRoy4SGPWE20sLca2ThSQwQI5qn6X68QgvLEZPo=; b=dKhPnhdbc8k/WSrQCTJj5JBSzmS5Q4S49HZimD3MC30ZpHdc5rbbevjgvGZYv3PLeW sqtEUKe+1+q7T77oI8WB2YScFZWGr9X8FBiyiOTZXYyMVLsV41TqBuoWGIr+KD4WW39G 3jpEWIv8QX7yMxi7iZaXuCp4ShFz+l0sel665J3cojtfvEBCVcjeukTISNeTUUWraNfE 4LH071pgCrxy3tXl844CghlfveO7TJtyIVds2cgGbQezz+7mGyJYjWx617J03FZDWU23 E7/++WT6ePfGsV4WWkILxFXHufKT6B1dyYB1IhJLe/L3VHcELpLS2HeKI3gqpEhOdbQh 4WyQ== X-Gm-Message-State: AOJu0YyFhF2hwP9uym4f6kC4cdLP82TNzE2EGG6irdVXiFtNcK+xutPq bAAR+7gS8pLYXGs5bkdy0qP/SQ== X-Received: by 2002:a05:6830:2b23:b0:6be:fe1e:c13 with SMTP id l35-20020a0568302b2300b006befe1e0c13mr503343otv.0.1697760956577; Thu, 19 Oct 2023 17:15:56 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id x11-20020aa78f0b000000b00690fe1c928csm351482pfr.147.2023.10.19.17.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 17:15:55 -0700 (PDT) Date: Thu, 19 Oct 2023 17:15:55 -0700 From: Kees Cook To: Stephan Gerhold Cc: Justin Stitt , Loic Poulain , Sergey Ryazanov , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] net: wwan: replace deprecated strncpy with strscpy_pad Message-ID: <202310191715.5436893DD0@keescook> References: <20231018-strncpy-drivers-net-wwan-rpmsg_wwan_ctrl-c-v1-1-4e343270373a@google.com> <202310182232.A569D262@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 19 Oct 2023 17:16:11 -0700 (PDT) On Thu, Oct 19, 2023 at 03:39:10PM +0200, Stephan Gerhold wrote: > Hm, strscpy_pad() is neither a typical compiler builtin nor an inline > function, so my naive assumption would be that this could only be > optimized away with LTO? Oops, yes, my mistake. I'm too used to the other fortified helpers that are inlined... -- Kees Cook