Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp701198rdb; Thu, 19 Oct 2023 17:22:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6NdGEFwDC0gve8jsQ64vPuhVKolwakWKlk8jv6pd6KI0r2krv6eNzTAthVbC3eSuodlyp X-Received: by 2002:a17:90b:4f4a:b0:27d:1862:a494 with SMTP id pj10-20020a17090b4f4a00b0027d1862a494mr458973pjb.11.1697761353376; Thu, 19 Oct 2023 17:22:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697761353; cv=none; d=google.com; s=arc-20160816; b=lLZQCtADhphMkygyl/dIUXFpoULrIbC9XCsj2+w7Zb7oCyapv8863qY+4UsW8JHXhl zE89gPW8+RYcVK2kazCFHm9IE6aMRHvMEtW+YMfDrPeTttY5ukW+TRFMYOFbX/uj9fE/ nSsAxCHNfhFIvPHUCsvObTZAU5UKeF6+Ct0d73huw7W2kjkNoNF2aulSkhFlFEG74Qgc M6RTAPlvafNfqQ2xzIBVsarIZ51U/M7zqdyG3dx9RBL6RmeLgoVMOww1jayzjVE2f3AD NCuKkBFLDEDqEbpyRtE9yG5nF20aBO3YsaO4IEXW+rqwuCxhwDP+7kfmM0cz6+qGzuNT QhfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8O1DQaljt+H62I0tLGc0kqUm5sOIzb3IYEn38CgT4Vc=; fh=lQPz00wFSeO4G89aMX+/uChzF40oY3Jruae+kFOSbsU=; b=oykI9WK2saHbqleT8RUF7rIZNcfGDi/OKMU+O1jTOzYB50Ax6WDGgau7dzNKUlMmD3 1x4ygcBTF6zZ8gOKJ3SoY45I6y6/46S4VCBBsv48z71h4ptuGhP1QiemN9aRfs/gP930 4DNOd7rLxjaCc9yIrEeYW6Dh8JqstB/AgMHndr0RnRMSNiB00bnlfI0r3GwKZ/ewRmnm KgzSpmEyfK0aBvQhO4AniKoEcRCZbtWfcfWvFdgTYpdF4kGVvJB1H1gQgnYQunsecmnJ s5Kb5JIkm2bIUlx8LhB4ALKr9IlitZVxcAUYqLtwJz1lWBhvyx+YRLBaUf/wac56zq1V 8Izg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="bFFR6l6/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id t13-20020a17090ad50d00b0027927b9debcsi3220846pju.60.2023.10.19.17.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 17:22:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="bFFR6l6/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 77535836D61D; Thu, 19 Oct 2023 17:22:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346767AbjJTAWY (ORCPT + 99 others); Thu, 19 Oct 2023 20:22:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346748AbjJTAWY (ORCPT ); Thu, 19 Oct 2023 20:22:24 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94543A3 for ; Thu, 19 Oct 2023 17:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697761297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8O1DQaljt+H62I0tLGc0kqUm5sOIzb3IYEn38CgT4Vc=; b=bFFR6l6/71XRV8m8Yd+OqjxPUCEU6pNEoLWI8ts38JxlFY/bDTgHvXUSmTERQXds8hhfAz jzzkG7xUvvrDSg34VfBciB4GL7/UBbFFQJn7H+E6Db1Qaxf+WPWBhtKXBUXF5eLlY1VsK/ B1CIdk5G89Rblgh82j9ouz/ICFOEz2s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-9-bzvGtZerN-G9XP76KmwirQ-1; Thu, 19 Oct 2023 20:21:32 -0400 X-MC-Unique: bzvGtZerN-G9XP76KmwirQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 33D3E87A9FD; Fri, 20 Oct 2023 00:21:31 +0000 (UTC) Received: from localhost (unknown [10.72.112.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4AC74111D794; Fri, 20 Oct 2023 00:21:29 +0000 (UTC) Date: Fri, 20 Oct 2023 08:21:26 +0800 From: Baoquan He To: Andrew Morton Cc: Dan Carpenter , Philip Li , oe-kbuild@lists.linux.dev, Lorenzo Stoakes , lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Linux Memory Management List Subject: Re: mm/vmalloc.c:3689 vread_iter() error: we previously assumed 'vm' could be null (see line 3667) Message-ID: References: <89caf59a-d3b9-409d-b1ae-9e370cb9ee7d@kadam.mountain> <20231018085248.6f3f36101cbdfe0990c8b467@linux-foundation.org> <20231019095030.7a1f3c93bc18511f52524aa8@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231019095030.7a1f3c93bc18511f52524aa8@linux-foundation.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 19 Oct 2023 17:22:31 -0700 (PDT) On 10/19/23 at 09:50am, Andrew Morton wrote: > On Thu, 19 Oct 2023 10:28:21 +0800 Baoquan He wrote: > > > I think this is not a real runtime bug. The only chance it can hapen is > > when (flags == VMAP_BLOCK) is true. That has been warned and could never > > happen. I updated patch log and paste v2 here. > > Thanks, I updated the changelog in-place. Thanks, Andrew.