Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Thu, 19 Oct 2023 20:28:27 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     miquel.raynal@bootlin.com
Cc:     alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
        imx@lists.linux.dev, joe@perches.com,
        linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/6] i3c: master: svc: fix SDA keep low when polling
 IBIWON timeout happen
Message-ID: <ZTHJq+9OKHVRaXGW@lizhi-Precision-Tower-5810>
References: <20231019222725.3598022-1-Frank.Li@nxp.com>
 <20231019222725.3598022-6-Frank.Li@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231019222725.3598022-6-Frank.Li@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TzazHxC5b4RNrSF8xVcMDXngaJ2ANuh8rTWGzW9izZh54PI/bMO5dUuSt6W0?=
 =?us-ascii?Q?KjTm0ZENNPDcEEx1IThIjm66W4S0wdz9dQ0B3c2RMZC4CK1M8fiwvRoWqplm?=
 =?us-ascii?Q?vWzui3MN/dWsq8O0F91/z1hHgD6ylyfYY6r8rgtrIOWH9EMKbYp3PhEIr5Y5?=
 =?us-ascii?Q?hY1IuViJorPAKnk/ZUxj82dr9YaAFbpZALsd2VTvRqPLg3LLuBooUpy0wr8C?=
 =?us-ascii?Q?n+w6GLfiw+uNq6js0XAIuuOQddc5DXdD44QFsojZYEDW+aH2EUKfT0t3fMZI?=
 =?us-ascii?Q?+mL4kQoEyNi4w5p572RbnYu/DRDGeotHNndscUriLZP/uSk02eaAsldLcOks?=
 =?us-ascii?Q?bP3VO2Ih8KJEX8c9J7R8uPX1mvWB5PoBfG9CdWuidWNt57bkOwJ3cMVRZ2d5?=
 =?us-ascii?Q?bc27nurFUP0G5rh9enCL18It+vKd2MFkMCU/BRqLPaL8je9upfv/osPUCLnm?=
 =?us-ascii?Q?tP3ozs3neSvtj0Bu42SCRIKfMFGq4S4mxisxWapKRg+zC1ipAf057iDKu9sa?=
 =?us-ascii?Q?J1m+NRXFuuvzcGohgc0X1+9vBR0+8mlgHInUqEjYUFIqPIefdJnKCztEoKEq?=
 =?us-ascii?Q?dVMnBJfry+VZ3UkKGY6gCD6LBDL3dp2LSuBiM7tEioGF+Gykg1Rlm+bark02?=
 =?us-ascii?Q?ljS5UYm3v5Ss6YrdMegv82SlUv4oWDlLKkItfoOWJfeCBjqefdi0j5C+GT3H?=
 =?us-ascii?Q?ZTxwJrAnvv1lvb8ApvIdEY8ZOPsvqTE5/LeuY2AzRwpK+e4aLDTJ8rhThsr3?=
 =?us-ascii?Q?gkucZcysGpgQgp/hKrlcH+i+Vbs2sZhFa7y21fCuHwgYaHMygtlU6cKAz0Gb?=
 =?us-ascii?Q?/nEMQ9VfIgJNBrEG1TCzub25XNJtFyv3J9r0x0xHnaocUE3PagXLQ08e2rMR?=
 =?us-ascii?Q?9qxlg7hQtcCi3EAAP0JMnP8x8BU9FOI0KmhqtE0Fa59rYNucc/OjTV/J+CpV?=
 =?us-ascii?Q?0C20Q9+0fmAiwHrDthFThdEUOJcS5pAOqssGfz2sNusl/jr8UNCxLc6yKjcH?=
 =?us-ascii?Q?lMeAxe0SkWLYqSj5mYj+I2kYx9SsrZ0AGEioyVxs2n15fgPQu2Wqjm5A/cC2?=
 =?us-ascii?Q?wCk/4kRKAZ6zDX4nPOcTCJ6AByz//eMxjhlvEmFg5Ttnl3MDvn/o1OvjvT2I?=
 =?us-ascii?Q?ziwQB5EJFcYeTn2Bek/qfC0VKSjzHAInPeJ2T+D6p3hXAB7B0FJxr5j8/1dj?=
 =?us-ascii?Q?rxB31tmQUVt9S8DO957FgMMZNUk1qIty9TwRybFDLcSSnmlfP44eLrgOfDcb?=
 =?us-ascii?Q?0507STfa8mTli0JfrzbPn17X9V63kJtp7cMWirbgLlMsr5axxlcXUW9UnCX+?=
 =?us-ascii?Q?Xz3ZmVnn6wDVgtEdd/MjhIH8v815ryr2Ma2pKXOSlVO6rfaBsewi/ay62Xs6?=
 =?us-ascii?Q?s2qcZJD2ym1uFP457KvYaB1LvlQDAE14/KeNrGBeJs9zzfr4QPbc+z74uFDC?=
 =?us-ascii?Q?vOLu0c6tfO/TZiF5p/aK05bNhv89vr84i2Btv2s/n0V/AgoUw1tb1KggvnI5?=
 =?us-ascii?Q?O+8AoBLYwoT+8WP4dsBUWXk8/icg6IT0LCKWUxHF7KsFTkt+MBU+RBbbXXcm?=
 =?us-ascii?Q?j8g45Ud0k1JU6A9n7PB7H9+6JGVvBdq03DhNZlev?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d7563ee-e665-454e-fe96-08dbd1037e75
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 00:28:34.1301
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WqpGvkBJfk96WEq4ORCoMWtN6rUV+be1Es+M1tNKFCyDh8cvfIG4bJOsRr84xwZGta4CxaOUKr6HRQHFz4uDkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7528
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 19 Oct 2023 17:28:45 -0700 (PDT)

On Thu, Oct 19, 2023 at 06:27:24PM -0400, Frank Li wrote:
> Upon IBIWON timeout, the SDA line will always be kept low if we don't emit
> a stop. Calling svc_i3c_master_emit_stop() there will let the bus return to
> idle state.
> 
> Call svc_i3c_master_emit_stop() to let i3c bus come back to idle statue
> when IBIWON timeout happen.

I forget delete this line. will remove it at next version.

Frank.

> 
> Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
> Cc: stable@vger.kernel.org
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> 
> Notes:
>     Change from v2 to v3
>     - Update commit message and add review tag
>     
>     Change from v1 to v2
>     - Update commite message
>     
>     Change from v1 to v2
>     - Update commite message
> 
>  drivers/i3c/master/svc-i3c-master.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index b113460f059c3..1a57fdebaa26d 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -404,6 +404,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work)
>  					 SVC_I3C_MSTATUS_IBIWON(val), 0, 1000);
>  	if (ret) {
>  		dev_err(master->dev, "Timeout when polling for IBIWON\n");
> +		svc_i3c_master_emit_stop(master);
>  		goto reenable_ibis;
>  	}
>  
> -- 
> 2.34.1
>