Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Thu, 19 Oct 2023 18:02:06 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     "Wilczynski, Michal" <michal.wilczynski@intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        <nvdimm@lists.linux.dev>, <linux-acpi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v1 1/1] ACPI: NFIT: Switch to use
 acpi_evaluate_dsm_typed()
Message-ID: <6531d18eb13c4_7258329435@dwillia2-xfh.jf.intel.com.notmuch>
References: <20231002135458.2603293-1-andriy.shevchenko@linux.intel.com>
 <ec5029b0-553c-4a6c-b2a9-ef9943e553dc@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ec5029b0-553c-4a6c-b2a9-ef9943e553dc@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Xn4mfQGSA6anxwzX0usu33onnMDYA8R/ClGh3rWb/2vebZQsaEDic5g6R6ny?=
 =?us-ascii?Q?Rvqvx8uCxbfCXRSf+WrXUb7HgTcYPQw4RoUCRbOtBRb2BLgYPB6cLwW9PMG6?=
 =?us-ascii?Q?5dIohQ8BFexrT0FPQ07iZ/ncYkmkkbWCBqOSKGej3uXhI+0Oz5TtG7VysSyg?=
 =?us-ascii?Q?EXgqnrkMhM1LZ74NwSisDXXyfVmCHQ2YEtNXIkj/fXJo7MgVFyuMJRwjnU+9?=
 =?us-ascii?Q?Q4JktaSwXDlcR0/R8o1r0m24FT3TjRnOZUAuHedRTIQtd1WhNNPWn8p/iBrA?=
 =?us-ascii?Q?+Efh9Vz50bHmN/p5L5RwHRYzoLZkoygKHCmI/VNfAPvydW3PgBhNk1N0A/PA?=
 =?us-ascii?Q?Bq4aNCmK/dAtXBC1ILyi6T5SskgxeGw/BxJETxF1q6vkaU228XdM8xVG3E7r?=
 =?us-ascii?Q?OJDVtRRjHDyTXyQ3iHv/AF1dGBtxFh4t4mlg3WoZMyzVZMWgopUiB0dJMS4p?=
 =?us-ascii?Q?X77E5sv2n+JKk4JNgF7aZEA/rK90B5IG3Sv9l5BFn28n5Ij8blNKvC0bQzkU?=
 =?us-ascii?Q?mAGrLkfxNx7tDYcc29V0vnP+ILpjYqXSOqFGSqGg8aGxfzHxVwpnzbQV+Rcq?=
 =?us-ascii?Q?Qmiu88JKOB7OOzbQ3XEycJUEfAkTCOu4khr99CrMgoTntaGDhKVa/xCcSQaS?=
 =?us-ascii?Q?TdPImOohOrLmayGR0V9VM3Lo0SGZhp6RnT8BlSGI3EO8ilE72aDNsENbpWXx?=
 =?us-ascii?Q?hyiHUioeq5Z0UlZuR3sqnfzOLLyHMg4csskRBwoZODaXULiCWRTBAgF1iu6Q?=
 =?us-ascii?Q?MAKIQxH3c3KdF2Xi4LQNE3SktkCQPH7ZgEsGgw7Q7DDW2Hjh4hqJsl3hnUCL?=
 =?us-ascii?Q?f7HmznbovcDtS7eG/f0Qzm32IbBZBcqMV+yiqhc06c2gYv5/BDy8ehH/PpqV?=
 =?us-ascii?Q?Azdt3VV7qyPjrFasYcxemW5MKC1pdmr4qg74hKf5GDcxP33PhJaCJvDlEuO+?=
 =?us-ascii?Q?ygksvtD+jgIby0C2+AL723955QiA2oZ8C+SlFX1aK7HUZ/CUtz7rWxFKVQM4?=
 =?us-ascii?Q?ePHdifCsFoFb4k/YGuW2bCIqcCJ8m7X3hJ301Bp4ZGOE5Qd0slq88a7lZs6R?=
 =?us-ascii?Q?kW+WbSniBt3J9zR1nh3JpLGd2E9YcB0NG2+UCsdwsyfH7ByxqiEBMFqb/shf?=
 =?us-ascii?Q?HVx4McL3gRV/49cXlIho4QD4fz7TndGPm/MyLQm7Ph4MeqTye0N+rtQ11Azk?=
 =?us-ascii?Q?YGscGsk8fzXp26j54z/z/jH+vN/Kwql8NSzeR/tx55YZtg+88hdqzArzWgj9?=
 =?us-ascii?Q?4fDqDJQbfXdD6V1tjuejeQeNMjMY+3EL2k7GB3Ae52QuVDawa2D3etGxfQJR?=
 =?us-ascii?Q?ivDSwzK7u7HdjS1BeRoeU1Kj/rDpRvPuFKTRjCxQDs57iTmf2h2DfPXjsTsL?=
 =?us-ascii?Q?SwJS//WZzes2GSBP47h2cwU2JAEBwq3KMiQYvUZlH5h05Nmt1WyfpUi4UFdZ?=
 =?us-ascii?Q?I/EFYO6JchOZ455K6VzzUw8mdjl3u4na/jD/UUtdR270kG5Gl9RYBdzT9RFI?=
 =?us-ascii?Q?JV+Ju5lNBAWRa/1SUCpcQWYo69oVS5zfLgbbOcHo6woYNv5NBrWJFyxCC6tz?=
 =?us-ascii?Q?74Rhd2sTCKOwoiUgEKLVDqETFADvriL1U296c/Q7KQjkIwnwQl1/qwKx9Ok9?=
 =?us-ascii?Q?dg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 75f29c64-1d6f-4676-6113-08dbd1082f5b
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 01:02:08.9753
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m2Nxs8+yMVWABzHfVAy0Z66eCGmiEsx+HdQGt3o9TdTb1OL/RW9SeqvPxz04Z9ihItJpCSdBUgsDMsRZ58td4k3o01Djgdw3Jn55VxOova0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6263
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 19 Oct 2023 18:02:52 -0700 (PDT)

Wilczynski, Michal wrote:
> 
> 
> On 10/2/2023 3:54 PM, Andy Shevchenko wrote:
> > The acpi_evaluate_dsm_typed() provides a way to check the type of the
> > object evaluated by _DSM call. Use it instead of open coded variant.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/acpi/nfit/core.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> > index f96bf32cd368..280da408c02c 100644
> > --- a/drivers/acpi/nfit/core.c
> > +++ b/drivers/acpi/nfit/core.c
> > @@ -1737,9 +1737,8 @@ __weak void nfit_intel_shutdown_status(struct nfit_mem *nfit_mem)
> >  	if ((nfit_mem->dsm_mask & (1 << func)) == 0)
> >  		return;
> >  
> > -	out_obj = acpi_evaluate_dsm(handle, guid, revid, func, &in_obj);
> > -	if (!out_obj || out_obj->type != ACPI_TYPE_BUFFER
> > -			|| out_obj->buffer.length < sizeof(smart)) {
> > +	out_obj = acpi_evaluate_dsm_typed(handle, guid, revid, func, &in_obj, ACPI_TYPE_BUFFER);
> 
> This line is 90 characters long, wouldn't it be better to split it ?

100 characters is allowed these days.

> > +	if (!out_obj || out_obj->buffer.length < sizeof(smart)) {
> >  		dev_dbg(dev->parent, "%s: failed to retrieve initial health\n",
> >  				dev_name(dev));
> 
> While at it maybe fix alignment ? :-)

Life is too short to fiddle with indentation. For old code leave it
alone, for new code just use clang-format.