Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Fri, 20 Oct 2023 10:38:38 +0800
From:   Xu Yilun <yilun.xu@linux.intel.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Marco Pagani <marpagan@redhat.com>,
        Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
        Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
        linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: disable KUnit test suites when module support is
 enabled
Message-ID: <ZTHoLv4Ttvz4++H/@yilunxu-OptiPlex-7050>
References: <20231018163814.100803-1-marpagan@redhat.com>
 <ZTFBi7vfmEpR9TB0@yilunxu-OptiPlex-7050>
 <2023101924-hunk-conjuror-2d35@gregkh>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2023101924-hunk-conjuror-2d35@gregkh>
Precedence: bulk

On Thu, Oct 19, 2023 at 07:33:08PM +0200, Greg KH wrote:
> On Thu, Oct 19, 2023 at 10:47:39PM +0800, Xu Yilun wrote:
> > On Wed, Oct 18, 2023 at 06:38:13PM +0200, Marco Pagani wrote:
> > > The fpga core currently assumes that all manager, bridge, and region
> > > devices have a parent device associated with a driver that can be used
> > > to take the module's refcount. This behavior causes the fpga test suites
> > > to crash with a null-ptr-deref since parent fake devices do not have a
> > > driver. This patch disables all fpga KUnit test suites when loadable
> > > module support is enabled until the fpga core is fixed. Test suites
> > > can still be run using the KUnit default UML kernel.
> > > 
> > > Signed-off-by: Marco Pagani <marpagan@redhat.com>
> > 
> > LGTM, I've tested on my machine.
> > 
> > Acked-by: Xu Yilun <yilun.xu@intel.com>
> > 
> > Hi Greg:
> > 
> > Could you help review and pull it in for 6.6-final if it's OK.
> > 
> > https://lore.kernel.org/linux-fpga/2023101825-ligament-undergrad-cc4d@gregkh/
> 
> Needs a "Fixes:" tag please, you can provide it here in this email
> thread and b4 will pick it up automatically for me.

Fixes: ccbc1c302115 ("fpga: add an initial KUnit suite for the FPGA Manager")

Thanks,
Yilun

> 
> thanks,
> 
> greg k-h