Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <93abbbfb-27fb-4f65-883c-a6aa38c61fa0@intel.com>
Date:   Fri, 20 Oct 2023 10:54:56 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm: migrate: record the mlocked page status to remove
 unnecessary lru drain
Content-Language: en-US
To:     Baolin Wang <baolin.wang@linux.alibaba.com>,
        "Huang, Ying" <ying.huang@intel.com>, Zi Yan <ziy@nvidia.com>,
        Yosry Ahmed <yosryahmed@google.com>
CC:     <akpm@linux-foundation.org>, <mgorman@techsingularity.net>,
        <hughd@google.com>, <vbabka@suse.cz>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
References: <64899ad0bb78cde88b52abed1a5a5abbc9919998.1697632761.git.baolin.wang@linux.alibaba.com>
 <1F80D8DA-8BB5-4C7E-BC2F-030BF52931F7@nvidia.com>
 <87il73uos1.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <2ad721be-b81e-d279-0055-f995a8cfe180@linux.alibaba.com>
 <27f40fc2-806a-52a9-3697-4ed9cd7081d4@intel.com>
 <e8099116-6f78-cb4a-5036-1d7e38b63e52@linux.alibaba.com>
 <fd389af5-d949-43dc-9a35-d53112fe4a60@intel.com>
 <05d596f3-c59c-76c3-495e-09f8573cf438@linux.alibaba.com>
 <b9042fcb-05df-460f-87b8-4d7a04d3bd5e@intel.com>
 <e84f8c2d-6264-f2a3-3737-17d48a0251f8@linux.alibaba.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <e84f8c2d-6264-f2a3-3737-17d48a0251f8@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2ZRT0hySithOTN0WUl3MHhJVWRKNXRITmw0a3VaSEJJa25RN0szL2pPRnBq?=
 =?utf-8?B?bDNFNm4ybXpTbFpwaDVjcm5ua1orMmVJeEl6YThiQ2Y1bWdIQVN4Rit2SWhS?=
 =?utf-8?B?ejQzWFkrRm5PRFFvM3hGajQyRUwyZFVKbFZRaFRiQ2wvOFB3T21rcDIraGtU?=
 =?utf-8?B?MzdIcDdmWFgrb2NnTGpDVk1VRlUxbTM5QUR4QWw4UERMOVIyZHAyZE9aT3Q2?=
 =?utf-8?B?V0RpOEprM2ZDS3pPM1I1WHB3blFJUENVbnYzZ1RaTVpNYmwwQi9OeFBvYTZM?=
 =?utf-8?B?Y1hWUG1qWnYyWCtNV1RqZXBXY0pqQy92QTNVbmxlcEllQzFsYWIvekV0QzdM?=
 =?utf-8?B?bXJIdnhXYmprdWllTXFzeEo4dm5PVEg1NUhmWjhlREowUnM3djE3RmFaaWpV?=
 =?utf-8?B?dVBSS056UGlOZVViR2RJZGE5VUgwUmIxT0tWNjdHbTFCdUxreFhjb1BsajhD?=
 =?utf-8?B?TnlsZmdTMnhTcmNmSGQwSjlXUGVvdjNqM2NZSHROVjhLMU1qbVhGZmgzb3FR?=
 =?utf-8?B?Mms2NGR1MTZQdzF0YUNRUE5Wd1YzckR5MGdmWERDeFNUQ255RmlJdUh5UDhL?=
 =?utf-8?B?VnlyK0MrcTJzS1F5NEFxVER2cDdIMmxuc3p0cUJzd2hUOXAvakJLVk1KK1dC?=
 =?utf-8?B?a0VpbkZpWkh6VVRmRGlDNE1JRTM5NEE3THR1V3pQZDRYTVlsTUxIS2Q1Mmxr?=
 =?utf-8?B?czRNemNpSFBITWd5WVJJb3FacVNkREIxY0s0cy82RkpYb2NaUWZhR1ZVWDFa?=
 =?utf-8?B?QjY1U0VQQnN5RUloRHZNc012dCtyUjdJMlJBc2FPbFpaeDFiMmVpRzVVc1ZG?=
 =?utf-8?B?WFlwREhUcGJxZkJaRlBtck9XUUZXZ0UvRkFldjVEWDAzT1QrdFloTjdId2lz?=
 =?utf-8?B?MGcwSkZQWjY2ZFp5aGtsY2Y5eEY5SUpjTUF4aTVVVGRmZW9UUHRJV2VKM1Ni?=
 =?utf-8?B?VzBnaUFpb2ludWxOa3I1WkZ2eTE5Um55aENmVWlRTSt5RWZPZ0lSODRBVUgz?=
 =?utf-8?B?bldQTldVY0Q4L2dJTWVUOGpJTkRDd2dhMDYySEEydndmYW94UUs1U2NaYkIx?=
 =?utf-8?B?WmlMaFpKMlhEelVtMkxPUzEwUnNRbW41QlNLTkNrSUJrV1VIZmJQT2xjL3RN?=
 =?utf-8?B?ekg0S2tBaXkzZGNGTkdWUlIxYzFyK1duMUlMaVAzQnZzNEMrbWMzbUJVU2hE?=
 =?utf-8?B?c0E0SGxRTzBhK2plQ1BsOHBtL3hKZXNoZGtaU2dKMnhQZEdOQWxqNTdzQ3kw?=
 =?utf-8?B?SkNETS84NlJjYkY0akV4VFAxWll0cExpK0tzOW9xK3c2eHlZdHhmdFZmeld3?=
 =?utf-8?B?WUZqWVJvR21nYVFKM1prV1FnVDhrdG0vVXZ2ZE5OL3NUMkVrRCtsZ2Z0THJt?=
 =?utf-8?B?dkJEWFgzcjRDNDhVenM2TjVkdmdYQll0b3psWC8yd2tsVnI2TFoxL0h3NUlq?=
 =?utf-8?B?Rnc1U3hScjk5dVE2R2NMejNmcUpkd2lOQldoYWxvT1F4ZnBOSjJRZlZTa2dK?=
 =?utf-8?B?QkZPVWlVbWU0MlZNUTZwcDVId01NTWtmamxURWltaXFsRDR2N01UTHdMc0tV?=
 =?utf-8?B?Zmg1SGZ2ejc1QnhlcEtTSktKTEVpM1BvZDI1UVZGSncyTTMrV2I4YkNGVlR4?=
 =?utf-8?B?cHVXVlBwMWhodUVSNVRxL21aTExwKzVQLzdQUFFaaTFFTkRsSk90WDA2eTgv?=
 =?utf-8?B?bkFqazJxUGxvY2RwN2t6QXR1eVVVaHJsQk9rOU01WDErUmZuZVZVM2pMbDR1?=
 =?utf-8?B?S05zcTl3d00yVTFobkpjbFUyVGJTc1JvWXN3UUk1eFNSODJsQmZxWWY0SHpF?=
 =?utf-8?B?UFJvQmZwTTlmMk00QTJncmtHVzdiV1FuVTFGWGtCMXFkaUo1ZGNiMlp2eGdi?=
 =?utf-8?B?SDVXUTk3cnRXckRoS1ZUTUpZNU9Ia3lwajdpN1cwSlh6M3hYRTVuZEUzY01X?=
 =?utf-8?B?UTFsdmh4MVR4UnRWQzNUVGJVcjMyS0x1bWI0STBuNU50cjVPRnF1aWQ3UTZ4?=
 =?utf-8?B?aEZISk1xNWJvaHNZZ1M5R05yb05qRTJ5ck9iVW9YYVlxeWhWeWtRMmd1MHpS?=
 =?utf-8?B?MFA0WnRqZXFGam5ZRkluQ0VqdHpscDl1V1VFVEllUFoxNklUVGNYWHpDbHE0?=
 =?utf-8?B?NVBvaUNMaElYY3RLY2JlSUV6bGZudFVLbUxRcXhKcjNyemVrcC9aRUZkWmtx?=
 =?utf-8?B?ckE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 179b17ba-9ab3-480f-e823-08dbd117f54d
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 02:55:03.6521
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VV1uqoSHikM5OcSQSyF67gSvXcalcSOAB0eJXiE46tUIHomrGNtMQau17KO0Jf/NLlSZzPnArAtMYF2BimE2dw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8383
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 19 Oct 2023 19:55:21 -0700 (PDT)


On 10/20/2023 10:45 AM, Baolin Wang wrote:
> 
> 
> On 10/20/2023 10:30 AM, Yin, Fengwei wrote:
>>
>>
>> On 10/20/2023 10:09 AM, Baolin Wang wrote:
>>>
>>>
>>> On 10/19/2023 8:07 PM, Yin, Fengwei wrote:
>>>>
>>>>
>>>> On 10/19/2023 4:51 PM, Baolin Wang wrote:
>>>>>
>>>>>
>>>>> On 10/19/2023 4:22 PM, Yin Fengwei wrote:
>>>>>> Hi Baolin,
>>>>>>
>>>>>> On 10/19/23 15:25, Baolin Wang wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 10/19/2023 2:09 PM, Huang, Ying wrote:
>>>>>>>> Zi Yan <ziy@nvidia.com> writes:
>>>>>>>>
>>>>>>>>> On 18 Oct 2023, at 9:04, Baolin Wang wrote:
>>>>>>>>>
>>>>>>>>>> When doing compaction, I found the lru_add_drain() is an obvious hotspot
>>>>>>>>>> when migrating pages. The distribution of this hotspot is as follows:
>>>>>>>>>>        - 18.75% compact_zone
>>>>>>>>>>           - 17.39% migrate_pages
>>>>>>>>>>              - 13.79% migrate_pages_batch
>>>>>>>>>>                 - 11.66% migrate_folio_move
>>>>>>>>>>                    - 7.02% lru_add_drain
>>>>>>>>>>                       + 7.02% lru_add_drain_cpu
>>>>>>>>>>                    + 3.00% move_to_new_folio
>>>>>>>>>>                      1.23% rmap_walk
>>>>>>>>>>                 + 1.92% migrate_folio_unmap
>>>>>>>>>>              + 3.20% migrate_pages_sync
>>>>>>>>>>           + 0.90% isolate_migratepages
>>>>>>>>>>
>>>>>>>>>> The lru_add_drain() was added by commit c3096e6782b7 ("mm/migrate:
>>>>>>>>>> __unmap_and_move() push good newpage to LRU") to drain the newpage to LRU
>>>>>>>>>> immediately, to help to build up the correct newpage->mlock_count in
>>>>>>>>>> remove_migration_ptes() for mlocked pages. However, if there are no mlocked
>>>>>>>>>> pages are migrating, then we can avoid this lru drain operation, especailly
>>>>>>>>>> for the heavy concurrent scenarios.
>>>>>>>>>
>>>>>>>>> lru_add_drain() is also used to drain pages out of folio_batch. Pages in folio_batch
>>>>>>>>> have an additional pin to prevent migration. See folio_get(folio); in folio_add_lru().
>>>>>>>>
>>>>>>>> lru_add_drain() is called after the page reference count checking in
>>>>>>>> move_to_new_folio().  So, I don't this is an issue.
>>>>>>>
>>>>>>> Agree. The purpose of adding lru_add_drain() is to address the 'mlock_count' issue for mlocked pages. Please see commit c3096e6782b7 and related comments. Moreover I haven't seen an increase in the number of page migration failures due to page reference count checking after this patch.
>>>>>>
>>>>>> I agree with your. My understanding also is that the lru_add_drain() is only needed
>>>>>> for mlocked folio to correct mlock_count. Like to hear the confirmation from Huge.
>>>>>>
>>>>>>
>>>>>> But I have question: why do we need use page_was_mlocked instead of check
>>>>>> folio_test_mlocked(src)? Does page migration clear the mlock flag? Thanks.
>>>>>
>>>>> Yes, please see the call trace: try_to_migrate_one() ---> page_remove_rmap() ---> munlock_vma_folio().
>>>>
>>>> Yes. This will clear mlock bit.
>>>>
>>>> What about set dst folio mlocked if source is before try_to_migrate_one()? And
>>>> then check whether dst folio is mlocked after? And need clear mlocked if migration
>>>> fails. I suppose the change is minor. Just a thought. Thanks.
>>>
>>> IMO, this will break the mlock related statistics in mlock_folio() when the remove_migration_pte() rebuilds the mlock status and mlock count.
>>>
>>> Another concern I can see is that, during the page migration, a concurrent munlock() can be called to clean the VM_LOCKED flags for the VMAs, so the remove_migration_pte() should not rebuild the mlock status and mlock count. But the dst folio's mlcoked status is still remained, which is wrong.
>>>
>>> So your suggested apporach seems not easy, and I think my patch is simple with re-using existing __migrate_folio_record() and __migrate_folio_extract() :)
>>
>> Can these concerns be addressed by clear dst mlocked after lru_add_drain() but before
>> remove_migration_pte()?
> 
> IMHO, that seems too hacky to me. I still prefer to rely on the migration process of the mlcock pages.

BTW, Yosry tried to address the overlap of field lru and mlock_count:
https://lore.kernel.org/lkml/20230618065719.1363271-1-yosryahmed@google.com/
But the lore doesn't group all the patches.


Regards
Yin, Fengwei