Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp764008rdb; Thu, 19 Oct 2023 20:29:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH5tFHje0J4hXMtQEcKD+jlYnTbRqecVNGVMsbVwA5xIRvkv27RZxAEi21b9wsa6JdNNBPA X-Received: by 2002:a05:6870:230e:b0:1c8:c2df:a927 with SMTP id w14-20020a056870230e00b001c8c2dfa927mr985798oao.53.1697772567516; Thu, 19 Oct 2023 20:29:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697772567; cv=none; d=google.com; s=arc-20160816; b=SVJ3codYaEgTSkqs875UgjAcGtowmcpMmMWx7o9eNTzv/yIIJ4qd4vGBRze0NHDkYa TXlNLU2JdJim/emomR/c902iGlsxGP1PSBWfPQBbHUmgV11KOFQUDazaeP/F/P46AGMN cfMmWzu37GNtPHSjt6FWQBU45ru1dsoMmy3k09TRmQrjHc5FoCl2Z8TKB0WJ4MdpzABN tZwr99b+55XuCLeLkoLYP5ehLWskbbSJQa6DrqslPjhpIlPbJ/hzvbnACayZPflKQtF6 DdZTwkfiNRLm2YbsfK+4BQDAyZ2k7r6bREiEDoqrHQhlg7FzKYq0us+PsXXRGM7Mt16C yMqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=o7uVj+BWSvci11+EmzgxZowQ4BFh6afGOeAd/iYFtNE=; fh=pk7jpUncC/oYY3P8aGEIppT3L2h/vHyw5+cFKny+Skk=; b=a8c/SE9SOuOP/iqjnm51QnMlU9nBZqKLFdG04WjR1iZK+AllGSP/5EAVrpJRTzAV6e geGrbsBM1bfqvAH0ExA83iwdGqwZdq71Ur/aI2lb4A+cTAg5LHrzFRi59esUN70SYV+q BLX0MQqwyvYYQMUO3qACJrVfwGfXPxSFMxEivvsc8Zb6R7YSl75yZcSu2+M4cpIJTwvp piJDH7ubdcffseBPz14PFYqRzja+r8yuyqPpaGDoSDVDxw1mTnXi9PoxprPiPP4PThyt KovRTPeBZoWjGd0Xyohbd1mhOze36jfJA8ih/i4qC4VMDBuw9kEjo95BMNpVf2eOPfir Tb/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=OVYJQjQN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id w15-20020a63934f000000b0056532a83c64si939004pgm.516.2023.10.19.20.29.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 20:29:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=OVYJQjQN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 8C6AB836CE57; Thu, 19 Oct 2023 20:29:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346901AbjJTD3T (ORCPT + 99 others); Thu, 19 Oct 2023 23:29:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346916AbjJTD3P (ORCPT ); Thu, 19 Oct 2023 23:29:15 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE711D45 for ; Thu, 19 Oct 2023 20:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=o7uVj+BWSvci11+EmzgxZowQ4BFh6afGOeAd/iYFtNE=; b=OVYJQjQN5amrALRJRDc+biqABr gqr5ViWVPUS/uQzT4vXazunLCY2fSGOsUP1jsSxf2TSxcfVFWEJzWOuUwdG+5P8FqpS/lMXiFJa0H 1KWrPg9zZG1/ARnkgdD3J+UIdHqXA7ZH5vnzxMPo3acAfgQjZQnmiMBd6+MrH3eSTqKqYcS5QBQVH aqLJp0Tuv86iKJWGCV/mq2YmndTYlS0WA20GMoCCfsESxHGTBbpdsiZxcpFremM8vGCDiZwqWtiNZ BHA4AZkrq8S8OpqjJnodOO5PefhhVir5d38fOeOi7mX3rOroUAR6rDStVisuPe4C3qrDAmEMZlbww sa9ojvRA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qtgCA-00AofD-1b; Fri, 20 Oct 2023 03:29:06 +0000 Date: Fri, 20 Oct 2023 04:29:06 +0100 From: Matthew Wilcox To: Zhiguo Jiang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH v2 2/2] mm:vmscan: the ref clean dirty folio skip unmap Message-ID: References: <20231019134211.329-1-justinjiang@vivo.com> <20231019134211.329-3-justinjiang@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231019134211.329-3-justinjiang@vivo.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 19 Oct 2023 20:29:25 -0700 (PDT) On Thu, Oct 19, 2023 at 09:42:11PM +0800, Zhiguo Jiang wrote: > +++ b/mm/vmscan.c > @@ -1225,7 +1225,10 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, > stat->nr_ref_keep += nr_pages; > goto keep_locked; > case FOLIOREF_RECLAIM: > + break; > case FOLIOREF_RECLAIM_CLEAN: > + if (dirty) > + goto activate_locked; Why activate_locked and not keep_locked?