Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <e38bf11a-9372-4302-8405-af44422d879e@vivo.com>
Date:   Fri, 20 Oct 2023 11:37:41 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] mm:vmscan: the ref clean dirty folio skip unmap
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
References: <20231019134211.329-1-justinjiang@vivo.com>
 <20231019134211.329-3-justinjiang@vivo.com>
 <ZTH0Aob4srLnnjCM@casper.infradead.org>
From:   zhiguojiang <justinjiang@vivo.com>
In-Reply-To: <ZTH0Aob4srLnnjCM@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFlOUXVQdFdKV2lnVVB2QzIrMmI4WDc2VXpyZkdOVmpzeUQwMDZLMk02MFNx?=
 =?utf-8?B?dW9HOHIyRHFqblBybE5xRkx2TnNRYmFBalpxa3NxbDZMakZJSnpkck1pUTZB?=
 =?utf-8?B?YllRUlF5V1hWQ0tHSnNaUXF6d1V4WDF6blZKRTQwMFpSL0xMSjI0V1JPR2p2?=
 =?utf-8?B?MVBYMlhFdUNEWER4OHJ5R1FVQzlIcXpMTzRHNHhVY2VEUGF6Nzl4d2NiUlU4?=
 =?utf-8?B?OVRFSWNUcmFic055NmFQVW5rU2pIM0NRR1ZzQlgybEFQMTV4YWVNelJaRUwx?=
 =?utf-8?B?dkloQjhZWXFEVmxlWGs5ckcyVURRbUR3NWd2N2Zic0EvdnNwTmtvUFFOMVRI?=
 =?utf-8?B?MVpGTlNORHE5WHBjVWtDNjM2L2tSUFBGb2NCQ1N4MjJHK1Q1NExkMjNRdHJZ?=
 =?utf-8?B?Rjdrd3FRUlcvcHIyd3hqRUZtbHRMT0F0bTFFVm5aa0VKTXVvN2xWR05GSXBK?=
 =?utf-8?B?QlljZktOMlBSTTAwckQ2OURySUxVU1dONUgya0FKYjhucjF5NnNwZVJoVHJE?=
 =?utf-8?B?c1BtUm55UlhyejJmSXg2WUU2Rm1SclBENms1MXFaR09jVUlzNjVJMFNGRkR4?=
 =?utf-8?B?dTJDNXVXTVIwMGN0ajFPLzRaNENoeDdXSGRRVWxBMHVuRGU3bllxS0lIWkd5?=
 =?utf-8?B?ZDFQMVBoak9Gb1lScmJ1aFdJM1p5RmZ2Qm5pcWVZaXRGNU12d2hiOGI2OS91?=
 =?utf-8?B?YzluYk9XQ082V1FhSHFFNndrVjdUT0tCZUdhQTJzam51SkUxcVAzN2I0TDdv?=
 =?utf-8?B?VHZ2S2QzdE1CaEtPeGVuMXc4UnRodVJZR2FoaU5DQXdhQzk0MzdJUHZCeWVp?=
 =?utf-8?B?dlNxNHFyY2F0QnkvZ21FK1hPTjZiaTM1MFNGWmt2RHZNeFNxUUNXVFlkOXRj?=
 =?utf-8?B?Nk1OWEU5WkE5OFVTeU5ubkNhcVczMTlKcWFiQ2hxSnZzUUZPbFBib3dGRGlR?=
 =?utf-8?B?ekN6UmZaeGg0cWJSWkhnbm5qUHNSL2RVQ3JyU2FzUU83KzNuQmc5Ti83UXNI?=
 =?utf-8?B?aTdEVkpLaEQySy80c0hVT2RtbnFSOVpFTXc4NTZKV2NneW1WQmxjdy9leURH?=
 =?utf-8?B?bnNDb1MxdDErRkFGNU1BZXh4bEFWNHY3am9JeXVweDgrYW9Ld2E0TDdXK0lq?=
 =?utf-8?B?TUY2U2RFcjhRNlpKTUtLVVBXSGgvblJ6UHpnU1BiUURneDRPVUxtM1dXYXpW?=
 =?utf-8?B?NDdXNWU3TDdINld1L1JwQ2J0Mll5OHFNZmtVdWxBUmg0aGJBUTljTTZUaElT?=
 =?utf-8?B?UUVUWWQrQWtNZy9LNVM4d1ZkR0pTbUhpRHpnU2ZHeFZ0T3pycGJTWmRqTTdW?=
 =?utf-8?B?amZUaW9pQVBVa1ZjTDdlWkxxVURnN3FkbWl0bFBkTFdrVE5JUGNhbnRzYktL?=
 =?utf-8?B?Umt4akNiNCtKSFgzRzFoNGd5TkN4NTdzSTU2T0tuR0Vaczg4OUlKRGUvd2hK?=
 =?utf-8?B?RC82eC9ycXdJRlNibXBiQVF4T3FqMlJheFpRcG02cWJxcWRXWk1iTjlHZFdv?=
 =?utf-8?B?SVlMbzhUNno0QVUwb0JHdEkrZk5EUHdBRWxKNWg0UmtXcEZNTUtmR0JnVFR2?=
 =?utf-8?B?RWxRR3ZqSDNoQWxEVGl3U0RibmFJSkpOL3dDRlRsaHdQZnRiWmhuR0hNa0g1?=
 =?utf-8?B?d1NwbW5QeEI2Zk9BMlV2akJHeUhKSC8xOExFcTdUczJyU3lmRTQ3MjlObGxX?=
 =?utf-8?B?eWhrSlAvcy8vYzdwUGd5cDFzbzNyLzNEMHpNUE9sV1V1RTR1NHlHa2NBekd4?=
 =?utf-8?B?d1JtS1pZQmhXZktFd0xhdlBIQlZnM3BxdUdkQ3dZem5iLzh5ZWE0dTFPam4z?=
 =?utf-8?B?akZpcXAvWkJTWnJ6bENzUWJUeVBkU2ZjYkJWSGlIcjhMRTVZMmkyZVdFSGR1?=
 =?utf-8?B?cFFUSi83bmV6bHdWMlczVlJFbE9xdFBrcTJHNEdnbXJ2eUNnTFIway9SSUhv?=
 =?utf-8?B?d2ordHM5L0Q3b3h0eHNCaThIZXQ0cDZKV2hYL1lJY3Yva3hUS2ZaaHlUTHBq?=
 =?utf-8?B?aGxJWkpWV2RiUk1GRHo0dnBrUmxDcGliVHo1SERWdFhRM21JWXVYbEthd0ZM?=
 =?utf-8?B?c2VZSmc3cWJjcGpRZmxjQ0RSOE9neUpQdmxCc2s1dzA3eXZtTzRubkxURlpz?=
 =?utf-8?Q?Ci0R6kzXcgT1jsHISrMBfKJDW?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0270a854-7002-4d9d-191d-08dbd11dec6f
X-MS-Exchange-CrossTenant-AuthSource: JH0PR06MB6849.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 03:37:45.5411
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aP0x2MrGZ0OiWqUsDdoxDnWjQfw7LU5PhwvpLdG+AIclY2OMirwVrmSvqf2MjayyFleFexK5oXi5QZTIBW4X8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5496
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 19 Oct 2023 20:38:02 -0700 (PDT)


在 2023/10/20 11:29, Matthew Wilcox 写道:
> On Thu, Oct 19, 2023 at 09:42:11PM +0800, Zhiguo Jiang wrote:
>> +++ b/mm/vmscan.c
>> @@ -1225,7 +1225,10 @@ static unsigned int shrink_folio_list(struct list_head *folio_list,
>>   			stat->nr_ref_keep += nr_pages;
>>   			goto keep_locked;
>>   		case FOLIOREF_RECLAIM:
>> +			break;
>>   		case FOLIOREF_RECLAIM_CLEAN:
>> +			if (dirty)
>> +				goto activate_locked;
> Why activate_locked and not keep_locked?
Hi,
This is  a mistake, should be keep_locked.