Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To:     ivecera <ivecera@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>,
        "Palczewski, Mateusz" <mateusz.palczewski@intel.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        open list <linux-kernel@vger.kernel.org>,
        "Eric Dumazet" <edumazet@google.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        Simon Horman <horms@kernel.org>,
        "Sylwester Dziedziuch" <sylwesterx.dziedziuch@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>
Subject: RE: [Intel-wired-lan] [PATCH net v2] i40e: Fix
 I40E_FLAG_VF_VLAN_PRUNING value
Thread-Topic: [Intel-wired-lan] [PATCH net v2] i40e: Fix
 I40E_FLAG_VF_VLAN_PRUNING value
Thread-Index: AQHaAqqjgu/2pPDrJUyJrMurdSSDBLBSKs/g
Date:   Fri, 20 Oct 2023 05:44:11 +0000
Message-ID: <BL0PR11MB31226A0095D6A906D12C6C31BDDBA@BL0PR11MB3122.namprd11.prod.outlook.com>
References: <20231019163721.1333370-1-ivecera@redhat.com>
In-Reply-To: <20231019163721.1333370-1-ivecera@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7jBDLROE8N8x7QO4l5AKMDIknDcUHsxd8maHMqt99wgc431qGs4wN2QLV2AQ?=
 =?us-ascii?Q?KxHPJjhUcewbwhBu3WH1B80A0rM/enILZrLvLNeXnlQ3dH8diyfMpYuwrM0e?=
 =?us-ascii?Q?I/kPWts4ADnBlDWjxbL5HvwzAYXDE929fqfc72inKzYztkPq8+a+ih8w4LUJ?=
 =?us-ascii?Q?ZbNi2iW1q+gaWJXvhR1mSW0b4LFF+ZocO5ToUQQ+kDggRBEsN+xVK5SZu8hA?=
 =?us-ascii?Q?dPWQvovrzkhiIGEbI6OGykkb8LdZ0BwO9ptPUygijNudKwo68iYa/YyNZoqw?=
 =?us-ascii?Q?iD5P7LpUREvaFSjQL0ndn6pYF36Cp0ddYdSKm7bjslFTvn0y0QC8VGSj0Lry?=
 =?us-ascii?Q?D36szQz01qVD6DZcAcbfnQFLYzYdQw4qnPbOYnQ8MgtCE0xC2crmOAziBaXE?=
 =?us-ascii?Q?m5sD9BKxzlQM5FO291nR+bKCGKqIN0/qVkGIsRrg1G7lfks1RMiiIA+fbcgz?=
 =?us-ascii?Q?fGFMwpLpf7BtnUSxsQA8VQEc8AJYOFOOB7H117D43D+p1GLwPoAEouqpbAUO?=
 =?us-ascii?Q?PN61WJbTHA/28xfanLemnxvU5rP/GOUPN7u/3QmPJKLXxgoP/Rkl9WCRl65O?=
 =?us-ascii?Q?YalOr1RvB85wk5Qjgmqre3816TavS1tKAR32eOUY2jDvndGofoioG9PUOVIV?=
 =?us-ascii?Q?wrd8VGm35hCLtGhO+MOAZ6qISfIn9t77DhBnq12dg5qYijlQVk+0If9vqVfK?=
 =?us-ascii?Q?xoZItvMax8LNi+Hcdxj/fM3SYjEjw2R2tnYSlMb3AIb/gCesWd1fZAcWDciC?=
 =?us-ascii?Q?h2bD2Hm6WonSWXl6PV90vXe6twc1cgi3AlQ2jLYx2c8Fsd1/1h0dnWxp2evu?=
 =?us-ascii?Q?vv75muG/S+ElwmEsUenx3Tac88kbryw7SR3UXcqZmcvJG6lZeUlNQlyndClU?=
 =?us-ascii?Q?vpywRzf9ejVuFvF0mDDN1MACRLLGIIJH69ykg5HEHM01bQ+uUr9tblvkRV3j?=
 =?us-ascii?Q?eYJsNYUG5bglUfZSAKfD3hKTku6hgQz66K1y6VxG2axbmPz2vs538YHismrY?=
 =?us-ascii?Q?2U92KAaM4k1VuFYcnm9QicUX1Ogl/VOqRi3b4p6sNgQgFrvnvOS4Ctpwe7OI?=
 =?us-ascii?Q?CNTSnoRkzcDZakt86IQGyo1hABe08fxnseBD571pDJK9PmzUV+7SikyvoEje?=
 =?us-ascii?Q?sqlo2qSGapEo1vi0oZXtlVjcysYTzem4kvHIC13/QeJMmez015zU6XDPnANR?=
 =?us-ascii?Q?0zp9tFARJT7mVypNaB5Gl8zrP3BktDrzxXPan5F0baTMoyFgERGohdCvxIEk?=
 =?us-ascii?Q?f/PVowWQZqD38zxzyZi2D3tvmF7VpAoFCTQMmvW/uVC8LB0vs5rGZFQhcb0B?=
 =?us-ascii?Q?rEmbelLRQb9RqvHkQi498BOp6JYaxagu2tUBMMMX4JAFYHJ5DIs1Ny8KBBIq?=
 =?us-ascii?Q?vqCUVN7aQNhQXaFtWwly6GEhR6lXXkgxYcdawWwttcWrxWswMx2ULMrFLnqI?=
 =?us-ascii?Q?MNSAytb2xv9FGTZPs/u8F+uHpPeZqyP8OZntT+4MmIw9IFvjwYg5L6GyAbcm?=
 =?us-ascii?Q?IjW8BjGd/modyLmStvGbaeS5SbTAO4okop5fa0tFovoWbcaBJdRichzOFlC9?=
 =?us-ascii?Q?sNtD3+i/0AioSzzctaC2p2f+vtJZChOywSff5etmYT9ZN+YD+dbkQb+9lPH4?=
 =?us-ascii?Q?rw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3122.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19c9f37f-46ac-489c-015f-08dbd12f9645
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2023 05:44:11.7704
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: x6cm5RFjXJUfBgZbTg02tUDmYMmme2iEfw2hOezE7ftga47PETXmFq0E8SmsbFhTBK23Zxg/TDVu0Q6uvSdZ8kNWS1Rc/x0z33w3lmMAxiQUkkFTBlWojXK/BDQs9ZuP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8547
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 19 Oct 2023 22:44:28 -0700 (PDT)

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of I=
van Vecera
> Sent: Thursday, October 19, 2023 10:07 PM
> To: netdev@vger.kernel.org
> Cc: Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>; Palczewski,=
 Mateusz <mateusz.palczewski@intel.com>; Brandeburg, Jesse <jesse.brandebur=
g@intel.com>; open list <linux-kernel@vger.kernel.org>; Eric Dumazet <eduma=
zet@google.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Simon Horm=
an <horms@kernel.org>; Sylwester Dziedziuch <sylwesterx.dziedziuch@intel.co=
m>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Davi=
d S. Miller <davem@davemloft.net>; moderated list:INTEL ETHERNET DRIVERS <i=
ntel-wired-lan@lists.osuosl.org>
> Subject: [Intel-wired-lan] [PATCH net v2] i40e: Fix I40E_FLAG_VF_VLAN_PRU=
NING value
>
> Commit c87c938f62d8f1 ("i40e: Add VF VLAN pruning") added new
> PF flag I40E_FLAG_VF_VLAN_PRUNING but its value collides with
> existing I40E_FLAG_TOTAL_PORT_SHUTDOWN_ENABLED flag.
>
> Move the affected flag at the end of the flags and fix its value.
>
> Reproducer:
> [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 link-down-on-close =
on
> [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 vf-vlan-pruning on
> [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 link-down-on-close =
off
> [ 6323.142585] i40e 0000:02:00.0: Setting link-down-on-close not supporte=
d on this port (because total-port-shutdown is enabled)
> netlink error: Operation not supported
> [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 vf-vlan-pruning off
> [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 link-down-on-close =
off
>
> The link-down-on-close flag cannot be modified after setting vf-vlan-prun=
ing
> because vf-vlan-pruning shares the same bit with total-port-shutdown flag
> that prevents any modification of link-down-on-close flag.
>
> Fixes: c87c938f62d8 ("i40e: Add VF VLAN pruning")
> Cc: Mateusz Palczewski <mateusz.palczewski@intel.com>
> Cc: Simon Horman <horms@kernel.org>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)