Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp810299rdb; Thu, 19 Oct 2023 22:57:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGSYQd0qNXzHrov3p+Qck2jr2AzrPdBvWo1Mk+9aPmV7Z2a5GMwcYV+GxdmcjdmsE/JP0w6 X-Received: by 2002:a05:6a20:12d4:b0:174:52b7:f63 with SMTP id v20-20020a056a2012d400b0017452b70f63mr1065449pzg.26.1697781421645; Thu, 19 Oct 2023 22:57:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697781421; cv=none; d=google.com; s=arc-20160816; b=GA7mkq7FKO69Q6Uyr5Ew+0zymFpFjhE6zn/9b3j7gB428/PkZMY8FMoBKOW78YnEs/ h5C9vGXkk2Oau8Cf92oqxO+TOGG4IUBp92NmfafCiWn1HSST3TL0/ta3uZ1BHQ1wPkmR QVLD++TA2SNq0TgVh+tbQMHoruVUTPHjNSqJnJPfRdasDJlbNc5atb+SxTLVtkCmLgGb M+JOjvpaA3QQbJ7PYN/QSA3xO6DBHfIrbpyFd74W3l5GkazDIbtX3sBFKtMS2eLWLEpZ 0BOfbOSd7dgpJmKBpMXwxrdAbkBoy+YcJKPe0kIyRn+HHisv8GwsxGEWqyJ2RGsP2W74 h/lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=poHlEB2ruOIikyhtmJOkPouVUxbi+dlk39CgpHNpB9U=; fh=bNN+2m0mFEBk6ki/3EgYOhnNcrKjvs7hLbqZp7i8eio=; b=IGqcQiQj0LB6VGAzEjlU6mHt0Enhb9jkmcTf/J6crNiWnyvuk7+USBfAsqHlA7XTs+ Fb1RTn23kj7jkjbHWp5wHO8j/PQGJgkryoH+bF8KRHjmXhJDh1367h63mqZzNRM/gNCY OdlngYW4HHZ8KBOMZw+S8GldmgPUBkcQXv3FbvMpMmghcmdIeDJtON4B8tb4C/jXFeFY b1RZhYXd/oeYL5wPI1f7nfQww5eAhK2w3Xy0p/cFZbtsytTjDEqEw3it7AdGvc9p0z92 ahwkG16Tfb/l4nzDt7G5o/RUq+G+ldsDw3aB4BonJMj/maogzhSN1xD8wPfO1f3dNTVR olqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Odb/xnFk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id on1-20020a17090b1d0100b00267b910cb37si1333611pjb.52.2023.10.19.22.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 22:57:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Odb/xnFk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id EC2C48292BF7; Thu, 19 Oct 2023 22:56:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346657AbjJTF4f (ORCPT + 99 others); Fri, 20 Oct 2023 01:56:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233497AbjJTF4e (ORCPT ); Fri, 20 Oct 2023 01:56:34 -0400 Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 923B6D41 for ; Thu, 19 Oct 2023 22:56:32 -0700 (PDT) Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-5841bdf1b81so86993eaf.0 for ; Thu, 19 Oct 2023 22:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697781392; x=1698386192; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=poHlEB2ruOIikyhtmJOkPouVUxbi+dlk39CgpHNpB9U=; b=Odb/xnFkLiQAhW+L3xAXg4M38w4m4XeG8eLxW5OkQLtctXriTI8JbO+LRhd/VSlF8v CsjbAo45GXOFoNItn6aRZKOp3I6XVtyQTt+BzadXcGYcAvZgii+VI0exatEE3iSg2G8F FJ/V6wEy98ipP9Kd7Ufd1ZpT/H3gfmDmQZc3xbJidu/egqk8BKwOXrwmmWZpq3S9ZBS5 9PfGvvnws+AvA4q2MVMq8TBDgDqYNTeum756g+3LQLdL63EvgYlccflRfC5qAE79l+DQ 8DM9xDQTN1hfl+zjB8FCscvdx0HCk3qrnX832tXjcHFk0aIBt/gdcGlN1YcmzT6GFxI3 y1aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697781392; x=1698386192; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=poHlEB2ruOIikyhtmJOkPouVUxbi+dlk39CgpHNpB9U=; b=MjlwHw0+4oVVEU4WzjT23itWA6bc1kgyqQqBVlA9C/E1haEsA4lrFJFWm4SM7tvpOk gMGAqNhRMowU3Q90AneCeDFcxswmpwFLoSh99UTyZg/ituRn4kZx/jccnzVJqf4wggwl 0iSCnZvoOC1Wk0SzTwsLHl3rMdfvYgWxFurK8tTrBIjf4hYry/N5lFZQPxY5+jboSN0+ PFqu4BtOxYNwRr/VJk57Yq2HSa/+lVBGmiFpcEQxLeEsqb32QZ9kbKElBV9Td7juAYII 96zxhqpoPT1qwRaroTsfn/AvDciGWDWHtcHipaq8DR8LFdfuGgYmThIHJOjcNxJoJAEI Misg== X-Gm-Message-State: AOJu0YwYeib3YXxiYgqjdRow1GN1kYaAWWFr8qbA2KqEWtW4lmx05+q3 HqW4URfOdZesXFrkWtiAoGo= X-Received: by 2002:a05:6358:925:b0:139:a45c:32b2 with SMTP id r37-20020a056358092500b00139a45c32b2mr1135354rwi.11.1697781391668; Thu, 19 Oct 2023 22:56:31 -0700 (PDT) Received: from rin-ROG-STRIX-G10CES-G10CES.. (111-255-208-182.dynamic-ip.hinet.net. [111.255.208.182]) by smtp.gmail.com with ESMTPSA id f15-20020aa79d8f000000b00690b8961bf4sm730499pfq.146.2023.10.19.22.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 22:56:31 -0700 (PDT) From: s921975628@gmail.com To: mingo@redhat.com, peterz@infradead.org Cc: vincent.guittot@linaro.org, dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org, s921975628@gmail.com Subject: [PATCH] sched/fair: Remove unused args for pick_next_entity Date: Fri, 20 Oct 2023 13:56:17 +0800 Message-Id: <20231020055617.42064-1-s921975628@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 19 Oct 2023 22:56:52 -0700 (PDT) From: Yiwei Lin The arguments 'curr' for pick_next_entity is useless after the EEVDF changes. Signed-off-by: Yiwei Lin --- kernel/sched/fair.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 9ae220808..486f3c2f5 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -5256,7 +5256,7 @@ set_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *se) * 4) do not run the "skip" process, if something else is available */ static struct sched_entity * -pick_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *curr) +pick_next_entity(struct cfs_rq *cfs_rq) { /* * Enabling NEXT_BUDDY will affect latency but not fairness. @@ -8160,7 +8160,7 @@ static struct task_struct *pick_task_fair(struct rq *rq) goto again; } - se = pick_next_entity(cfs_rq, curr); + se = pick_next_entity(cfs_rq); cfs_rq = group_cfs_rq(se); } while (cfs_rq); @@ -8223,7 +8223,7 @@ pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf } } - se = pick_next_entity(cfs_rq, curr); + se = pick_next_entity(cfs_rq); cfs_rq = group_cfs_rq(se); } while (cfs_rq); @@ -8262,7 +8262,7 @@ pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf put_prev_task(rq, prev); do { - se = pick_next_entity(cfs_rq, NULL); + se = pick_next_entity(cfs_rq); set_next_entity(cfs_rq, se); cfs_rq = group_cfs_rq(se); } while (cfs_rq); -- 2.34.1