Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp823729rdb; Thu, 19 Oct 2023 23:32:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHT0PCjnFMnUYTQENanRZvKXk9KBnxhyucxpp4zxnM+g7iJRiYYPl5Y6Ec2oRo/0J/54FF7 X-Received: by 2002:a17:903:184:b0:1c9:fccb:3b1 with SMTP id z4-20020a170903018400b001c9fccb03b1mr6097720plg.24.1697783553488; Thu, 19 Oct 2023 23:32:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697783553; cv=none; d=google.com; s=arc-20160816; b=XVnrwcO56fvJajABvbcCNvCQHK69+iXHnxaw8bo3pl08F7iZovYwZPp9k59qM1SbCa OXGHb8g+PPgaM/1yXGaoxMZdB/rNFMmEhvCxeIbInOKv/poTd4ZZOwAXa9dvXTlM14kZ xh6cobnALc99xrElx5SqpdqwfV+3ctDX6LUE+yXHQQ9ebSwtaGGjWNXHwIQLx2NAEe7t iRGAcRG/SUsiSuOI9aF/IBFVcThgNuIcryFyLV4PmQMauRGDHsFLPoDPEWdNvlsLkLKp 79abEE7iRG4BReMCAQCYLq9TNzPgKLJ2Pfy1LWac9tgdFpTnDOg5krDLRt2Hate38N8u Rdqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=5qeeYz5V48ireqFEi+ywjuz8ashXtpLODjwuWX4lfJE=; fh=b+k1+jYRzZ12Xnu/EhehExsd14IdAsQbXM4Q9Mqioac=; b=ogyxMOq1K5Bf4BAHHfdllxbV/eFK2m+Iir9lEzVw3Ll1APcdiQntNlXOmKHmsM1zVX kVPaWkhhyqfxkcmG6BD3Y73SNnszbe01/HqdSnj3+WAY/LOlqS1G9Q3yv9ZDUokxGbRl IocoU1qRaAwborSTg2DP00UKJKV3giD2ep3Bxx1AC2GPhdZsRKAUQrK5A1qpFPZdhzLa 6Mx28VVIx8ZS4leLOrgYkBFlyusm4wZAB9cTrDRm9HE6UsOlWa71YaP6TyMalK3BUj0d 82o0KW/jFrDoOewVcsyYHlJ89mjAsavkoegEc8REe9MgcyrL+f2oCes74XuHtzzjC8Pa A2Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=AmGgd8Dv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id az1-20020a056a02004100b00584e731e7fbsi1220247pgb.280.2023.10.19.23.32.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 23:32:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=AmGgd8Dv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id B88AF806303A; Thu, 19 Oct 2023 23:31:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376298AbjJTGbn (ORCPT + 99 others); Fri, 20 Oct 2023 02:31:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346919AbjJTGbl (ORCPT ); Fri, 20 Oct 2023 02:31:41 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45F1BD49 for ; Thu, 19 Oct 2023 23:31:40 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1c9d4f08d7cso122515ad.0 for ; Thu, 19 Oct 2023 23:31:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697783500; x=1698388300; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5qeeYz5V48ireqFEi+ywjuz8ashXtpLODjwuWX4lfJE=; b=AmGgd8Dv//R+QfIGgm1xNuknYwDcjvJ/g4koRbyZHiNSyeNx878n4s+/lo9As/iMRT 8JOA0ufseATQa2n/jGH7UCEUaBvI4Laf6lP0YX5I+tTej1vI0aiEE4hbDtCxXJ2N+K9M 2Oc1/9ex8rABgdCHep4Rrpvc8n1WZFlsjejsHHNfB30r1DTyyqEiW1F1UTgZS3CY5res iD0pJC+eS29SXHrLzY0sXubw3nKU67sSSfTpqrhANkqAqsXVxtNe3xhGbpeyIN2btq1K 5+YfPjZPS3pqs6V4hPA2sbOmuRtlD55DMwpsw1ydMime0EmDkLVxVt6euj5/m5SuOFZo z6DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697783500; x=1698388300; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5qeeYz5V48ireqFEi+ywjuz8ashXtpLODjwuWX4lfJE=; b=xRJR7G27cpEq67js8lqPpIqLpom0+jiP4v2AvU4NNuZZRkzOFXPjaGjLjynYvho59y NyLE1+luZZhVn+CZ2UbKZicL4BfbcEj6GCro/zs4h2/kvKh/tl+HRUNhlKR49MPQAYoU GpNoak5Zapo7Psek2RwjaeOyDxHglgztC+JQEOGEVyYcjEz6JwIOzj4y6Cm0uyWuYUL4 kGU5ytXS1o9pBG2JPm2VJfKYQ3xsqBXl1k25SL5bjU4z+sIFyWcu6ft7rqWCqqMOJrVD g3Y3OOgXS9ZYJiy5e2EMH/bwH8aMvXf5oH/OuwaafLqIIPxq8ZMv34Q5vrGKKMXrAgc2 nZZg== X-Gm-Message-State: AOJu0Yx6chyVIMDD0wpLhFdC6A/8dXgwSltTY4TA1lbSvypO+tVof7TA DOcg32RswBbWR4ZEQGzjcChObwoIUHYa1xtAa5dDJg== X-Received: by 2002:a17:903:8c4:b0:1c9:e53b:4099 with SMTP id lk4-20020a17090308c400b001c9e53b4099mr147617plb.8.1697783495364; Thu, 19 Oct 2023 23:31:35 -0700 (PDT) MIME-Version: 1.0 References: <20231019225346.1822282-1-roman.gushchin@linux.dev> <20231019225346.1822282-7-roman.gushchin@linux.dev> In-Reply-To: <20231019225346.1822282-7-roman.gushchin@linux.dev> From: Shakeel Butt Date: Thu, 19 Oct 2023 23:31:23 -0700 Message-ID: Subject: Re: [PATCH v5 6/6] mm: kmem: reimplement get_obj_cgroup_from_current() To: Roman Gushchin Cc: Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song , Dennis Zhou , David Rientjes , Vlastimil Babka , Naresh Kamboju Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 19 Oct 2023 23:31:52 -0700 (PDT) On Thu, Oct 19, 2023 at 3:54=E2=80=AFPM Roman Gushchin wrote: > > Reimplement get_obj_cgroup_from_current() using current_obj_cgroup(). > get_obj_cgroup_from_current() and current_obj_cgroup() share 80% of > the code, so the new implementation is almost trivial. > > get_obj_cgroup_from_current() is a convenient function used by the > bpf subsystem, so there is no reason to get rid of it completely. > > Signed-off-by: Roman Gushchin (Cruise) Acked-by: Shakeel Butt