Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp830248rdb; Thu, 19 Oct 2023 23:51:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdZUbqgB682DC5isVYnPOUrvuij1WUmwHP90gRGwA85Akof0bIY/7ABP1LqL0f5bOGzQgL X-Received: by 2002:a17:90b:3013:b0:27c:fd8c:7d28 with SMTP id hg19-20020a17090b301300b0027cfd8c7d28mr1012638pjb.39.1697784717167; Thu, 19 Oct 2023 23:51:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697784717; cv=none; d=google.com; s=arc-20160816; b=tgs4VZ3DGsj11Pjc1YT0rhG4bukIaB8VTic6bw4hg1Syoq+tyJrbmAaRpTiwY8RhNC K3Dgw6FRAbZZZ7Kvr583gAoUNTRJ0gljCHCK5VLhSFDwX7GkAdij2iXAbpGx8UJ9to2u jrMetDKhFJgZ6dgAlSEaLPEcLsFPotN3LoDKtDwv+TzAms4lbFSePUGwxCb3IDwe1U6Z Ugbomm75ljlMeHPryX/wy7NlgARcnpvxDkBr+3cu7K81PEYOIWsIsDsbN4z1E5DcgDgK ROYvpl/r1mscjGIPPionM6Tl5TP2F1WUvt0+7zUNYDN977j+0tUEieNHgnS2NGNqCl7M mAbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tUWFtk2ND59A4SW0HP6A+busYNOlgufyXN1B/G4XDtA=; fh=OyvKLCIGIaNaHZl8Gdj3VKs53wNenJwp0vzEjW4OaB0=; b=gAYFz5ftsdPabqUcfKPNeRcQdRPys90vIPHwYBtUHUC0vug7Ac21KN6iwkUpjJuECs Xu0adtXD4hulYxFmA/KAlmxkaP2QhHDR7lsxivEnqhJYmi1hbiHW32a6DCyRP4eSr/6r PNejpTjpHCmWy9hq5ofDyrLR541wGwp8JmGhhYCNFmWbNglzKlp0YoBmVgrvujcU+6oJ EVHNQLRrBTy8BQP55+ZQmqyoMsfODA36VlasqXqmAL5t8r42fWPthJVOidP/MiQYQ7tW aHw7H/dpGiTz9LMT1ybtWR/kly3I57MY/+UwjQWAdWRFxoQSW7vj3qa3Rt8c60D87XC+ Z+Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Onr/U2J1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id f21-20020a63f115000000b00585999a38a6si1170283pgi.793.2023.10.19.23.51.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 23:51:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Onr/U2J1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id C155B80811E3; Thu, 19 Oct 2023 23:51:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376357AbjJTGus (ORCPT + 99 others); Fri, 20 Oct 2023 02:50:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376346AbjJTGur (ORCPT ); Fri, 20 Oct 2023 02:50:47 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E066D61 for ; Thu, 19 Oct 2023 23:50:45 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-32d81864e3fso307952f8f.2 for ; Thu, 19 Oct 2023 23:50:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697784643; x=1698389443; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tUWFtk2ND59A4SW0HP6A+busYNOlgufyXN1B/G4XDtA=; b=Onr/U2J18s514Y+us3FZPav8+M5RSIfcETyyrS/muk7U4bloYBCrtptpqD970wCd9r p6/0Q41Z+yxHE49+vhS8irnxyNvtNUiklS7UVWUsDvVFKB7fyoJzS1qovBXqxeLmW1GT 3+Zvv5DWVcYXlbRVcK+PGxFRNtXTwHiBgZf6PBWS44hSuplcf74sYProHfwbf2h4lNib OqowF6Yui9Cmbtf5y3X7RlXyLEueif0MlXUEZs6pMujNDQyQgzz4HISZ8Tfx91Y2Yn83 rfTvllGlsaTQ3Rz1CwGfmwMMXWfEQN70Y+BPpaDHUX0q7x/x/C8BBdeHz62LbKlOcPgx 0btA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697784643; x=1698389443; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tUWFtk2ND59A4SW0HP6A+busYNOlgufyXN1B/G4XDtA=; b=vUOdww0vhOXdx3u201nePLieZYs7FT7fvrixM30c2+L5iOZwiGEI4rEpll/XvXOhan U5Q4kL/EDA405CzqauG6gKlp4joYFQ/ni6YXWI+gWax33rlE3JFyCal+/EDY0l4oP4Hd aUpLf0QpfzltF4Yiw1hiTRyU89rWUVD+6KEECQ+sWI2U6RsmK1fHdPHD3yPr/NmcvvaS HevvG0zbKwM6yppr/adRxhkHpiSiSSZAhi/pNjbdgPwVSEHMmNZoIm/JHBjCPV3fVphQ 2DdofpkzRzGOIvGazRVH3dtzOuuPYj9wG8MtaejKKMwiFXbYZPrTyp9JsBmBMVVtcMI+ j4Zw== X-Gm-Message-State: AOJu0YwjNQqVEgF/foMVK9KOCRGHfN7eHvkMdoqSdJpJNxZGGUN2Ai0q 3V/XbSB1MAnq8plN2YM2HBUY3w== X-Received: by 2002:adf:e80e:0:b0:32d:a476:527a with SMTP id o14-20020adfe80e000000b0032da476527amr592325wrm.50.1697784643512; Thu, 19 Oct 2023 23:50:43 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id e16-20020adfe7d0000000b0032db8f7f378sm997906wrn.71.2023.10.19.23.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 23:50:43 -0700 (PDT) Date: Fri, 20 Oct 2023 09:50:39 +0300 From: Dan Carpenter To: Su Hui Cc: kartilak@cisco.com, sebaddel@cisco.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] scsi: snici: remove useless code in snic_dr_clean_pending_req Message-ID: <8e1d29d7-092d-444e-bf89-23703b0bc278@kadam.mountain> References: <20231020023326.43898-1-suhui@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231020023326.43898-1-suhui@nfschina.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 19 Oct 2023 23:51:11 -0700 (PDT) On Fri, Oct 20, 2023 at 10:33:27AM +0800, Su Hui wrote: > return error code directly to save space and be more clear. > > Signed-off-by: Su Hui > --- Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter