Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   <Divya.Koppera@microchip.com>
To:     <o.rempel@pengutronix.de>, <Woojung.Huh@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <andrew@lunn.ch>,
        <f.fainelli@gmail.com>, <olteanv@gmail.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <hkallweit1@gmail.com>
CC:     <kernel@pengutronix.de>, <linux-kernel@vger.kernel.org>,
        <linux@armlinux.org.uk>, <netdev@vger.kernel.org>,
        <alexander.stein@ew.tq-group.com>
Subject: RE: [PATCH net-next v3 2/2] net: phy: micrel: Fix forced link mode
 for KSZ886X switches
Thread-Topic: [PATCH net-next v3 2/2] net: phy: micrel: Fix forced link mode
 for KSZ886X switches
Thread-Index: AQHaAn2QgWXv9I3krEavaf/+aefoYbBSUeXA
Date:   Fri, 20 Oct 2023 08:01:21 +0000
Message-ID: <CO1PR11MB47717FCDC67AF14C5EA27C37E2DBA@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <20231019111459.1000218-1-o.rempel@pengutronix.de>
 <20231019111459.1000218-3-o.rempel@pengutronix.de>
In-Reply-To: <20231019111459.1000218-3-o.rempel@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pPBB1lpHpAIrbi4Ny9G8AbNTpChvUTGouWpPPeWsaE/H+MBucmy9mpzWpwGE?=
 =?us-ascii?Q?X+SeqEw7VhhaJYnpOtDtxmebNgpdtEUSc3TIEtWMJeH5pSKo+hKmKzq7OtDJ?=
 =?us-ascii?Q?7GoBY5aflfEtDA5dCaujoMBoY1VezeDrosot2Sm4/KWRF7OTaTd8AVZnMt/k?=
 =?us-ascii?Q?I39tT1ba2uqXe2LOOHXQZ2zEEA/z3oztWm97lD3LEEKWLq7vdyLvgHE+xOVy?=
 =?us-ascii?Q?8K9y6fiZ95MQea089NCdslN35vlZMpJFGV9V2j7hoyShWXS3T6QpdlL31V4j?=
 =?us-ascii?Q?zXj8hlOlExys/hXyIULsmFEXjYugvhdVRtDpzW5jdarMlwxusNbsyujPpEs9?=
 =?us-ascii?Q?aWxEvx1MjWYG/t2oywKUJXyJtCth4CxA4hN//7uSgPRjEQdvi7bGTFC7J2nK?=
 =?us-ascii?Q?g8RjgxxZFrm9feHTolFa7pHP6FnRlzEXx+oUfdaUCQJzTOPZblQnStBuTnD3?=
 =?us-ascii?Q?M/4mjH+HNUpvRrfTGzT5OysK3ZVgXqMH7In6DlPFPvNoJJVtvvQ74ZxrbZVY?=
 =?us-ascii?Q?JuG4j3nR9Z1k++xnnyeetJrmEo2WvV6jz8sf9k2vrUIeQe6+vkE+pJbfwYN4?=
 =?us-ascii?Q?U/wDyJFU4Td+eT5wH17M0SmdIrBifmwhjEkszOZirE0ICeKn5BBmKyBDpUo2?=
 =?us-ascii?Q?49R8HUR2u2hiaITXFzoqFrRDRlFzWqQsVDVNTmF++z7z7mewLCxhl6j2X79u?=
 =?us-ascii?Q?vZYnGaFWbBeUB3R2Zu5w51pJf71VzTC9EFhNVTx3XRWO3+X6XZunrz2wSAbT?=
 =?us-ascii?Q?2pn9aCuWFZloGqhxLMydRJxHD0i4OeBNQPmLnTs3cyN/QUh9+FLqnzNvVGxd?=
 =?us-ascii?Q?JqDWQLU72V4/vxvbqwT3k8WuCSarErJidCnpUf1NMXYqZ4cs7Gtn3cUXFolp?=
 =?us-ascii?Q?i5AToqARYv5wEhXM/XOUXQOBIBgm73CgsTlDoMXbCMSV7cKplFTPFCjK/aQ0?=
 =?us-ascii?Q?qUjjZACRr8EMCS87elOupxIOSk9B7kr5o0eErT5B0GncylzuyuPBNODOQbIH?=
 =?us-ascii?Q?BgW3D4acKm3nJkKaZxeX7fqGUQHfiOhsqUsSnufZkPyKVsD2qLWMOwiiP/TG?=
 =?us-ascii?Q?rmfwlzRNlSEmPTWlO/xJ7AQDJVbBuKkDJ8BZ0ptujeLT2up5eOcB8LwGvAoR?=
 =?us-ascii?Q?IObfvkzzzL4du9BjyegkDu6903tbc9nPmidu00YvToJuROf+HWvDFKOzruYg?=
 =?us-ascii?Q?BcFjnRTXQranbf016qWvDUEG0nX4CXUbf8diXG+5I6k47f6Kf3WaafleWCMp?=
 =?us-ascii?Q?2bFlzAiO6rWpzaG9lc4347i0ZxJtwlzw8vLVP3QOI/SWz/KVMy+3UPZZ9odX?=
 =?us-ascii?Q?1K+lgF99AE6lodrW10QP32/ck9nlBWEd+AzxJM2d1sUUxG9IoNrGufOUb/yn?=
 =?us-ascii?Q?z+U455fPc2t7KnT+p1K6puUSHp3oXnHkyNYutKXxgiNag6PiGA2n6XiInhQo?=
 =?us-ascii?Q?lhvcUI+Ty9S/khXiuUE7fh2DwMedm8GqQ2TugXU2AZ8a5q84KDA/yPla7CKk?=
 =?us-ascii?Q?/pVQyhdrYD0DIERAMrYJN96zLulY1en+HIuparpOoVsBPE/3y8chj5x9vxdS?=
 =?us-ascii?Q?paBVhfUhZFbr/IBRqsbVL+y2VdaDY7D+CBK3l8q7suHInjlEYYJZATcbtXvJ?=
 =?us-ascii?Q?zg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a94bbc01-a191-4faa-72d5-08dbd142bfdd
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2023 08:01:22.0009
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FQfd9iSl5MP5fSLSEwlHFkteYbZM1hIHPrcqZC3PxH8IXQDlz9byT5gPDqeGF4Tj4EzsQqgzD0LNPcV4qwg/GlhhZ3R63yV4uDiD+CoBzIA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8509
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 20 Oct 2023 01:02:07 -0700 (PDT)


> -----Original Message-----
> From: Oleksij Rempel <o.rempel@pengutronix.de>
> Sent: Thursday, October 19, 2023 4:45 PM
> To: Woojung Huh - C21699 <Woojung.Huh@microchip.com>;
> UNGLinuxDriver <UNGLinuxDriver@microchip.com>; Andrew Lunn
> <andrew@lunn.ch>; Florian Fainelli <f.fainelli@gmail.com>; Vladimir Oltea=
n
> <olteanv@gmail.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>; kernel@pengutronix.de;
> linux-kernel@vger.kernel.org; Russell King <linux@armlinux.org.uk>;
> netdev@vger.kernel.org; Alexander Stein <alexander.stein@ew.tq-group.com>
> Subject: [PATCH net-next v3 2/2] net: phy: micrel: Fix forced link mode f=
or
> KSZ886X switches
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> Address a link speed detection issue in KSZ886X PHY driver when in forced=
 link
> mode. Previously, link partners like "ASIX AX88772B"
> with KSZ8873 could fall back to 10Mbit instead of configured 100Mbit.
>=20
> The issue arises as KSZ886X PHY continues sending Fast Link Pulses (FLPs)
> even with autonegotiation off, misleading link partners in autoneg mode,
> leading to incorrect link speed detection.
>=20
> Now, when autonegotiation is disabled, the driver sets the link state for=
cefully
> using KSZ886X_CTRL_FORCE_LINK bit. This action, beyond just disabling
> autonegotiation, makes the PHY state more reliably detected by link partn=
ers
> using parallel detection, thus fixing the link speed misconfiguration.
>=20
> With autonegotiation enabled, link state is not forced, allowing proper
> autonegotiation process participation.
>=20
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  drivers/net/phy/micrel.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>=20
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index
> 927d3d54658e..08e3915001c3 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -1733,6 +1733,28 @@ static int ksz886x_config_aneg(struct phy_device
> *phydev)
>         if (ret)
>                 return ret;
>=20
> +       if (phydev->autoneg !=3D AUTONEG_ENABLE) {
> +               /* When autonegotation is disabled, we need to manually f=
orce
> +                * the link state. If we don't do this, the PHY will keep
> +                * sending Fast Link Pulses (FLPs) which are part of the
> +                * autonegotiation process. This is not desired when
> +                * autonegotiation is off.
> +                */
> +               ret =3D phy_set_bits(phydev, MII_KSZPHY_CTRL,
> +                                  KSZ886X_CTRL_FORCE_LINK);
> +               if (ret)
> +                       return ret;
> +       } else {
> +               /* If we had previously forced the link state, we need to
> +                * clear KSZ886X_CTRL_FORCE_LINK bit now. Otherwise, the =
PHY
> +                * will not perform autonegotiation.
> +                */
> +               ret =3D phy_clear_bits(phydev, MII_KSZPHY_CTRL,
> +                                    KSZ886X_CTRL_FORCE_LINK);
> +               if (ret)
> +                       return ret;
> +       }
> +
>         /* The MDI-X configuration is automatically changed by the PHY af=
ter
>          * switching from autoneg off to on. So, take MDI-X configuration=
 under
>          * own control and set it after autoneg configuration was done.
> --
> 2.39.2

Reviewed-by: Divya Koppera <divya.koppera@microchip.com>