Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp874989rdb; Fri, 20 Oct 2023 01:48:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGh9Q93yjJ1iNjgAZgPEtJHog/4+0afvRCPBfNngz4N5J7Hx+IVHQGc9VHbXPwWP2IG8s0H X-Received: by 2002:a05:6a20:440e:b0:14c:c9f6:d657 with SMTP id ce14-20020a056a20440e00b0014cc9f6d657mr1495445pzb.22.1697791708499; Fri, 20 Oct 2023 01:48:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697791708; cv=none; d=google.com; s=arc-20160816; b=FUxkJCd/OtX/argpu1vVpD10uydjpxSyZmYazekc8k7wd/YLRToWKM9QbsIuM/8mrQ CyEMddLp07xF2ukCsFxHzmOCvw/g64zmncUYFIj7GcuhEeZSG7rYuSGnq5Q7SLAlTeHJ +YK2ytWS8UeC3U7DCa6bYPcuA6YKeyAf9/+etEJtLIr1Yz5DoSlwTTHAYAZrSFnlSQP+ VknHAEqkQACSgg5WOyxhVj/sCNb0lLPKMeblxBfgUUE5RSdKKIzUsTm1AvbH/capwaLF /qpqgHiei3pvP7MZlnYvDNLjkzVVoYqYIAobYPzYbxQ4t759Ubh4vBf/oItFfX+fS78M mb9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=0d5YnslamlesyvKL6qrM29IAstK+PMagJVtaLw7GfIk=; fh=WAU8dvHbCVEKt7PKP55MCP59DfghQ92mfS2Ma7uEses=; b=sadN3cDpNWTKy0Ugui/puEc+9OAUEmcvg05K5Yj5GeMfff7TsnX9G1DUfqngvStke2 mRH5nNw5oiaa91olrDrcWBKKtFOYv9piZhDAlJEfdmlTh+QjKZzVNnp42HzrkyJDfN2l cc6nx3PXjsEflCTrTdCDYIprki9k/OovKWRFs8uO5Y/JhJ1NaWfaFh/Ju9C9T+aDBiNS k9GcIZEvCkToE8mbnyUrnen0l2m/srKVgav/cOlKfb4/CVZOKK2nTma6LOnKhUaAjCz4 72MKPgu0VtDFSuh8eyvE5N2uZCbyVStX2kFCzhNshd7tGbN0VBPsK7DqdaNxx5WACUJS dHGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CMEDCpUP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id t17-20020a1709028c9100b001ca7fab771esi1217746plo.609.2023.10.20.01.48.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 01:48:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CMEDCpUP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id B6EFE83EDD92; Fri, 20 Oct 2023 01:48:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376548AbjJTIsT (ORCPT + 99 others); Fri, 20 Oct 2023 04:48:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376519AbjJTIsO (ORCPT ); Fri, 20 Oct 2023 04:48:14 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D9FAD49; Fri, 20 Oct 2023 01:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697791692; x=1729327692; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=1P08c+02XrBKccGcreruYeIgD28f7+s17ZZyX78daGc=; b=CMEDCpUPJOswyAe6+vH3IfTQrD2FzFchFXSwCa591iFEzTBXlR3CDcem 2a6ljM4MO4+iNwOAJVNZgrPWUKZQlDL+a04uWR7DL0EYYvlPvKIcy8m6z bw5hW1HVBfTv5WlpgFa2Gg2RB2k1d4l8shW5WYSM42djjm+5prUOyT7hx WxuH4NZnMUaK8iZwVQAAaJcc1taPBNWSi36wQrJnnzHiVHPBccfsQZBB0 WDT4Q8vb8aBEwY7TrDBf3KIZkJLHjLXCQi5U05fgoIE9EDxK4iiSS75Bn U8+Kebjg6SA0yahw20UnMj6VPzJEQ3/LuoiHp7nkUNQw9lx+1PAsrr8th g==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="450683511" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="450683511" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 01:48:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="873832168" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="873832168" Received: from inlubt0316.iind.intel.com ([10.191.20.213]) by fmsmga002.fm.intel.com with ESMTP; 20 Oct 2023 01:47:56 -0700 From: Raag Jadav To: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, mark.rutland@arm.com, will@kernel.org, linux@roeck-us.net Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com, Raag Jadav Subject: [PATCH v1 3/8] ACPI: sysfs: use acpi_device_uid() for fetching _UID Date: Fri, 20 Oct 2023 14:17:27 +0530 Message-Id: <20231020084732.17130-4-raag.jadav@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231020084732.17130-1-raag.jadav@intel.com> References: <20231020084732.17130-1-raag.jadav@intel.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 20 Oct 2023 01:48:26 -0700 (PDT) Convert manual _UID references to use standard ACPI helpers. Signed-off-by: Raag Jadav --- drivers/acpi/device_sysfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c index b9bbf0746199..9d8e90744cb5 100644 --- a/drivers/acpi/device_sysfs.c +++ b/drivers/acpi/device_sysfs.c @@ -410,7 +410,7 @@ static ssize_t uid_show(struct device *dev, { struct acpi_device *acpi_dev = to_acpi_device(dev); - return sprintf(buf, "%s\n", acpi_dev->pnp.unique_id); + return sprintf(buf, "%s\n", acpi_device_uid(acpi_dev)); } static DEVICE_ATTR_RO(uid); @@ -554,7 +554,7 @@ int acpi_device_setup_files(struct acpi_device *dev) if (dev->pnp.type.bus_address) result = device_create_file(&dev->dev, &dev_attr_adr); - if (dev->pnp.unique_id) + if (acpi_device_uid(dev)) result = device_create_file(&dev->dev, &dev_attr_uid); if (acpi_has_method(dev->handle, "_SUN")) { @@ -635,7 +635,7 @@ void acpi_device_remove_files(struct acpi_device *dev) if (acpi_has_method(dev->handle, "_HRV")) device_remove_file(&dev->dev, &dev_attr_hrv); - if (dev->pnp.unique_id) + if (acpi_device_uid(dev)) device_remove_file(&dev->dev, &dev_attr_uid); if (dev->pnp.type.bus_address) device_remove_file(&dev->dev, &dev_attr_adr); -- 2.17.1