Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date:   Fri, 20 Oct 2023 10:59:33 +0200
From:   Ingo Molnar <mingo@kernel.org>
To:     Qi Zheng <zhengqi.arch@bytedance.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Mike Rapoport <rppt@kernel.org>,
        David Hildenbrand <david@redhat.com>,
        Michal Hocko <mhocko@suse.com>, x86@kernel.org,
        Andy Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] x86/mm: Drop 4MB restriction on minimal NUMA node
 memory size
Message-ID: <ZTJBdY7CLhHLeVmh@gmail.com>
References: <20231017062215.171670-1-rppt@kernel.org>
 <ZS+2qqjEO5/867br@gmail.com>
 <605cc166-e731-e7d1-25d7-b6797a802e6f@bytedance.com>
 <ZS/TRNf02Un8IOTK@gmail.com>
 <35bd1d51-35ac-3ee6-e068-f50dff7774bf@bytedance.com>
 <ZTI+aiL/eKGbem6G@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZTI+aiL/eKGbem6G@gmail.com>
Precedence: bulk


* Ingo Molnar <mingo@kernel.org> wrote:

> > > Mind resubmitting that to the MM folks, with the NULL dereference 
> > > crash mentioned prominently? Feel free to Cc: me.
> > 
> > OK, I will resend it if no one else objects. :)
> 
> Thanks, much appreciated - and I see Andrew already applied your two 
> fixes to -mm.
> 
> With that background I was able to apply the x86 fix as well - which can 
> be backported without the MM changes. The current commit in tip:x86/mm 
> is:
> 
>   a1e2b8b36820 ("x86/mm: Drop the 4 MB restriction on minimal NUMA node memory size")
> 
> Which should hit v6.7 in about ~1.5 weeks, unless there's unexpected 
> problems.

Note that I haven't added a Cc: stable tag, a 17 years old bug is not 
really a regression - but I have no objections against this fix getting 
into -stable once it gains a bit more testing and hits upstream.

Thanks,

	Ingo