Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
MIME-Version: 1.0
References: <20230911114347.85882-1-cloudliang@tencent.com> <ZTHJvQm-nDNkvldM@google.com>
In-Reply-To: <ZTHJvQm-nDNkvldM@google.com>
From:   Jinrong Liang <ljr.kernel@gmail.com>
Date:   Fri, 20 Oct 2023 17:11:37 +0800
Message-ID: <CAFg_LQVsXjcnpnDFnP1rrypXD4N0DD3kYq_vxXK8SRzGjEjA1A@mail.gmail.com>
Subject: Re: [PATCH v4 0/9] KVM: selftests: Test the consistency of the PMU's
 CPUID and its features
To:     Sean Christopherson <seanjc@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, Like Xu <likexu@tencent.com>,
        David Matlack <dmatlack@google.com>,
        Aaron Lewis <aaronlewis@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jinrong Liang <cloudliang@tencent.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Sean Christopherson <seanjc@google.com> =E4=BA=8E2023=E5=B9=B410=E6=9C=8820=
=E6=97=A5=E5=91=A8=E4=BA=94 08:28=E5=86=99=E9=81=93=EF=BC=9A
>
> On Mon, Sep 11, 2023, Jinrong Liang wrote:
> > Jinrong Liang (9):
> >   KVM: selftests: Add vcpu_set_cpuid_property() to set properties
> >   KVM: selftests: Extend this_pmu_has() and kvm_pmu_has() to check arch
> >     events
> >   KVM: selftests: Add pmu.h for PMU events and common masks
> >   KVM: selftests: Test Intel PMU architectural events on gp counters
> >   KVM: selftests: Test Intel PMU architectural events on fixed counters
> >   KVM: selftests: Test consistency of CPUID with num of gp counters
> >   KVM: selftests: Test consistency of CPUID with num of fixed counters
> >   KVM: selftests: Test Intel supported fixed counters bit mask
> >   KVM: selftests: Test consistency of PMU MSRs with Intel PMU version
>
> I've pushed a modified version to
>
>   https://github.com/sean-jc/linux/branches x86/pmu_counter_tests
>
> which also has fixes for KVM's funky handling of fixed counters.  I'll wa=
it for
> you to respond, but will tentatively plan on posting the above branch as =
v5
> some time next week.

I truly appreciate your time and effort in reviewing my patches and
making the necessary modifications. I've carefully examined the
updated code in the branch you kindly provided:

https://github.com/sean-jc/linux/branches x86/pmu_counter_tests

I completely agree with the changes you made. Please feel free to post
the modified branch as v5 next week. I will add AMD counters related
selftests after this patch set is merged.

Thank you once again for your time and guidance.