Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp895594rdb; Fri, 20 Oct 2023 02:36:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF2lCAmfEX3XUDdVYemvZ2n6ZJIzmnbX+wG8Lb5nrczEyEO0hyKflhntoSXT5D6xO+FXXaP X-Received: by 2002:a17:90a:7f93:b0:26d:17da:5e9f with SMTP id m19-20020a17090a7f9300b0026d17da5e9fmr1361432pjl.1.1697794596913; Fri, 20 Oct 2023 02:36:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697794596; cv=none; d=google.com; s=arc-20160816; b=QL9673Vae794NQBin9EjqYacRB+ek/2Z9HaUssRasLbOZkDePtfBJqFOnYg7tkWkks 8zW2427cvf1Wxxhc3ZM7N8zmk23M1yADc+3D6BedaD8bRK25wFtBLS6Y5ibJg8jnmSiW rjsX4h98zIpWMv/I+GJBF6gVZ0jOVRTm0jrIjZk1QU1+mECe64cRB2rkp6tPIBQhcJBl UfmBEfA6b573g2D0kFyiudt/3QOpvh6qvlL/vfn1GFccage8hMpD6vtA72oyii4rwBf7 8z8Iu+Qs/JfWUm0zCYJEtMCSpgcPUS+QOa/QHU3a2ZzON+cuS0tk8bxIUK2jmab3iubm Vhug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :subject:cc:to:from:date; bh=MMFuuN9j/kD1DN0RlI5LiDsq4F8vukSX+yw3gh71cp0=; fh=3yxFISXNGI3zqNl/+Z4tDnCM8VToYTHHXHxBcHt3uzw=; b=vr2XY61OkDLV+IEHTa2QvlD5OyZ+zxp3PFvHdDP0uJUw9OwzjtHPxk+3xor8kc7HEj YsGVM+tVyzQQ6U73PqArAU6YKSCfJsOehZ+tbLOoEJPPF/TV5+v+E49AbgX+poD92iNp lFdyT9KiYHk0GL7Mbc+OuUXXvxmJysh/URZm9VlAogFToGtfKOy7JaFKIyc0zIoXwRs9 js1/feyVVztSeJuBmUFSG2bHaQ++EYPhZWty7kN0zL5myMNbXb+k9PMbeK97QDsOzFiO RsX7dxQrBL8OnWBwFZLMauKS0XuLw+BftlGa6AxcMs5Bquhk+L0MmytRrVX8eNsnDBXa cWsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id x2-20020a17090a6c0200b002790e0af4aasi1506293pjj.174.2023.10.20.02.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 02:36:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 29A9B8051A35; Fri, 20 Oct 2023 02:36:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376682AbjJTJgW (ORCPT + 99 others); Fri, 20 Oct 2023 05:36:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376797AbjJTJgL (ORCPT ); Fri, 20 Oct 2023 05:36:11 -0400 Received: from bues.ch (bues.ch [IPv6:2a01:138:9005::1:4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7A831713; Fri, 20 Oct 2023 02:36:02 -0700 (PDT) Received: by bues.ch with esmtpsa (Exim 4.96) (envelope-from ) id 1qtlv2-0001rL-2F; Fri, 20 Oct 2023 11:35:47 +0200 Date: Fri, 20 Oct 2023 11:35:14 +0200 From: Michael =?UTF-8?B?QsO8c2No?= To: Bragatheswaran Manickavel Cc: Larry.Finger@lwfinger.net, kvalo@kernel.org, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] b43legacy: Removed unneeded variable in debugfs Message-ID: <20231020113514.122bfb6e@barney> In-Reply-To: <20231020092735.2565-1-bragathemanick0908@gmail.com> References: <20231020092735.2565-1-bragathemanick0908@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/kfDnOujsaQJS.7yl4+DvrH0"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 20 Oct 2023 02:36:34 -0700 (PDT) --Sig_/kfDnOujsaQJS.7yl4+DvrH0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 20 Oct 2023 14:57:35 +0530 Bragatheswaran Manickavel wrote: > Removed unneeded variable. Issue identified using Coccinelle semantic. > No functional impact This patch is completely wrong. It would not even compile. Please compile your patches before submitting them! And it is the second time we see this nonsense. The code is correct as-is. There is no unused variable. NACK. --=20 Michael B=C3=BCsch https://bues.ch/ --Sig_/kfDnOujsaQJS.7yl4+DvrH0 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEihRzkKVZOnT2ipsS9TK+HZCNiw4FAmUySdIACgkQ9TK+HZCN iw7mtxAAiVUycpeZTGhcQXIsXI5dmrqAsTA2Nsxr01vvreRpLZDZUFLOg7ou4rXz JD5nD+4ZdIbQnlSyF4CVgpZbstsYSa0FGeC4yHnASIAX0Ou6x3bqhX28K+Gdb/RH isjualTrLUR94jQJqjnFrTKjVD2ezTjG5i0NJSwP3roTohMXUfUApyJE7CV/URIA SosRMc6aKnrfdd4pHidRLW1BVNKpY5NiK++rjwaPzxqy2riEzVyHKkZoQaJB2lHm DBTDeRHj3D5ZUSlB0U/nlR0eyg3jixvtCONvXls2CDWOtLApSUh86Zm2BIE39HX7 3uxqnAsf+RmtuKxb4IhyqBAkHj6In8VQ4HL7yOflRdAZkKo3JkJBaoE9idYvP20Y gWWi3NoIeLybwVRID/iAb/5SDGKHmjX4gBsxonOhH9066++kPWvdVHWDzdN5ibfQ EEiX3r+l1rCuQfAlNrqgHR0UNgMxzCxAnWCmlR5RJbSCxmNU87qwafLmZBN9rYaN +XDOFrLm1fSNfOtFTdN2ee85mzOEJoGpIoHqytnYPO2RY98q6HotCMRIO+o76BTG ULhxVYvSEQIvQIGwUycT60eehKD7T4wb5xvzB61m/aP60SG4fQq/uH7K2dvxPU5D mI79wh855Geu4H1NJr3rgOlyUDYnVFkUSdbWTspvif9VYsNQ2wQ= =wS4g -----END PGP SIGNATURE----- --Sig_/kfDnOujsaQJS.7yl4+DvrH0--