Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp906068rdb; Fri, 20 Oct 2023 03:02:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE+miTvXYnZ2PUarmj+axORoa/aMjtR19u5LCzJI95HbKj8peXlchjWAjnTgZ0zv+VOPpCm X-Received: by 2002:a05:6e02:156d:b0:34f:1e9c:45e0 with SMTP id k13-20020a056e02156d00b0034f1e9c45e0mr1886638ilu.3.1697796132040; Fri, 20 Oct 2023 03:02:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697796132; cv=none; d=google.com; s=arc-20160816; b=Qu7ZVRiLQrrbnN6BpMiKpMkhwT6BCZxkwzigTLFg4/Dumv36IT29WIgPB343jKZBqg zXBu0JhAQ+0xxkxOLRP/2F1edcNlX1bJFb8nBkOhv0Nr9VNXG2zVI+Vr/fqZUXK4vI64 VPtiJ3aZSrZkEivY/ytmhkIjZQ0cdijXxO9gcBBbb0A5Wdk8tHDBoDI+Y1HJHo+7oNa+ BgM4boatq+qwvjd0wXMRkS8OgkdvBU7J2ZDJEx9Q4DhyQK5D91nUR8qIa97v5G1tbQjZ 7lCpIUjKuyMrnrlJ3PO5FphRXNvvMkW25LFB4mKnbMB6FdE/qacc/fYM/D4n2qYHuR+5 z9GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=peRqXjQQQ45HJmDIxv6CwSEgU//1lNonAjtSzwx3PGU=; fh=R7fRsQSi8SRZ7Ex7X4bNRVoR+QkDL9e/NGiRsGUI/8E=; b=NEeDtuf7FHh8oMjpmSQAdjJ9WAoMH93Q6teaC+XDAwLwl8lsTJkfSELPdsUf9PWQ0q c+izqll/6ULaYZp8/+NMY3Lqrz2Tjcz2iN8EkHQUt8LAlwSeKORHdvnZWu/owTNieVOg V18pXBjcZ8IloF5mHYcvQR0dGvQO/KJi8NBmueHp9DIAop1DAEJ9Z7zwAg0V/8RZ47WL 5jhsrStVvpCrpcKVwuAa+TejxPR6vg9lvsFVPRh7aEWji15pF28M+E8CP8xKN3tEh8g6 7uKodDX1nAywxzKlBoy/tVV09vnV+7QMmovGj6vnGuhg+fLItKjQ7PW1L0puY78+o5dd rzmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=WAt6zkRr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id y72-20020a638a4b000000b005a4d0e504bdsi1456160pgd.751.2023.10.20.03.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 03:02:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=WAt6zkRr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id DD0B7804C6C2; Fri, 20 Oct 2023 03:02:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376805AbjJTKBw (ORCPT + 99 others); Fri, 20 Oct 2023 06:01:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376946AbjJTKB3 (ORCPT ); Fri, 20 Oct 2023 06:01:29 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88394D66; Fri, 20 Oct 2023 03:00:58 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4064876e8b8so5430605e9.0; Fri, 20 Oct 2023 03:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697796056; x=1698400856; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=peRqXjQQQ45HJmDIxv6CwSEgU//1lNonAjtSzwx3PGU=; b=WAt6zkRrXTXbvp7uV9zadEt2O1sBo7iFog6EsgZnH/d3Pk1Dz2kI3NFcdhF5UN7hm4 mXtMixQebrkU7+DXfCSEavCu7vXffxc1vdFZjcuP+eqZRMvncs0hX67kN2dYefUXEXcp W9Qo//N9Av9pmWUnX8CAUVN4Te2RwVLOlRQrFs/PnWegi56YuLU7tuxhLCqhpbEt6ZNY GswuoyV5wn8lq6i9RqyjLWurTb+L7rri57jXx5riMLTjuG4EX3d7MTE/+8Ju5CWcd1RW QipibBOLPnpLWdJvh5eHoCHNy/GDohXkMyqG1m/cFeTaMUJxMavubDluUcc5eRuFPa59 wy+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697796056; x=1698400856; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=peRqXjQQQ45HJmDIxv6CwSEgU//1lNonAjtSzwx3PGU=; b=wzC2xsfrFnhPeh26GH24fQNurpsxq4ffcFHUnqUBgV08SwVvHFFg6V9vmPfDsCVMhU QtzGXA+SISdVVdEr9gb3tTUNS+9fIlTJbZMfumKTO17WbgW4mqdhB25lrBrTKOIl379G Suc6esTWrftN5qo2TnE65ENXkdTzmjFgSClA9wPXssGKigdHaOv4oeyUaAcNzVXukX22 UIcaZruBlf+qQtK2jmvdNq43BCUoly4J5fY7bnx6DZUwuaydaop9bhfjj4fPlwJTYiOu ErjCf/0sYzJz7OI+sSVAeStgrbJtU6scnPm4njo4uG1D7ap+0NIta/esqmdhEo5NyPOC 2FJA== X-Gm-Message-State: AOJu0YzSNzzfWgoEMVWe2vP4Vo9cFeUH+/MLoq8KB4EvrFbPDp0wdJML /vYDFreDmezL2A+uFE4TBBE= X-Received: by 2002:adf:f387:0:b0:319:68ce:2c53 with SMTP id m7-20020adff387000000b0031968ce2c53mr991596wro.25.1697796056321; Fri, 20 Oct 2023 03:00:56 -0700 (PDT) Received: from skbuf ([188.26.57.160]) by smtp.gmail.com with ESMTPSA id d14-20020adffd8e000000b0031984b370f2sm1320027wrr.47.2023.10.20.03.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 03:00:55 -0700 (PDT) Date: Fri, 20 Oct 2023 13:00:53 +0300 From: Vladimir Oltean To: Ante Knezic Cc: UNGLinuxDriver@microchip.com, andrew@lunn.ch, conor+dt@kernel.org, davem@davemloft.net, devicetree@vger.kernel.org, edumazet@google.com, f.fainelli@gmail.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, linux-kernel@vger.kernel.org, marex@denx.de, netdev@vger.kernel.org, pabeni@redhat.com, robh+dt@kernel.org, woojung.huh@microchip.com Subject: Re: [PATCH net-next v3 2/2] net:dsa:microchip: add property to select Message-ID: <20231020100053.wf3jivdkdfaunfgh@skbuf> References: <20231019165409.5sgkyvxsidrrptgh@skbuf> <20231020084620.4603-1-ante.knezic@helmholz.de> <20231020092729.gpbr7s2cbmznmal7@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231020092729.gpbr7s2cbmznmal7@skbuf> X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 20 Oct 2023 03:02:09 -0700 (PDT) On Fri, Oct 20, 2023 at 12:27:29PM +0300, Vladimir Oltean wrote: > On Fri, Oct 20, 2023 at 10:46:20AM +0200, Ante Knezic wrote: > > Ok, will do. I am guessing I should leave the existing > > ksz8795_cpu_interface_select() as it is? > > I would encourage moving it to the simpler call path as well, but > ultimately this is up to you. Also, could you please put spaces in the commit prefix ("net: dsa: microchip: ")?