Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Fri, 20 Oct 2023 12:46:37 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Christian Brauner <brauner@kernel.org>,
        Shuah Khan <shuah@kernel.org>,
        Tiezhu Yang <yangtiezhu@loongson.cn>,
        Tobias Klauser <tklauser@distanz.ch>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/clone3: Skip new time namespace test when
 unsupported
Message-ID: <bca5db5e-2536-4e3f-8d04-7e0e13203ad6@sirena.org.uk>
References: <20231020-kselftest-clone3-time-ns-v1-1-31a17e072a05@kernel.org>
 <20231019163538.69d494a0af0560a492b5ffb4@linux-foundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qSn9tPxObTSA9+Xo"
Content-Disposition: inline
In-Reply-To: <20231019163538.69d494a0af0560a492b5ffb4@linux-foundation.org>
Precedence: bulk


--qSn9tPxObTSA9+Xo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 19, 2023 at 04:35:38PM -0700, Andrew Morton wrote:
> On Fri, 20 Oct 2023 00:08:12 +0100 Mark Brown <broonie@kernel.org> wrote:

> > Use a filter function to skip the time namespace test on systems with
> > !CONFIG_TIME_NS. This reworks a fix originally done by Tiezhu Yang prior
> > to the refactoring in 34dce23f7e40 ("selftests/clone3: Report descriptive
> > test names"). The changelog from their fix explains the issue very clearly:

> I was about to send Tiezhu Yang's fix to Linus.   I'll rebase mm-hotfixes-stable
> to drop that patch, so you own it now!

> Please note that your version lacks an explicit cc:stable, but I suppose the
> stablebots will scoop it up anyway.

I think I was expecting Tiezhu's version to still get sent and then the
two versions to get merged - the refactoring that caused the conflict is
very clearly not stable material.

> > Original-fix-from: Tiezhu Yang <yangtiezhu@loongson.cn>

> "Original-fix-from" isn't a thing.  In fact it seems to be the first
> time this has been used.  Grepping for  "Original-.*:" shows
> all sorts of innovations, including "Based-on-the-original-screenplay-by:".

> I guess Documentation/process/submitting-patches.rst and checkpatch
> lost this fight a long time ago.

Well, they've always been documenting existing practice.

--qSn9tPxObTSA9+Xo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmUyaJwACgkQJNaLcl1U
h9BR3Af/Uf7ib9YeIsoiSpGtzNPGw7rRx00YLF141fdedu3LxJFGWXqKsofcpD/7
TbxWppJ/42QTQPvypvpY1QU5BENGr2DdqULp76eR1vnXsl/XLoBd+eZPkQLf8VsJ
1GREd9llwocTaStvT9rNQ4eYk/bEoIe3gT7wIxB22j5rv9Aks3/eSKFIfN4Ymo96
2FqJAmRMn+4HdfYsSAZaQb0iGgWzeRzySBBBY4pe6/yf/ruLoPzPMRGG1WtcH02P
FOwKpkeZAWQDleM4rHEr8btxE8UTW2qCtf6dPFYDGUKRjuD6/Xez6+cXmrm3KXdn
+J8tIlSDB4+aX8C+gNDypuJ2Qy2TgA==
=Rfrq
-----END PGP SIGNATURE-----

--qSn9tPxObTSA9+Xo--