Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Fri, 20 Oct 2023 15:45:28 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     "Zbigniew, Lukwinski" <zbigniew.lukwinski@linux.intel.com>
Cc:     Frank Li <Frank.Li@nxp.com>, alexandre.belloni@bootlin.com,
        conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com,
        linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] i3c: master: add enable(disable) hot join in sys
 entry
Message-ID: <20231020154528.2f5f68f5@xps-13>
In-Reply-To: <57efe6de-cf65-32ed-fd1e-a388e1676c70@linux.intel.com>
References: <20231018205929.3435110-1-Frank.Li@nxp.com>
        <20231018205929.3435110-2-Frank.Li@nxp.com>
        <57efe6de-cf65-32ed-fd1e-a388e1676c70@linux.intel.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Lukwinski,

zbigniew.lukwinski@linux.intel.com wrote on Fri, 20 Oct 2023 10:55:27
+0200:

> On 10/18/2023 10:59 PM, Frank Li wrote:
> > Add hotjoin entry in sys file system allow user enable/disable hotjoin
> > feature.
> >
> > Add (*enable(disable)_hotjoin)() to i3c_master_controller_ops.
> > Add api i3c_master_enable(disable)_hotjoin(); =20
>=20
> What is the use case for having HJ enable knob in sysfs available for use=
r space other than for debug stuff? In other words, does user space really =
need to enable/disable HJ in runtime for other reason but debug? If it is o=
nly for debug maybe it=C2=A0 could be move to debugFS?

I don't think hotjoin should be considered as a debug feature. The
problem here is the power consumption which is higher if you enable
this feature (you need to keep everything clocked and ready to handle
an IBI) whereas if your design is "fixed" (more like an I2C bus) you
may save power by disabling this feature.

A module parameter does not fit here because it's a per-bus
configuration.

Thanks,
Miqu=C3=A8l